strtotime to check if they voted within the last hour

[3raser]

My site allows users to vote once per hour, and it checks the next time they vote if it's been 3600 seconds  (1 hour) since their last vote. But, it always returns the value 0.

 

			$grab = mysql_fetch_assoc($has_voted);
			$calc = strtotime($grab['date']) - strtotime(date("M-d-Y"));

			if($calc > 3600)
			{
				mysql_query("DELETE FROM votes WHERE ip = '". $_SERVER['REMOTE_ADDR'] ."'");
				header("location:votes.php?id=". $id ."");
			}
			else
			{
				echo 
				echo "You've voted within the last hour. Please wait ". $calc ." seconds.";
			}

[Zurev]

What is $grab['date'] formatted as, does it actually include the time as well, or is it just the format M-d-Y, in which case it would always return 0 unless it were 1 or more days apart.

[Pikachu2000]

Would something like this be easier for you?

$query = "DELETE FROM votes WHERE ip = '{$_SERVER['REMOTE_ADDR']}' AND `field_that_holds_datetime` < DATE_SUB( NOW(), INTERVAL 1 HOUR )"
mysql_query( $query );

[kenrbnsn]

What is the format of $grab['date']?

 

To get the current date in seconds, all you need is time.

 

Ken

[3raser]

I tried time(), but it just lets users vote as much as they want. o.O

 

                         if(mysql_num_rows($has_voted) > 0) 
		{
			$has_voted = mysql_query("SELECT date FROM votes WHERE ip = '". $_SERVER['REMOTE_ADDR'] ."'");
			$grab = mysql_fetch_assoc($has_voted);

			$calc = $grab['date'] - time();

			if($calc > 3600)
			{
				mysql_query("DELETE FROM votes WHERE ip = '". $_SERVER['REMOTE_ADDR'] ."'");
				header("location:vote.php?id=". $id ."");
			}
			else
			{
				echo "You've voted within the last hour. Please wait ". $calc ." seconds.";
			}

		}
		else
		{
			if($_POST['name_vote_f'] && $_POST['id_vote_f'])
			{
				echo "You have successfully voted!";
				mysql_query("INSERT INTO votes VALUES (null, '". $_SERVER['REMOTE_ADDR'] ."', '". time() ."')");
				mysql_query("UPDATE sites SET votes = votes + 1 WHERE id = '$id'");
			}
			else
			{
					$grab = mysql_fetch_assoc($query);

					echo "<b>Voting for ". $grab['title'] .". Are you sure?</b><br/><br/>
					<form action='vote.php' method='POST'>
					<input type='hidden' name='name_vote_f' value='". $grab['title'] ."'>
					<input type='hidden' name='id_vote_f' value='". $id ."'>
					<input type='submit' value='Yes, vote now!'>
					</form>";
			}
		}

[kenrbnsn]

Again, what does $grab['date'] contain.

 

Also, you want to subtract the old value ($grab['date']) from the current time. When you do it your way, you will get a negative number which will always be less than 3600. :-)

 

Ken

[3raser]

Again, what does $grab['date'] contain.

 

Also, you want to subtract the old value ($grab['date']) from the current time. When you do it your way, you will get a negative number which will always be less than 3600. :-)

 

Ken

 

Thanks! And $grab['date'] is just time().

 

EDIT: Still no difference.

[kenrbnsn]

Do some debugging on your own. Put echo statements in to show what values are being used:

<?php
$has_voted = mysql_query("SELECT date FROM votes WHERE ip = '". $_SERVER['REMOTE_ADDR'] ."'");
$grab = mysql_fetch_assoc($has_voted);
        $cur = $time();
        echo "Current time: $cur<br>\n";
        $saved = $grab['date'];
        echo "Saved time: $saved<br>\n";
        $diff = $cur - $saved;
        echo "Diff: $diff<br>\n";
?>

 

This should show where the problem lies.

 

Ken

 

[3raser]

Do some debugging on your own. Put echo statements in to show what values are being used:

<?php
$has_voted = mysql_query("SELECT date FROM votes WHERE ip = '". $_SERVER['REMOTE_ADDR'] ."'");
$grab = mysql_fetch_assoc($has_voted);
        $cur = $time();
        echo "Current time: $cur<br>\n";
        $saved = $grab['date'];
        echo "Saved time: $saved<br>\n";
        $diff = $cur - $saved;
        echo "Diff: $diff<br>\n";
?>

 

This should show where the problem lies.

 

Ken

 

Thanks ken, I figured it out. It seems $has_voted was in the wrong place.