error on simple form

[xwishmasterx]

I have an error somewhere in the form as it does not output what I want it too. I know the form itself is working as I have added an echo to see if the form inputs are processed.

 

the code:

<?php
$amount = $_POST['amount'];
$member = $_POST['member'];

$sql = ("SELECT name FROM vtp_members WHERE name=".$member." ");
$result = mysql_query($sql);
$numrows = mysql_num_rows($result);
if($numrows = '1')
{
  while($row = mysql_fetch_array($result, MYSQL_ASSOC))
    {
echo "You sent ". $amount . " to " . $member . ".<br />";
}
}
echo " ".$amount." and ".$member." ";
?>

 

It outputs the last echo correct.

 

is there anyone who can see what I'm doing wrong?

[spiderwell]

if($numrows = '1')

 

look closer

[Pikachu2000]

Try:

$sql = "SELECT name FROM vtp_members WHERE name='$member'";

 

And change:

if($numrows = '1')

 

To:

if($numrows == '1')

 

See if that clears things up.

[spiderwell]

damn i keep missing those single quote errors lol

[xwishmasterx]

thank you both. Sometimes you just need someone else to take a look too find the stupid mistakes

[Pikachu2000]

While you're at it, there's no need to concatenate the variables into the strings all the time like that. The output from the following is the same as what will be generated by your echoes.

 

echo "You sent $amount to $member<br />";
}
}
echo " $amount and $member";

[dcro2]

Moral of the story: always check if your queries succeeded.

[spiderwell]

While you're at it, there's no need to concatenate the variables into the strings all the time like that. The output from the following is the same as what will be generated by your echoes.

 

echo "You sent $amount to $member<br />";
}
}
echo " $amount and $member";

 

is there a performance difference with doing it this way? i always use the . concatenate method , just because i find it easier to read in notepad++, lol