Help with this function...

[devWhiz]

<?php

function URLs(){
    $a = "http://www.yahoo.com";
    $b = "http://www.google.com";
    $c = "http://www.phpfreaks.com";
    return($b);
}

echo URLs($b);
sleep(10000);
?>

 

 

how would I get it to echo out $a without having to change the return value in the function, I want it to be like where I can put URLs($c) without having to change the return part of the function, any help is appreciated, thanks

[cyberRobot]

You could change it to something like:

 

<?php

function URLs($getURL = '') {
     $urlToReturn = '';
     switch($getURL) {
          case 'yahoo':       $urlToReturn="http://www.yahoo.com"; break;
          case 'google':      $urlToReturn="http://www.google.com"; break;
          case 'phpfreaks': $urlToReturn="http://www.phpfreaks.com"; break;
     }
     return $urlToReturn;
}


echo URLs('google');
sleep(10000);

?>

 

 

Note that the code is untested.

[KevinM1]

You've made it too inflexible.  Use an array, and pass in the array index through the argument list:

 

function URLs($name)
{
   $urls = array('some key' => 'http://www.yahoo.com', 'another key' => 'http://www.google.com', 'yet another key' => 'http://www.phpfreaks.com');

   if (array_key_exists($name, $urls))
   {
      return $urls[$name];
   }
}

 

Of course, there are still better ways to do this where your allowed URLs aren't hard coded in the function.

[PFMaBiSmAd]

I would use an array of the choices and use the index/key value to pick and return the one you want. Edit: Code posted above ^^^.