if statement

[eMonk]

The following code works but wondering if I should be using $update1, $update2, $rsUpdate1, $rsUpdate2 instead for error checking etc.

 

$update = "UPDATE model SET name = '$name', age = '$age', ... ";
$rsUpdate = mysql_query($update);

if( isset($city_1) )
{
$update = "UPDATE model_in_city SET city_id = '$city_1', ...'";
$rsUpdate = mysql_query($update);
}

if( isset($city_2) )
{
$update = "UPDATE model_in_city SET city_id = '$city_2', ...'";
$rsUpdate = mysql_query($update);
}

if ($rsUpdate) // insert $rsUpdate2 && $rsUpdate3 here as well?
{
echo "Update successful.";
}

 

[fugix]

variable scope is involved here. since you declare both $update and $rsUpdate outside of any statements...when you declare them again in your if statements you are writing over them....the best practice would be to change the variables like you have in your initial question text

[Maq]

Huh?  Yes, you should be handling errors from $rsUpdate correctly.  Similar to:

http://www.phpfreaks.com/blog/or-die-must-die

[eMonk]

Would this be the correct if sytnax?

 

if ($rsUpdate1, $rsUpdate2, $rsUpdate3)

{

echo "Update successful.";

}

[fugix]

if you require that all three to be set, then you would use

if ($rsUpdate1 && $rsUpdate2 && $rsUpdate3)
{
echo "Update successful.";
}

else you can use

[code]if ($rsUpdate1 || $rsUpdate2 || $rsUpdate3)
{
echo "Update successful.";
}

[/code]