PHP, Javascript & Popup Window

[elabuwa]

Hi Guys,

Not sure which section this thread should go to.

 

Probably a simple issue, but after staring @ the screen for long hours I just cant see it.

 

There are some pictures that are dynamically generated when the page is loaded. I have defined the width and height when they are loaded.

However, I would like a popup to appear once some clicks on the image showing the actual size of it.

 

I have written some javascript code and added the necessary modifications in my php code, but nothing appears when a value is passed to the javascript function, but the popup appears when nothing is passed. Probably a comma issue but I fail to see it.

 

Javascript Code

var newwindow;
function poptastic(url)
{
newwindow=window.open(url,'name','height=400,width=400');
if (window.focus) {newwindow.focus()}
}

 

PHP Code

	
$t = 'preview.php?it=' . $it;
echo "<a href='javascript:poptastic(".$t.");'><img src='$i1' height='100' width='100'/></a>  ";

 

If I run the below php code the popup works, but I can't pass any value to the javascript function.

		
//$t = 'preview.php?it=' . $it;
echo "<a href='javascript:poptastic();'><img src='$i1' height='100' width='100'/></a>  ";

[gristoi]

you are escaping your string when you try to add the t variable.:

echo "<a href='javascript:poptastic(".$t.");'><img src='$i1' height='100' width='100'/></a>  ";

should be:

echo "<a href='javascript:poptastic(\".$t.\");'><img src='$i1' height='100' width='100'/></a>  ";

[cyberRobot]

I think gristoi is on the right track. When calling your poptastic() function, the URL argument needs to be surrounded by quotes. So you could use something like:

 

echo "<a href='javascript:poptastic(\"".$t."\");'><img src='$i1' height='100' width='100'/></a>  ";

 

 

Or:

 

echo "<a href='javascript:poptastic(\"$t\");'><img src='$i1' height='100' width='100'/></a>  ";

 

 

Note that I removed the dots from the second code example.

[elabuwa]

thank you guys.

Worked like a charm