Undefined Constant

[The Little Guy]

I have a class, and some of the methods take parameters like this: EXTRACT_SYMBOL, EXTRACT_NUMBER, etc. when I run this, I get the following:

Notice: Use of undefined constant EXTRACT_SYMBOL - assumed 'EXTRACT_SYMBOL' in C:\wamp\www\phpLive\index.php on line 11

 

What should I do, not to turn the errors off, but to make the code valid? What ever I need to do, I want to do within the class/method, and not outside it if possible.

 

public class myClass{
    public function myFunction($value, $action){
        switch($action){
             case EXTRACT_SYMBOL:
                 // Do some stuff
                 break;
             case EXTRACT_NUMBER:
                 // Do some stuff
                 break;
        }
    }
}

$cls = new myClass();
$cls->myFunction('Some string', EXTRACT_NUMBER);

 

Thanks!

[gristoi]

where have you declared the constant for EXTRACT_NUMBER ?

[PFMaBiSmAd]

Do you want those to be defined constants or literal strings -

 

define('EXTRACT_SYMBOL',1); // a constant

 

or

 

Strings -

 

case 'EXTRACT_NUMBER':


$cls->myFunction('Some string', 'EXTRACT_NUMBER');

 

[The Little Guy]

looks like I want this

define('EXTRACT_SYMBOL',1); // a constant

 

Do I put that above my class?

 

Like this:

define('EXTRACT_SYMBOL',1);
public class myClass{
    public function myFunction($value, $action){
        switch($action){
             case EXTRACT_SYMBOL:
                 // Do some stuff
                 break;
             case EXTRACT_NUMBER:
                 // Do some stuff
                 break;
        }
    }
}

$cls = new myClass();
$cls->myFunction('Some string', EXTRACT_NUMBER);

 

or inside the constructor?

[Adam]

If using classes, you should define them as a class constant:

 

class Foo
{
    const constant1 = 1;
    const constant2 = 2;

    [...]

 

Then accessed through:

 

self::constant1 // from within the class
Foo::constant1 // from outside of the class

[The Little Guy]

but they are being passed as parameters to the methods

[Adam]

Yeah..? If outside of the class, use Foo::constant:

 

$foo->someMethod(Foo::constant)

 

IF you're calling the method internally, use self.