T_ELSE syntax error

[quelle]

On 25th and 29 th line

<?php
include('includes/functions.php');
session_start();

if(isset($_POST['login'])){	
if(isset($_POST['username'])){		
	if(isset($_POST['password'])){
		$query = mysql_query('SELECT * FROM users WHERE Username = $_POST["username"]') or die(mysql_error());
		$user = mysql_fetch_array($query);

		if($_POST['password'] == $user['Password']){
			echo "Uspješan login!";
			$_SESSION['user'] = $user['username'];
			header('Location: index.php');

		} else {
			echo "Provjerite login detalje!";
			include('login.php');
		}

	} else {
		echo "Password netačan!";
		include('login.php');

} else {
	echo "Username netačan!";
	include('login.php');

} else {
echo "Niste ispunili sve podatke!";
include('login.php');
}
?>

[phpSensei]

Theres a syntax error inside your query, your missing a closing bracket also on one of the ELSE

 

try this

 

<?php


include('includes/functions.php');
session_start();

if(isset($_POST['login'])){

if(isset($_POST['username'])){		


	if(isset($_POST['password'])){



		$query = mysql_query('SELECT * FROM users WHERE Username = "'.$_POST["username"].'"') or die(mysql_error());
		$user = mysql_fetch_array($query);

		if($_POST['password'] == $user['Password']){
			echo "Uspješan login!";
			$_SESSION['user'] = $user['username'];
			header('Location: index.php');

		} else {
			echo "Provjerite login detalje!";
			include('login.php');
		}




	} else {
		echo "Password netačan!";
		include('login.php');

	}

} else {
	echo "Username netačan!";
}	include('login.php');

} else {
echo "Niste ispunili sve podatke!";
include('login.php');
}
?>


?>

[quelle]

Nah, query works fine, even on ur way but im still having the syntax problem

[phpSensei]

Nah, query works fine, even on ur way but im still having the syntax problem

 

What was the error ouput after you tried my code?

[quelle]

Sorry for a late reply, i slept here on my desk  havent sleep whole night btw the error was

Parse error: syntax error, unexpected T_ELSE in D:\xampp\htdocs\CMSSITE\admin\dologin.php on line 25

[trq]

Check your curly braces. Simple syntax errors should not require the help of a forum.

 

If you still can't find the error, post your current code.

[quelle]

Well i checked, and i posted it in first post

[SpaceLama]

Tell us what is line 25? You need to count your {}... do you have as many opening as closing? This is why you get the error at first place.

 

Get your strings without an variable within '' and not within "".

[hoponhiggo]

Looks to me like you dont have enough closing curly braces. There seem to be a few in the top half of your code that arent being closed.

 

[trq]

Well i checked, and i posted it in first post

 

We need to see your current code. if you haven't changed your code since your first post you need to re-read the replies already given.

[teynon]

You're logic is heavily faltered and you appear to be taking no ones advice. Look at your code:

 

else {
		echo "Password netačan!";
		include('login.php');

} else {
	echo "Username netačan!";
	include('login.php');

} else {
echo "Niste ispunili sve podatke!";
include('login.php');
}

 

You have three elses in line.

 

else { } else {} else {}

 

Tell me this doesn't work and i'll tell you to take hike.

<?php
include('includes/functions.php');
session_start();

if(isset($_POST['login'])) {	
if(isset($_POST['username'])) {		
	if(isset($_POST['password'])){
		$query = mysql_query('SELECT * FROM users WHERE Username = $_POST["username"]') or die(mysql_error());
		$user = mysql_fetch_array($query);

		if ($_POST['password'] == $user['Password']) {
			echo "Uspješan login!";
			$_SESSION['user'] = $user['username'];
			header('Location: index.php');

		}
		else {
			echo "Provjerite login detalje!";
			include('login.php');
		}

	}
	else {
		echo "Password neta&#269;an!";
		include('login.php');

	}
}
else {
	echo "Username neta&#269;an!";
	include('login.php');

}
}
else {
echo "Niste ispunili sve podatke!";
include('login.php');
}
?>

[the182guy]

Try using the Notepad++ editor to write your code, it is great for quickly finding syntax errors like this because you can have it show you which IF's are connected to which ELSE's etc, and you can click a brace and it will highlight the corresponding closing brace.

 

 

if(isset($_POST['login'])){

 

On another note I'm guessing your login variable is the form's submit button? If so then you have a compatibility problem with IE. See Why isset post is not compatible with Internet Explorer.

[teynon]

While what the 182guy said is true, the form could be submitted using the enter key, I disagree with using ($_SERVER['REQUEST_METHOD'] == 'POST'). I think you should simply create a hidden form field.

 

IE <input type="hidden" name="formSubmitted" value="1">

 

Then check it like:

 

if (isset($_POST['formSubmitted'])) {

}

[quelle]

dAMN im really a cock sucker lolz, i closed brackets for else and didnt for whole if lol thanks tenyon for pointing out mistakes btw u said

I disagree with using ($_SERVER['REQUEST_METHOD'] == 'POST'). I think you should simply create a hidden form field.

 

IE <input type="hidden" name="formSubmitted" value="1">

 

Then check it like:

 

if (isset($_POST['formSubmitted'])) {

}

Can u indicate where i used that method?

[teynon]

quelle, i'm refering to the link in the182guy's post.

[quelle]

Try using the Notepad++ editor to write your code, it is great for quickly finding syntax errors like this because you can have it show you which IF's are connected to which ELSE's etc, and you can click a brace and it will highlight the corresponding closing brace.

 

 

if(isset($_POST['login'])){

 

On another note I'm guessing your login variable is the form's submit button? If so then you have a compatibility problem with IE. See Why isset post is not compatible with Internet Explorer.

Since im using firefox i didnt notice it yet but thanks for ur help