url like www.example.com/?p=23

[UnknownPlayer]

Hi,

i have problem with urls like www.example.com/?p=23

 

This is my htaccess code:

RewriteEngine on
RewriteCond %{REQUEST_FILENAME} !-f
RewriteRule ^/?p=([0-9]+)$ post.php?pid=$1 [L]
RewriteRule ^all/$ all.php [L]
RewriteRule ^popular/$ popular.php [L]
RewriteRule ^recent/$ recent.php [L]
RewriteRule ^random/$ random.php [L]
RewriteRule ^search/$ search.php [L]

 

Now this code:

RewriteRule ^/?p=([0-9]+)$ post.php?pid=$1 [L]

doesn't work, it shows me home page.. how  can i make that to work ?

[requinix]

RewriteRule only looks at the path. It does not consider query strings.

RewriteCond %{REQUEST_FILENAME} !-f
RewriteCond %{REQUEST_URI} ^/\?p=(\d+)$
RewriteRule ^ post.php?pid=%1 [L]

 

Do you not have an index.php? Surely you do. Then forget mod_rewrite and just

if (count($_GET) == 1 && !empty($_GET["p"])) {
    $_GET["pid"] = $_GET["p"];
    include "post.php";
    return;
}

// ...

[UnknownPlayer]

Thanks, it works very well..

But 1 question, do i need to put return; ?

[requinix]

Yes. Otherwise the rest of the script will continue executing. (exit() and die() work too but I prefer return.)