foreach with in a foreach, bad idea?

[Iluvatar+]

Alright guys,

 

Just wondering if anyone could give me a bit of advice. I am using a foreach with in a foreach to insert records in a table. This is the only solution i could come up up with for the nature of this function. I will try and explain as simple as possible...

 

I needed to insert a set of records for each department, each set of records are based on how many franchise there is (with in a table).

 

 

This is my code which is working fine, but i want to make sure it's the best way to go about this. (keep in mind i am using cakephp)

 

<?php
    //...

                                                        $this->loadmodel('Userdepartmentlink');

						$this->loadmodel('Department'); /**/ $departments = $this->Department->find('all');

						foreach($departments as $departments){

							$department_id = $departments['Department']['id'];
							$this->loadmodel('Franchise');  /**/ $franchises = $this->Franchise->find('all');
							foreach($franchises as $franchises){

									$sets = array(
												array(
													  'user_id'=>'7',
													  'department_id'=>$department_id,
													  'franchise_id'=>$franchises['Franchise']['id']
													  ),
										   );


									if($this->Userdepartmentlink->saveAll($sets)) {
										echo "saved";
									}
									else {
										echo "doesnt work";
									}

							}




?>

[Muddy_Funster]

yeah....I got no idea what's actualy happening there.  Shouldn't this be in the "Other frameworks" section?

[scootstah]

I haven't worked with CakePHP, but you can insert data in batches like this:

INSERT INTO table (col1, col2, col3) VALUES (1,2,3), (4,5,6), (7,8,9);

 

This would insert 3 new rows.

[thehippy]

Do you always need all fields for your purposes? NO its a waste of memory, start using $find(,array('fields'=>'') for better efficacy

 

foreach($departments as $departments) and foreach($franchises as $franchises)? NO

 

Do not load the same model on each iteration of the foreach loop.  Waste of time/memory

 

Stop doing this single line nonsense "$this->loadmodel('Department'); /**/ $departments = $this->Department->find('all');"

Break up the code by putting it on another line, use vertical spacing to group similar code.

 

Error out or make use of a logger, echo'ing is only good for debugging.

 

Document what you're doing with this function, in a month will you really understand what this does?

 

As for your main concern, you need to reread the Models documentation, especially the section concerning associations.

[Iluvatar+]

Clearly a relevant response to my question!?! :S

[Mahngiel]

i tried to read, but i stopped when the code block had 8 levels of indentation...