DELETE wont work :(

[almightyegg]

[code=php:0]
<?
$mb = mysql_query("SELECT * FROM replies") or die(mysql_error());
$id = mysql_fetch_array($mb);

$GET = $id['id'];

$view = "SELECT * FROM replies WHERE id = '{$_GET['id']}' LIMIT 1";
$view2 = mysql_query($view);
$reply = mysql_fetch_assoc($view2);
//some other code in here which doesnt have anything to do with this....

if(!$step){
?>
<form name="form1" method="post" action="rdelete.php?step=change">
Are you sure you want to delete reply <? echo $reply[id]; ?>?
<input type="submit" name="Submit" value="Confirm" />
</p>
</form><br>
<?
}elseif($step=="change"){
$deletereply = mysql_query("DELETE FROM replies WHERE id = '{reply['id']}'");
echo "$reply[id] was deleted!";
}
?>
[/code]

it doesnt delete.....have i missed something??

[trq]

[quote]have i missed something??[/quote]

Yes. Take a close look at your DELETE query. Your missing a $

[almightyegg]

doesnt delete still :(
[code=php:0]
<?
if(!$step){
?>
<form name="form1" method="post" action="rdelete.php?step=change">
Are you sure you want to delete reply <? echo $reply[id]; ?>?
<input type="submit" name="Submit" value="Confirm" />
</p>
</form><br>
<?
}elseif($step=="change"){
$deletereply = mysql_query("DELETE FROM replies WHERE id = '{$reply['id']}'");
echo "The reply was deleted!";
}
?>
[/code]
I must have missed something else too  :-[

[Orio]

Look at this-
[code]$GET = $id['id'];
$view = "SELECT * FROM replies WHERE id = '{$_GET['id']}' LIMIT 1";[/code]

Once it's $GET and once it's $_GET

Orio.

[almightyegg]

nope still no change  ??? this is very odd...
[code=php:0]
<?
$mb = mysql_query("SELECT * FROM replies") or die(mysql_error());
$id = mysql_fetch_array($mb);

$GET = $id['id'];

$view = "SELECT * FROM replies WHERE id = '{$GET['id']}' LIMIT 1";
$view2 = mysql_query($view);
$reply = mysql_fetch_assoc($view2);

$tags = array('{MEM_ID}', '{MEM_USERNAME}', '{MEM_CLUTCH}');
$vals = array($mem['id'], $mem['username'], $mem[clutch]);
$qlink['quicklinks'] = str_replace($tags, $vals, $qlink['quicklinks']);
echo "$qlink[quicklinks]";

//Some separate code here

if(!$step){
?>
<form name="form1" method="post" action="rdelete.php?step=change">
Are you sure you want to delete reply <? echo $reply[id]; ?>?
<input type="submit" name="Submit" value="Confirm" />
</p>
</form><br>
<?
}elseif($step=="change"){
$deletereply = mysql_query("DELETE FROM replies WHERE id = '{$reply['id']}'");
echo "The reply was deleted!";
}
?>
[/code]

[Orio]

Maybe there's a problem with the variable $reply['id']. How is it set?

Orio.

[almightyegg]

$view = "SELECT * FROM replies WHERE id = '{$GET['id']}' LIMIT 1";
$view2 = mysql_query($view);
$reply = mysql_fetch_assoc($view2);

[almightyegg]

right the delete works now...but it is selecting bottom row number and deleting the row with id that equals the number of rows  ???

[Orio]

Because you didnt specify what row to select, and by doing this:
[code]$mb = mysql_query("SELECT * FROM replies") or die(mysql_error());
$id = mysql_fetch_array($mb);
$GET = $id['id'];[/code]
you get the id of the first row.

Orio.

[almightyegg]

thanks...it now recognises the row etc...but doesnt delete it  ???
[code=php:0]
<?
$id = $_GET['id'];

$view = "SELECT * FROM replies WHERE id = '$id' LIMIT 1";
$view2 = mysql_query($view);
$reply = mysql_fetch_assoc($view2);

\\other code..not to do with this

if(!$step){
?>
<form name="form1" method="post" action="rdelete.php?step=change">
Are you sure you want to delete reply <? echo $id; ?>?
<input type="submit" name="Submit" value="Confirm" />
</p>
</form><br>
<?
}elseif($step=="change"){
$deletereply = mysql_query("DELETE FROM replies WHERE id = '$id'");
$delrep = mysql_query($deletereply);

echo "The reply was deleted!";
}
?>

[trq]

Post your entire code again, and try some debugging!

[almightyegg]

[code=php:0]
<?
$id = $_GET['id'];

$view = "SELECT * FROM replies WHERE id = '$id' LIMIT 1";
$view2 = mysql_query($view);
$reply = mysql_fetch_assoc($view2);

if(!$step){
?>
<form name="form1" method="post" action="rdelete.php?step=change">
Are you sure you want to delete reply <? echo $id; ?>?
<input type="submit" name="Submit" value="Confirm" />
</p>
</form><br>
<?
}elseif($step=="change"){
$deletereply = mysql_query("DELETE FROM replies WHERE id = '$id'");
$delrep = mysql_query($deletereply);

echo "The reply was deleted!";
}
?>
[/code]

[trq]

Sorry but that code makes little sense. For starters... what do you need the SELECT at the top for? Next, your form asks if your user is sure they want to delete $id, but if they submit the form $id is never passed to the script again for use in your DELETE. where do you define $step? Why are you using an elseif when an else is sufficient?

[almightyegg]

ive made it work. thanks :) I used the advice you gave about hidden field (value=$id) and so it now works :D