Mysql Query Help

[DrTrans]

$propid = $_POST['propid'];

$queryreg = mysql_query("UPDATE props SET
                         (`address`,`city`,`state`,`zip`,`active`,`lease`,`leaseamt`,`deposit`,`latefee`,`managementfee`,`background`, `uselatefee`) 
                         VALUES
                         ('$address','$city','$state','$zip','$active','$lease','$rent','$deposit','$latefee','$managementfee','$background','$usealatefee') WHERE propid = '$propid'"
                       ) or die(mysql_error());

 

 

wondering why this query does not work.

[Pikachu2000]

What doesn't work about it? Any errors?

[DrTrans]

You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '(`address`,`city`,`state`,`zip`,`active`,`lease`,`leaseamt`,`deposit`,`latefee`,' at line 2

[Barand]

You are using INSERT syntax.

 

UPDATE syntax is

 

UPDATE tablename SET field1 = value1, field2 = value2 ..... WHERE ....

[DrTrans]

I understand that. but I'm updating multiple variables. Isn't there a much simpler way to do this.

[PFMaBiSmAd]

The following is the UPDATE query syntax definition, with the most common usage shown in red -

 

UPDATE [LOW_PRIORITY] [iGNORE] table_reference

    SET col_name1={expr1|DEFAULT} [, col_name2={expr2|DEFAULT}] ...

    [WHERE where_condition]

    [ORDER BY ...]

    [LIMIT row_count]

 

 

[Illusion]

I understand that. but I'm updating multiple variables. Isn't there a much simpler way to do this.

 

Unfortunately not.

 

A good practice may be inserting the record with a different version by having version column.

 

if you are updating all the columns except id then actually you want to do a insert(assuming there are constraints in doing so ) and delete the old record.

[fenway]

Of course there's an easier way -- use a DB wrapper to write the queries for you, and pass it a hash.