vinsux Posted July 5, 2012 Share Posted July 5, 2012 PHP DOWNLOAD ERROR.. Please helpp... i can't debug the error.. upload.php <form method="post" enctype="multipart/form-data"> <table width="350" border="0" cellpadding="1" cellspacing="1" class="box"> <tr> <td width="246"> <input type="hidden" name="MAX_FILE_SIZE" value="2000000"> <input name="userfile" type="file" id="userfile"> </td> <td width="80"><input name="upload" type="submit" class="box" id="upload" value=" Upload "></td> </tr> </table> </form> <?php if(isset($_POST['upload']) && $_FILES['userfile']['size'] > 0) { $fileName = $_FILES['userfile']['name']; $tmpName = $_FILES['userfile']['tmp_name']; $fileSize = $_FILES['userfile']['size']; $fileType = $_FILES['userfile']['type']; $fp = fopen($tmpName, 'r'); $content = fread($fp, filesize($tmpName)); $content = addslashes($content); fclose($fp); if(!get_magic_quotes_gpc()) { $fileName = addslashes($fileName); } $con = mysql_connect("localhost","root",""); //check or connected to server if(!$con) { die("could not connect to server".mysql_error()); } //select test database mysql_select_db("files", $con); $query = "INSERT INTO upload (name, size, type, content ) ". "VALUES ('$fileName', '$fileSize', '$fileType', '$content')"; mysql_query($query) or die('Error, query failed'); mysql_close($con); echo "<br>File $fileName uploaded<br>"; } ?> download.php <html> <head> <title>Download File From MySQL</title> <meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1"> </head> <body> <?php $con = mysql_connect("localhost","root",""); //check or connected to server if(!$con) { die("could not connect to server".mysql_error()); } //select test database mysql_select_db("files", $con); $query = "SELECT id, name FROM upload"; $result = mysql_query($query) or die('Error, query failed'); if(mysql_num_rows($result) == 0) { echo "Database is empty <br>"; } else { while(list($id, $name) = mysql_fetch_array($result)) { ?> // HERE IS THE LINE OF ERROR... <a href="download.php?id=<"?php=$id;?>"><?php=$name;?></a> <br> } } mysql_close($con); ?> </body> </html> <?php if(isset($_GET['id'])) { // if id is set then get the file with the id from database $con = mysql_connect("localhost","root",""); //check or connected to server if(!$con) { die("could not connect to server".mysql_error()); } mysql_select_db("files", $con); $id = $_GET['id']; $query = "SELECT name, type, size, content " . "FROM upload WHERE id = '$id'"; $result = mysql_query($query) or die('Error, query failed'); list($name, $type, $size, $content) = mysql_fetch_array($result); header("Content-length: $size"); header("Content-type: $type"); header("Content-Disposition: attachment; filename=$name"); echo $content; mysql_close($con); exit; } ?> i try to change the <a href="download.php?id=<"?php=$id;?>"><?php=$name;?></a> <br> to <a href='download.php?id='<'?php=$id;?>'><'?php=$name;?'></a> But still can't fix.. pls. help me.. tnx in advance.. Quote Link to comment Share on other sites More sharing options...
requinix Posted July 5, 2012 Share Posted July 5, 2012 What error? Quote Link to comment Share on other sites More sharing options...
vinsux Posted July 5, 2012 Author Share Posted July 5, 2012 Whenever i click the liNk,instead of the file.. it download the HTML page... i cant see the file name.. but when i upload.. it is stored in the database... in the download.php <a href="download.php?id=<"?php=$id;?>"><?php=$name;?></a> <br> before mysql($con) Quote Link to comment Share on other sites More sharing options...
requinix Posted July 5, 2012 Share Posted July 5, 2012 download.php cannot show any HTML when it does the download. The download page and the downloading code have to be completely separate: either you show the page or you do a download. In other words, if (do a download) { do the download; exit; } show the download page Quote Link to comment Share on other sites More sharing options...
Recommended Posts
Join the conversation
You can post now and register later. If you have an account, sign in now to post with your account.