Why is my simple implode array failing?

[DBookatay]

I am trying to create a mailing list, with the email addresses being pulled from the dB. I have this:

$emails = array($row['email']);
$list .= implode('; ', $emails);

 

Which returns all of the values from the dB, but it is not creating the "; " (semicolon and space) between each email address.

[Drongo_III]

Try:

 

$list .= implode('; ', $row['email']);

 

I am trying to create a mailing list, with the email addresses being pulled from the dB. I have this:

$emails = array($row['email']);
$list .= implode('; ', $emails);

 

Which returns all of the values from the dB, but it is not creating the "; " (semicolon and space) between each email address.

[AyKay47]

Just from the context of those two lines, a few things can be said:

 

1. $row is already an array (What does the index "email" actually hold?)

 

2. $emails contains a two dimensional array

 

3. A variable that does not yet exist in the script context is being concatenated onto.

 

We need to see ALL of the relevant code logic in order to be able to properly help you.

[DBookatay]

Try:

 

$list .= implode('; ', $row['email']);

 

I tried and get an error: Warning: implode() [function.implode]: Invalid arguments passed in /home/dbookatay/superscienceenrichment.com/Admin/mailinglist.php on line 25

[DBookatay]

All of the code:

$query = "SELECT * FROM mailinglist ORDER BY email";
$result = mysql_query($query); 
$numrows = mysql_num_rows($result); 
for($x = 0; $row = mysql_fetch_array($result); $x++) {
 $id = $row['id'];
 $email = $row['email'];
 $links .= '<li><a href="mailto:'.$email.'">'.$email.'</a> <span class="delete"><a href="?cat=05&delete='.$id.'" onclick="return confirm(\'Are you sure you want to delete?\n This action CAN NOT be undone\')"><a></span></li>';
 $emails = array($row['email']);
 $list .= implode('; ', $emails);
}

[Jessica]

You need to do the implode after you're done making the array you want to implode.

[AyKay47]

Something like this should work for you:

 

$emails = array(); //initialize
$query = "SELECT * FROM mailinglist ORDER BY email";
$result = mysql_query($query); 
$numrows = mysql_num_rows($result); 
while($row = mysql_fetch_array($result))
{
 $id = $row['id'];
 $email = $row['email'];
 $links .= '<li><a href="mailto:'.$email.'">'.$email.'</a> <span class="delete"><a href="?cat=05&delete='.$id.'" onclick="return confirm(\'Are you sure you want to delete?\n This action CAN NOT be undone\')"><a></span></li>';
 $emails[] = $row['email'];
}

$list = implode("; ", $emails);

 

Also, be sure to implement error checking logic into your code

[DBookatay]

Something like this should work for you:

 

$emails = array(); //initialize
$query = "SELECT * FROM mailinglist ORDER BY email";
$result = mysql_query($query);
$numrows = mysql_num_rows($result);
while($row = mysql_fetch_array($result))
{
$id = $row['id'];
$email = $row['email'];
$links .= '<li><a href="mailto:'.$email.'">'.$email.'</a> <span class="delete"><a href="?cat=05&delete='.$id.'" onclick="return confirm(\'Are you sure you want to delete?\n This action CAN NOT be undone\')"><a></span></li>';
$emails[] = $row['email'];
}

$list = implode("; ", $emails);

 

Also, be sure to implement error checking logic into your code

 

 

This did it! Thank you!