Need Help With Code

[jefffogel1974]

Keep in mind I am a PHP/MySQL noob, but my boss has tasked me with a project knowing I don't know coding to well.

 

Here are the details.

 

We currently have a building that has 20 some Cisco Wireless Access Points and all have an IP address assigned to them. I need to create a webpage that will pull the data I have from MySQL and display it in a nice HTML table layout. This is not the problem and I have completed this part thanks to a script I found online.

 

The problem I am running into is my boss would like the script to grab the IP address of each access point from the DB and ping it and if it is down he would like it to display the words OFFLINE next to that AP in the HTML table. If the AP is up he would like to have it display ONLINE in the table next to the AP.

 

If anyone can lend some assistance to a total noob I would greatly be in your debt. Thank you for everyone that assists!!!

 

 

[dalecosp]

system("/path/to/ping $ipaddress",$foo); if ($foo) {   echo "IP $address is offline!";}

UNIX-based, anyway.  Keep in mind that a system call that's successful returns zero

[AbraCadaver]

Assuming everything that you've shown is working independently, just add your ping.php code into the while loop in list.php and change the 8.8.8.8 to $row['IP_Address'].
 

[dalecosp]

Incidentally, I now notice you have similar code in your left editor of the screenshot.  What is the problem, exactly?

[jefffogel1974]

Thank you guys for the suggestions.

 

Dale the left editor is just another script I found that can ping an IP address but I can only get it to work if I statically assign the IP address, I actually want the script to loop through what is displayed from my right side editor and display Offline/Online status.

 

Abra, I really like your idea, but I am such a noob with PHP/MySql that I am unsure how to put the ping.php code into a while loop and was wondering if you could show me this?

 

Thanks again you guys for your help!!!

[AbraCadaver]

Thank you guys for the suggestions.

 

Dale the left editor is just another script I found that can ping an IP address but I can only get it to work if I statically assign the IP address, I actually want the script to loop through what is displayed from my right side editor and display Offline/Online status.

 

Abra, I really like your idea, but I am such a noob with PHP/MySql that I am unsure how to put the ping.php code into a while loop and was wondering if you could show me this?

 

Thanks again you guys for your help!!!

 

Just paste the ping code in the existing while loop and format the echo how you want inside a td /td or whatever.

[jefffogel1974]

I am either not pasting the correct code into the right area or it just doesn't work because now I get a blank page when I try and view the webpage. This is the whole code of what I did below.

<?php
$con=mysqli_connect("192.168.1.158","jfogel","Slave123","aps");
// Check connection
if (mysqli_connect_errno())
  {
  echo "Failed to connect to MySQL: " . mysqli_connect_error();
  }

$result = mysqli_query($con,"SELECT * FROM aps");

echo "<table border='1'>
<tr>
<th>ID</th>
<th>Site</th>
<th>AP Name</th>
<th>IP Address</th>
<th>MAC Address</th>
<th>AP Location</th>
<th>Status</th>
</tr>";

while($row = mysqli_fetch_array($result))

$str = exec("ping -n 1 -w 2000 $row['IP_Address']", $input, $result);
if ($result == 0){

{
  echo "<tr>";
  echo "<td>" . $row['ID'] . "</td>";
  echo "<td>" . $row['Site'] . "</td>";
  echo "<td>" . $row['AP_Name'] . "</td>";
  echo "<td>" . $row['IP_Address'] . "</td>";
  echo "<td>" . $row['MAC_Address'] . "</td>";
  echo "<td>" . $row['AP_Location'] . "</td>";
  echo "<td>" . $row['echo "Online";
}else{
echo "Offline";
}
'] . "</td>";


  echo "</tr>";
  }
echo "</table>";

mysqli_close($con);
?>

[Ch0cu3r]

Code for the while loop should be

while($row = mysqli_fetch_array($result))
{
  echo "<tr>";
  echo "<td>" . $row['ID'] . "</td>";
  echo "<td>" . $row['Site'] . "</td>";
  echo "<td>" . $row['AP_Name'] . "</td>";
  echo "<td>" . $row['IP_Address'] . "</td>";
  echo "<td>" . $row['MAC_Address'] . "</td>";
  echo "<td>" . $row['AP_Location'] . "</td>";
  echo "<td>";
  $str = exec("ping -n 1 -w 2000 {$row['IP_Address']}", $input, $result);
  if ($result == 0){
    echo "Online";
  }else{
    echo "Offline";
  }
  echo "</td>";

  echo "</tr>";
}

[Barand]

If that is your password above, I would change it immediately now you have published it

[jefffogel1974]

Already did after I realized my mistake, thank you!!

[jefffogel1974]

Why can I not edit my post to remove this?

[dalecosp]

Not sure; if I remember right, minimum post count, or it's a time-out and you could've if you'd done it quick enough ... but it appears that your posts are two minutes apart so I'm guess it's the post count...

[dalecosp]

Hum diddy ... (sorry, bit by another bug apparently ...)

Edited November 4, 2013 by dalecosp

[jefffogel1974]

Ch0cu3r that worked very good thank you, but it only displays 1 table row, how would I loop it through to ping each AP in the database?

[dalecosp]

That should display all of them.

Can you put something like:

$result = mysqli_query($con,"SELECT * FROM aps");	//doublecheck our result list size	echo "Got ".$result->num_rows." access points from DB.";	

[Ch0cu3r]

Ch0cu3r that worked very good thank you, but it only displays 1 table row, how would I loop it through to ping each AP in the database?

Not sure. I have only add ed your ping code to the while loop. Maybe the exec() is stopping the while loop from displaying the APs. If you remove the ping code

  $str = exec("ping -n 1 -w 2000 {$row['IP_Address']}", $input, $result);
  if ($result == 0){
    echo "Online";
  }else{
    echo "Offline";
  }

Does it now display all the APs?

[jefffogel1974]

Hi Dale, yes it displays the text "Got 219 access points from DB."

 

Ch0cu3r yes if I remove the ping command it does list all access points in a nice table format, so seems like something in the ping command is stopping it from displaying all AP's??

[dalecosp]

Argh!  We've got an issue here.  Dunno why I didn't see this before ... are you using "$result" for the DB resource, and "$result" for the result of the ping command as well?

Try changing the one in the ping command to "$pingresult" or something like that, and see if we have a better, um, "result" ...

Edited November 11, 2013 by dalecosp