Remaking & compressing images (works for jpeg, not png or gif)

[anderson_catchme]

function create_image($ext, $filepath, $newfilepath, $jpegquality){
switch ($ext){
case "jpg" OR "jpeg":
    $im = @imagecreatefromjpeg($filepath);
    if($im){
    imagejpeg($im, $newfilepath, $jpegquality);
}
break;
case "gif":
    $im = @imagecreatefromgif($filepath);
    if($im){
    imagegif($im, $newfilepath);
}
break;
case "png":
    $im = @imagecreatefrompng($filepath);
    if($im){
    imagepng($im, $newfilepath, 7);
}
break;
    }
if(!$im){
return FALSE;
    }
}

 

$ext is my file extention. The rest is pretty self explanitory. It's working for JPEG, but somehow not PNG or GIF. Not sure why, help appreciated. Thanks.

[requinix]

case "jpg" OR "jpeg":

Can't do that. It's like saying

if ($ext == ("jpg" OR "jpeg")) {

which means

if ($ext == true) {

which will always be the case for strings like "jpg" or "png".

 

Use multiple cases instead.

case "jpg":
case "jpeg":
    // ...

[anderson_catchme]

Thanks. Working great now.