Jump to content

Instantiating alot many classes (code review: am I doing it right?)


arbitrageur

Recommended Posts

	if(get_images_for_delete($username, $newid, $mysqli) !== FALSE){
	// WE are dealing with images
	$images = get_images_for_delete($username, $newid, $mysqli);
	$sourceBucket = "***********";
	$targetBucket = "***********";
	foreach($images as $image){
	// copy our object
	$aws = new s3;
	$aws = $aws->copyObject($targetBucket, $image, $sourceBucket, $image);
	// delete our object
	$aws_delete = new s3;
	$aws_delete = $aws_delete->deleteObject($image);
	// copy our (thumbnail) object
	$aws2 = new s3;
	$aws2 = $aws2->copyObject($targetBucket, "thumb_".$image, $sourceBucket, "thumb_".$image);
	// delete our (thumbnail) object
	$aws_delete2 = new s3;
	$aws_delete2 = $aws_delete2->deleteObject("thumb_".$image);
	}

Is my code. Do I need to declare so many new s3 classes? All the methods are within the same class. Not sure if this is the correct way to go about it.

Archived

This topic is now archived and is closed to further replies.

×
×
  • Create New...

Important Information

We have placed cookies on your device to help make this website better. You can adjust your cookie settings, otherwise we'll assume you're okay to continue.