arbitrageur Posted November 7, 2014 Share Posted November 7, 2014 if(get_images_for_delete($username, $newid, $mysqli) !== FALSE){ // WE are dealing with images $images = get_images_for_delete($username, $newid, $mysqli); $sourceBucket = "***********"; $targetBucket = "***********"; foreach($images as $image){ // copy our object $aws = new s3; $aws = $aws->copyObject($targetBucket, $image, $sourceBucket, $image); // delete our object $aws_delete = new s3; $aws_delete = $aws_delete->deleteObject($image); // copy our (thumbnail) object $aws2 = new s3; $aws2 = $aws2->copyObject($targetBucket, "thumb_".$image, $sourceBucket, "thumb_".$image); // delete our (thumbnail) object $aws_delete2 = new s3; $aws_delete2 = $aws_delete2->deleteObject("thumb_".$image); } Is my code. Do I need to declare so many new s3 classes? All the methods are within the same class. Not sure if this is the correct way to go about it. Quote Link to comment https://forums.phpfreaks.com/topic/292334-instantiating-alot-many-classes-code-review-am-i-doing-it-right/ Share on other sites More sharing options...
requinix Posted November 7, 2014 Share Posted November 7, 2014 Nope, don't need to. Quote Link to comment https://forums.phpfreaks.com/topic/292334-instantiating-alot-many-classes-code-review-am-i-doing-it-right/#findComment-1495993 Share on other sites More sharing options...
Recommended Posts
Join the conversation
You can post now and register later. If you have an account, sign in now to post with your account.