new mysql entry overwriting existing entry

[cloudll]

I am using php to upload a file to my server, and at the same time inserting the files name and url into my mysql database.

$sql = "UPDATE uploads SET name = '$name', url='$target_path'";
    $statement = $dbh->prepare($sql); 
    $statement->execute();

This is working, however, when I upload a new file, rather than making a new entry in my database, it just overwrites the first one.

I'm quite new at mysql so was wondering how I would make it add new entrys instead of overwriting the current one?

[NotionCommotion]

What are the columns in the uploads table?  Does it have a primary key?

 

Also, you are not doing your prepared statements correct!  You do not put the values in the query but add placeholders in the query (either ? or :name), and pass the values as an array to the execute method.  Yes, your query will work, but it is not escaping anything.

[cloudll]

the columns are id,name and url.

 

ah ok, i will look into prepared statements a little more and try and add an array. Id is the primary key, is that wrong?

[NotionCommotion]

You are updating every record in your table.  You need a WHERE clause that limits it to just the applicable PK.

[cloudll]

if i use a where clause, does that not need an existing entry? like 'where id = 1' ?

[cloudll]

Sorry, figured it out, it was me being extra stupid and and using update instead of insert cheers for your help i will work on the prepared statements some more.