checkboxes

[plutomed]

i hate writing javascript but is very useful

can anyone tell be what is wrong

 

<script type="text/javascript" language="javascript">
function check()
{
if(document.getElementById("check").checked=true)
{
	document.getElementById("showemail").value="0"
}
else if(document.getElementById("check").checked=false)
{
	document.getElementById("showemail").value="1"
}
}
</script>

[fenway]

Well, no need to keep getting the DOM element... but you probably mean to use the assignment operator (=), not the comparison operator (==).

[plutomed]

oh yes sorry i changed that after but it still doesnt work

[fenway]

Now you have them backwards for the actual .checked comparions.

[plutomed]

im sorry you've really confused me can you post the code it should be please

[ozfred]

i hate writing javascript but is very useful

can anyone tell be what is wrong

 

<script type="text/javascript" language="javascript">
function check()
{
if(document.getElementById("check").checked=true)

 

You are assigning the value true, rather than checking it (i.e. use "==" not "=").

 

It is simpler and less error-prone to write:

 

  if (document.getElementById("check").checked)

 

 

[davestewart]

If you want it really quick:

 

document.getElementById("showemail").value = ! document.getElementById("check").checked

 

or:

 

document.getElementById("showemail").value = document.getElementById("check").checked ? 0 : 1