mattal999 Posted March 4, 2007 Share Posted March 4, 2007 heres a link to my game. http://rpgnow.ifastnet.com. i pulled out because i didnt want to give source away. Give me comments on this please! thank you. Quote Link to comment https://forums.phpfreaks.com/topic/41115-critique-my-game/ Share on other sites More sharing options...
Orio Posted March 4, 2007 Share Posted March 4, 2007 heres a link to my game. http://rpgnow.ifastnet.com. i pulled out because i didnt want to give source away. Give me comments on this please! thank you. 1) I registered with an empty username, password and email... Some validation? 2) Too bad you can't buy anything. You start with 100 gold and everything costs 150+ gold, and I can't kill even a baby dragon without any offense. Can't see where else you can earn money. Orio. Quote Link to comment https://forums.phpfreaks.com/topic/41115-critique-my-game/#findComment-199058 Share on other sites More sharing options...
mattal999 Posted March 4, 2007 Author Share Posted March 4, 2007 now you should be able to kill a baby dragon. reregister and try again. Im not sure how to make it so u cant use empty email and stuff. Quote Link to comment https://forums.phpfreaks.com/topic/41115-critique-my-game/#findComment-199065 Share on other sites More sharing options...
redbullmarky Posted March 4, 2007 Share Posted March 4, 2007 i logged in without a username/password. just clicked the login button. Quote Link to comment https://forums.phpfreaks.com/topic/41115-critique-my-game/#findComment-199067 Share on other sites More sharing options...
Orio Posted March 4, 2007 Share Posted March 4, 2007 i logged in without a username/password. just clicked the login button. Yeah, thats my user I registered with empty stuff. @mattal- take a look at the empty() function. EDIT- and I still loose to that baby dragon lol Orio. Quote Link to comment https://forums.phpfreaks.com/topic/41115-critique-my-game/#findComment-199071 Share on other sites More sharing options...
mattal999 Posted March 4, 2007 Author Share Posted March 4, 2007 thats cuz orio has made an account with no username or password. i dont know how to do validation... Quote Link to comment https://forums.phpfreaks.com/topic/41115-critique-my-game/#findComment-199073 Share on other sites More sharing options...
mattal999 Posted March 4, 2007 Author Share Posted March 4, 2007 i dont know what empty() function is... Quote Link to comment https://forums.phpfreaks.com/topic/41115-critique-my-game/#findComment-199074 Share on other sites More sharing options...
Orio Posted March 4, 2007 Share Posted March 4, 2007 Did you know PHP has some documentation? Search! http://www.php.net/ Orio. Quote Link to comment https://forums.phpfreaks.com/topic/41115-critique-my-game/#findComment-199075 Share on other sites More sharing options...
mattal999 Posted March 4, 2007 Author Share Posted March 4, 2007 there u go. Fixed. Thanks Orio. What u think of it now? Quote Link to comment https://forums.phpfreaks.com/topic/41115-critique-my-game/#findComment-199079 Share on other sites More sharing options...
Orio Posted March 4, 2007 Share Posted March 4, 2007 I can earn unlimited amount of cash by killing millions of baby dragons. Maybe you should add a turn system (like in my game) or a maximum amount of monsters you can kill per hour. Orio. Quote Link to comment https://forums.phpfreaks.com/topic/41115-critique-my-game/#findComment-199086 Share on other sites More sharing options...
mattal999 Posted March 4, 2007 Author Share Posted March 4, 2007 ill check up on it... ill look at ur source code and see how its done... g2g bi btw: im only in secondary school in year 8 Quote Link to comment https://forums.phpfreaks.com/topic/41115-critique-my-game/#findComment-199088 Share on other sites More sharing options...
.josh Posted March 4, 2007 Share Posted March 4, 2007 you're in secondary school in year 8, don't know how to do basic stuff, and yet you pulled out of the contest because you didn't want to submit your source code? Then you turn around and post your stuff several days after the fact, asking for it to be 'judged.' Yeah right. I think I will move you to the list of people who used that as an excuse. p.s.- I'm splitting the thread at where you submitted a link to your game. This is the contest submission thread, not the mattal999's game critique thread. Quote Link to comment https://forums.phpfreaks.com/topic/41115-critique-my-game/#findComment-199146 Share on other sites More sharing options...
roopurt18 Posted March 4, 2007 Share Posted March 4, 2007 Your jedi mind tricks will not work on CV, you weak-minded fool! Quote Link to comment https://forums.phpfreaks.com/topic/41115-critique-my-game/#findComment-199318 Share on other sites More sharing options...
steelmanronald06 Posted March 4, 2007 Share Posted March 4, 2007 Try this: if ((!$username) || (!$password) || (!$email_address)) { echo 'You need to provide a username, password, and email address! Thank you!'; } Quote Link to comment https://forums.phpfreaks.com/topic/41115-critique-my-game/#findComment-199380 Share on other sites More sharing options...
Orio Posted March 5, 2007 Share Posted March 5, 2007 Try this: if ((!$username) || (!$password) || (!$email_address)) { echo 'You need to provide a username, password, and email address! Thank you!'; } Not the most beautiful way... I'd use empty() and isset() instead... Orio. Quote Link to comment https://forums.phpfreaks.com/topic/41115-critique-my-game/#findComment-199706 Share on other sites More sharing options...
Recommended Posts
Join the conversation
You can post now and register later. If you have an account, sign in now to post with your account.