why isn't this working

[desithugg]

function updateme($table,$field,$value,$where)
{
if($table == "") { $table = "rpg_users"; }
if($field == "") { $field = "promo"; }
if($value == "") { $value = "yes"; }
if($where == "") { $where = "id"; }
$query = mysql_query("update $table set $field = '$value' where $where = '$user_id'") or die(mysql_error()); 
}
updateme("rpg_users","promo","yes","id");

how come that doesn't work and the fallowing does

$query = mysql_query("update rpg_users set promo = 'yes' where id = '$user_id'") or die(mysql_error()); 

I'm not sure what the problem is the database connection is fine but it just doesn't seem to be working.

[shaunrigby]

Try removing your if statements for the purpose of debugging, so eg

 

if($table == "") { $table = "rpg_users"; }

would be:

$table = "rpg_users";

 

If this works, then your if statement is not working, ie $table is not equal to ""

[desithugg]

umm no luck

include("/home/pcaworld/public_html/config.php");
function updateme($table,$field,$value,$where)
{
$query = mysql_query("update $table set $field = '$value' where $where = '$user_id'") or die(mysql_error()); 
}
updateme("rpg_users","promo","no","id");

[wilorichie]

This is not likely, but there is a slight chance that $where is your problem. Try changing the variable name to $id or whatever you like.

 

I have not done the research to back this up, but its worth a try.

[kenrbnsn]

Do you get any errors? Have you put any debugging code into your function to see what is going on?

 

Try this and tell us the results:

<?php
function updateme($table,$field,$value,$where)
{
     if($table == "")
        $table = "rpg_users";
     if($field == "")
        $field = "promo";
     if($value == "")
        $value = "yes";
     if($where == "")
        $where = "id";
    $query = "update $table set $field = '$value' where $where = '$user_id'";
    echo 'In updateme, generated query = <pre>' . $query . '</pre>';  // debug statement
    $rs = mysql_query($query) or die("Problem with the query: <pre>$query</pre><br>" . mysql_error());
}
updateme("rpg_users","promo","yes","id");
?>

 

Ken

[desithugg]

<?php
function updateme2($table,$field,$value,$where)
{
     if($table == "")
        $table = "rpg_users";
     if($field == "")
        $field = "promo";
     if($value == "")
        $value = "yes";
     if($where == "")
        $where = "id";
    $query = "update $table set $field = '$value' where $where = '$user_id'";
    echo 'In updateme, generated query = <pre>' . $query . '</pre>';  // debug statement
    $rs = mysql_query($query) or die("Problem with the query: <pre>$query</pre><br>" . mysql_error());
}
updateme2("rpg_users","promo","aah","id");
?>

aah i got the problem thanx to you ken, you were right i didn't have any debugging/errors to tell me what was wrong but this is what the it echoed

 

In updateme, generated query =

 

update rpg_users set promo = 'aah' where id = ''

so the $user_id variable was empty for some reason im gonna check that out

 

which is quite strange because i did echo $user_id; right after and it worked

but i changed the code to

<?php
function updateme2($table,$field,$value,$where,$my_id)
{
     if($table == "")
        $table = "rpg_users";
     if($field == "")
        $field = "promo";
     if($value == "")
        $value = "yes";
     if($where == "")
        $where = "id";
    $query = "update $table set $field = '$value' where $where = '$my_id'";
    echo 'In updateme, generated query = <pre>' . $query . '</pre>';  // debug statement
    $rs = mysql_query($query) or die("Problem with the query: <pre>$query</pre><br>" . mysql_error());
}
updateme2("rpg_users","promo","aah","id",$user_id);
?>

So i had to input the id into the function too...no idea why