steviez Posted April 9, 2007 Share Posted April 9, 2007 Hi, I am wanting to sell my site in the near future and would like to get your opinions on what (if anything) you thing is wrong and needs chageing. The address is: http://tinyurl.com/2bhc37 Thanks in advance! Quote Link to comment https://forums.phpfreaks.com/topic/46330-please-review/ Share on other sites More sharing options...
redbullmarky Posted April 9, 2007 Share Posted April 9, 2007 first off the bat, it looks quite good but your top banner area is far too big, considering the logo is so small. you could shave off at least half the height which would bring the main part of the site more into view. also, for the lazy ones amongst us, make the logo a link to the homepage. I kinda expect it these days as to many others who are too lazy to motion the mouse towards the 'home' link otherwise, looks pretty good from first view. Quote Link to comment https://forums.phpfreaks.com/topic/46330-please-review/#findComment-225412 Share on other sites More sharing options...
steviez Posted April 9, 2007 Author Share Posted April 9, 2007 Thanks for that, im leaving the header as is at the moment due to me selling the site. I want to be able to give the next owner the option to have a new logo. I have made the logo in to a link now though, thanks Quote Link to comment https://forums.phpfreaks.com/topic/46330-please-review/#findComment-225415 Share on other sites More sharing options...
redbullmarky Posted April 9, 2007 Share Posted April 9, 2007 i get an error when trying to upload: Warning: main(************) [function.main]: failed to open stream: No such file or directory in **********************/upload.php on line 18 Fatal error: main() [function.require]: Failed opening required '***************' (include_path='.**********') in ******************upload.php on line 18 Quote Link to comment https://forums.phpfreaks.com/topic/46330-please-review/#findComment-225416 Share on other sites More sharing options...
redbullmarky Posted April 9, 2007 Share Posted April 9, 2007 you'll need to do plenty of work in terms of verifying what gets uploaded, and you could do much worse than lock down the directory where the uploaded files go so that files cannot be accessed directly. one of the biggest exploits with these type of sites is the uploading of a PHP script only to then run it from where it gets placed. a custom PHP script on someone elses server = bad news. Quote Link to comment https://forums.phpfreaks.com/topic/46330-please-review/#findComment-225429 Share on other sites More sharing options...
steviez Posted April 10, 2007 Author Share Posted April 10, 2007 i have now sorted the upload section (i think) please test some more Quote Link to comment https://forums.phpfreaks.com/topic/46330-please-review/#findComment-225520 Share on other sites More sharing options...
redbullmarky Posted April 10, 2007 Share Posted April 10, 2007 nope. whilst the directory is off limits, i still know the filename of the file I uploaded so can therefore run it if I call the file directly from the URL. On upload, you don't provide a direct link to to the file anyway, so I assume you're using some sort of script to pass the file back to the user? If so, then move the whole upload directory to OUTSIDE the web root. move_uploaded_file is good in the respect that it can move a file anywhere on the server, not just to somewhere inside your web root. this way the files cant be accessed directly. /httpdocs/ index.php /css/ stylesheet.css ... etc etc - all other site files here ... /uploads/ ... uploaded files here ... on other notes: 1, your page fires a javascript error when it loads (FF2 at least) 2, why such a long delay to download a file? 3, you need to sort out some of your HTML into valid code. Most of them are your use of closing tags on IMG/LINK - so use <img src="filename.gif" alt="example" /> instead of <img src="">. There are a few empty <tr></tr> in there too. Quote Link to comment https://forums.phpfreaks.com/topic/46330-please-review/#findComment-225638 Share on other sites More sharing options...
steviez Posted April 10, 2007 Author Share Posted April 10, 2007 Thanks for that, ill get on o it today and post up here again for review. Quote Link to comment https://forums.phpfreaks.com/topic/46330-please-review/#findComment-225768 Share on other sites More sharing options...
steviez Posted April 10, 2007 Author Share Posted April 10, 2007 Hi, I have now moved the uploads folder out of the root DIR, can you now test please Thanks Quote Link to comment https://forums.phpfreaks.com/topic/46330-please-review/#findComment-225836 Share on other sites More sharing options...
wildteen88 Posted April 10, 2007 Share Posted April 10, 2007 I tested your file upload. I upload an icon file (php.ico). Nothing special just an icon i use for my php files. Upload went fine. I noticed an area called description. I did not get an option to add a description. Is this a feature for registered users only? If its for registered user then perhaps display message saying "this is only available to registered users only" in red/bold text. Rather than just description. Went to download the file, reported size off the file is supposed to be 29.22KB however when I download it I only get 350bytes Then I tried a simple text file. About 2KB in size. Just had a few sentances in. Filled out the upload form. Submited. Uploaded and I get unexpected results (see attached screenshot). I tried twice and got the same result. The generated url for the file to be downloaded is this: http://www.ukfilehost.com/v/7624802/.html Are text files disallowed? If they are wouldn't it be better to display a warning message saying what file extensions are not allowed. [attachment deleted by admin] Quote Link to comment https://forums.phpfreaks.com/topic/46330-please-review/#findComment-225964 Share on other sites More sharing options...
steviez Posted April 10, 2007 Author Share Posted April 10, 2007 Hi, I was working on the site at the time of you uploading so that may be why you were reciving errors. The description field is for everyone, its on the main page under the file field. Please try upload again and tell me your outcomes. Thanks Quote Link to comment https://forums.phpfreaks.com/topic/46330-please-review/#findComment-225979 Share on other sites More sharing options...
wildteen88 Posted April 10, 2007 Share Posted April 10, 2007 Upload went fine. However still having problems with downloads. I Upload the screenshot that I attached in my last post when to download and only got 350bytes reported size on your site is 52.52 KBytes I can download fine at other places, such as imageshack. Quote Link to comment https://forums.phpfreaks.com/topic/46330-please-review/#findComment-226000 Share on other sites More sharing options...
steviez Posted April 10, 2007 Author Share Posted April 10, 2007 OK, is the file downloading fine (not currupt and opening fine?) if so then the code im using to get the file size is wrong. Thanks Quote Link to comment https://forums.phpfreaks.com/topic/46330-please-review/#findComment-226001 Share on other sites More sharing options...
steviez Posted April 11, 2007 Author Share Posted April 11, 2007 I have now sorted out a few of the problems you guys pointed out. Can you now please test (members area too) Thanks Quote Link to comment https://forums.phpfreaks.com/topic/46330-please-review/#findComment-226467 Share on other sites More sharing options...
wildteen88 Posted April 11, 2007 Share Posted April 11, 2007 Still same problems as before. I get a corrupted file Uploaded file: http://www.ukfilehost.com/v/4371943/php.ico.html The correct size for the file is around 29KB, your site confirms this on the download page. When I download the file I only get 350Bytes Quote Link to comment https://forums.phpfreaks.com/topic/46330-please-review/#findComment-226663 Share on other sites More sharing options...
wildteen88 Posted April 11, 2007 Share Posted April 11, 2007 Looks like you have a bug in your code for file download. Uploaded a text file that was 7bytes in size downloaded the file got a 326bytes back! Opened the file and got this: <br /> <b>Warning</b>: readfile(http://www.ukfilehost.com/home/steviez/YC9R5F01/ukfilehost_uploads/files/test.txt) [<a href='function.readfile'>function.readfile</a>]: failed to open stream: HTTP request failed! HTTP/1.1 404 Not Found in <b>/home/steviez/YC9R5F01/htdocs/ukfilehost/download.php</b> on line <b>37</b><br /> I get the same result when I open the icon file into notepad too. Quote Link to comment https://forums.phpfreaks.com/topic/46330-please-review/#findComment-226665 Share on other sites More sharing options...
steviez Posted April 11, 2007 Author Share Posted April 11, 2007 Hi, Thanks for the bug report, i have moved the download folder out of the root dir and forgot to update the links on the download.php files. Please could you try again for me ad report back. Thanks again! Quote Link to comment https://forums.phpfreaks.com/topic/46330-please-review/#findComment-227240 Share on other sites More sharing options...
steviez Posted April 18, 2007 Author Share Posted April 18, 2007 Hiy Please can you review my site, good and bad points please. http://tinyurl.com/2bhc37 Thanks Quote Link to comment https://forums.phpfreaks.com/topic/46330-please-review/#findComment-232641 Share on other sites More sharing options...
jcombs_31 Posted April 18, 2007 Share Posted April 18, 2007 didn't you post this already? Quote Link to comment https://forums.phpfreaks.com/topic/46330-please-review/#findComment-232700 Share on other sites More sharing options...
redbullmarky Posted April 18, 2007 Share Posted April 18, 2007 steviez, your other post regarding the same site was about 0.005mm down the page, not on a different planet (or page, even) that warranted a new topic - please do not double post... Topics merged. Your banner "area" is too big and pushes the content too far down the page on my 1024x768. That'd be ok if there wasn't so much whitespace in the banner area, but there is - that can be drastically shrunk to bring everything up into view abit. Cheers Quote Link to comment https://forums.phpfreaks.com/topic/46330-please-review/#findComment-232718 Share on other sites More sharing options...
steviez Posted April 20, 2007 Author Share Posted April 20, 2007 I have now made changes to the layout, pease can you review. Quote Link to comment https://forums.phpfreaks.com/topic/46330-please-review/#findComment-234353 Share on other sites More sharing options...
Recommended Posts
Join the conversation
You can post now and register later. If you have an account, sign in now to post with your account.