Md5 Encryption Problems

[Zebadee]

Hi guys,

I have done alot of login scripts in the past, but now i have decided to try a more secure way, using md5 encryption.

I have encrypted the password correctly in the database and now my function keeps returning false.

My login function is part of a class i made. $this->tablename, $this->accountname, $this->usersession and $this->dbconnection are perfectly fine as they have been working when i tried it without encryption.

Why isn't this working?

[code]

  function Login($pass)
  
  {
  
   $password = md5($pass);
  
         $query = "SELECT * FROM `$this->tablename` WHERE `Username` = '$this->accountname' AND `Password` = '$password' ";
           $result = mysql_query($query, $this->dbconnection);
                                                
                
                if (mysql_num_rows($result) > 0)
                     {
                    
                    
                     $this->usersession = $this->accountname;
                     session_register($this->usersession);
  
                          $query = "UPDATE `$this->tablename` SET `Online` = '1' WHERE `Username` = '$this->accountname' LIMIT 1";
                          mysql_query($query, $this->dbconnection);
                                                      
  
                     return true;
                     }
                         else
                         {
                          
                          return false;
                        
                         }
                    

  }

[/code]

[hitman6003]

Well, I don't see anything in your code that would cause a problem, so I would say to echo out your query to verify that it's correct, and also echo out the password that you have in the db and the md5'd password that is being passed into the function to compare them visually.

[keeB]

[code]$query = "SELECT * FROM `$this->tablename` WHERE `Username` = '$this->accountname' AND `Password` = '$password' ";[/code]

[b]$this->tablename[/b] and [b]$this->accountname[/b] are probably where the problem lies..