marmite Posted May 11, 2007 Share Posted May 11, 2007 Very grateful for any feedback on this site. Two months ago I hadn't ever coded... so I'm sure there's room for improvement! I'm still working on several parts of it... Thanks Emma Quote Link to comment https://forums.phpfreaks.com/topic/50930-wwwcardsunlimitedcom-feedback-wanted/ Share on other sites More sharing options...
marmite Posted May 11, 2007 Author Share Posted May 11, 2007 Oh, yes, the URL is www.cardsunlimited.com Quote Link to comment https://forums.phpfreaks.com/topic/50930-wwwcardsunlimitedcom-feedback-wanted/#findComment-250504 Share on other sites More sharing options...
rorag Posted May 11, 2007 Share Posted May 11, 2007 sweet but you could add a random image selection on the main home page so it randomly changes Quote Link to comment https://forums.phpfreaks.com/topic/50930-wwwcardsunlimitedcom-feedback-wanted/#findComment-250714 Share on other sites More sharing options...
twilightnights Posted May 12, 2007 Share Posted May 12, 2007 Looks nice, when you get more cards you might want to add a search feature outside each category though. Quote Link to comment https://forums.phpfreaks.com/topic/50930-wwwcardsunlimitedcom-feedback-wanted/#findComment-251157 Share on other sites More sharing options...
marmite Posted May 13, 2007 Author Share Posted May 13, 2007 Thanks both... yes, the homepage image rotation needs attention but I confess I don't know anything about javascript so it was a struggle just getting to that bit. I see istockphoto.com has a random selector and might have a look at how they did it. What do you mean, "search feature outside of each category" ? Do you mean it would be better to be able to search on both dropdowns at once? Thanks for your feedback Quote Link to comment https://forums.phpfreaks.com/topic/50930-wwwcardsunlimitedcom-feedback-wanted/#findComment-251961 Share on other sites More sharing options...
bbaker Posted May 14, 2007 Share Posted May 14, 2007 The site looks great. FYI....you can do the image rotation with PHP. <?php $img_array = array('add','arrow','book','cancel','contact'); $random_img = $img_array[rand(0, count($img_array) - 1)]; echo '<img src="images/'.$random_img.'.gif" class="noBorder" alt="Random Image"/>'; ?> per the above code, you'd have to have images named "image1.jpg", "image2.jpg", "image3.jpg", "image4.jpg", "image5.jpg" in your "images" directory. You can add more or remove some, just make sure that the list in array matches the images that you have in your "images" directory Quote Link to comment https://forums.phpfreaks.com/topic/50930-wwwcardsunlimitedcom-feedback-wanted/#findComment-252781 Share on other sites More sharing options...
marmite Posted May 14, 2007 Author Share Posted May 14, 2007 oh my goodness! That is SO much easier than the javascript nightmare I went through. Thanks! I'll try that. Emma Quote Link to comment https://forums.phpfreaks.com/topic/50930-wwwcardsunlimitedcom-feedback-wanted/#findComment-252928 Share on other sites More sharing options...
corbin Posted May 14, 2007 Share Posted May 14, 2007 You could even make it more dynamic so it read the files in the directory and chose a random one.... This could get resource intensive causing delays, but you could catalog the files or surely theres some way to just count files in a folder, thus allowing you to select a random number < the amount of pictures. Quote Link to comment https://forums.phpfreaks.com/topic/50930-wwwcardsunlimitedcom-feedback-wanted/#findComment-253071 Share on other sites More sharing options...
bbaker Posted May 15, 2007 Share Posted May 15, 2007 In the code I put above, I used .gif in the code, but told you to use .jpg in the explanation. Just change the one line to the red below. echo '<img src="images/'.$random_img.'.jpg" class="noBorder" alt="Random Image"/>'; corbin's suggestion would be ideal, since you'd be able to just add a new image or remove an image whenever you wanted without having to change the array values. I went for the simpler (coding wise) approach, because I'm lazy. Quote Link to comment https://forums.phpfreaks.com/topic/50930-wwwcardsunlimitedcom-feedback-wanted/#findComment-253630 Share on other sites More sharing options...
tippy_102 Posted May 20, 2007 Share Posted May 20, 2007 The site looks really nice, but the rounder corners are stretched too far in the footer. Make sure you validate: http://validator.w3.org/check?uri=http%3A%2F%2Fwww.cardsunlimited.com%2Findex.php Quote Link to comment https://forums.phpfreaks.com/topic/50930-wwwcardsunlimitedcom-feedback-wanted/#findComment-257292 Share on other sites More sharing options...
Recommended Posts
Join the conversation
You can post now and register later. If you have an account, sign in now to post with your account.