whats wrong with this php / sql command:

[rickyj]

this is the shothand sqlquerry(after connecting to the database an table):

 

$result= mysql_query("INSERT INTO sigparsed (a, b, c, d, e )  VALUES ('2', $var1, '1', $var2, '0' ) ") or die(mysql_error());

and my error:

You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '

 

But I see nothing wrong with my syntext

[plutomed]

$var1 and $var2 need to be between the ' '

[mrjcfreak]

You also might need to use the addslashes function on var1 and 2.

 

And, if possible, it's wise to use the mysqli functions for forward compatability.

[Barand]

Depends on what $var1 and $var2 contain.

 

try

<?php

$sql = "INSERT INTO sigparsed (a, b, c, d, e )  VALUES ('2', $var1, '1', $var2, '0' ) ";

$result = mysql_query($sql) or die (mysql_error()."<pre>$sql</pre>");

 

and see what is actually being sent.

 

 

@plutomed - only mandatory if the vars are non-numeric

[Zane]

put your query in a separate variable to make sure you variables are going through correctly....and also echo the query out just to make sure

$query = 'INSERT INTO sigparsed (a, b, c, d, e )  VALUES ("2", $var1, "1", $var2, "0")';
$result= mysql_query($query) or die("Error with your SQL query: " . $query . "\n
Error: " . mysql_error());

[Barand]

great idea, zanus

[rickyj]

hmm now Im getting :

 

abDuplicate entry '119' for key 1

 

what does this mean, my querry is now:

print 'a';

$Querry = "INSERT INTO sigparsed (a, b, c, d, e )  VALUES ('2', '$var1', '1', '$var2', '0' ) ";

$result= mysql_query($Querry) or die(mysql_error());

print 'b';

 

$Querry2 = "INSERT INTO usertextfield (f, g)  VALUES ('$var3', '$var4') ";

$result2= mysql_query($Querry2) or die(mysql_error());

print 'c';

[rickyj]

opps i should be replacing not inserting, hmm

[Barand]

Sounds like you attempted to add an already existing value into a column defined as unique

[rickyj]

yes, I shouldnt be using insert, But I have made some progress thanks to you guys, cheers

[rickyj]

hmm,

 

"INSERT INTO sigparsed (a, b, c, d)  VALUES ('2', '1', '$var1', '0' )WHERE userid = '$UserID' "

 

hmm getting there, but I cant use the where statment like this can I?  how can I do the above?

[AndyB]

I suspect you want an UPDATE query, not INSERT

 

UPDATE tablename SET fields/values WHERE somefield = somevalue

 

http://www.tizag.com/mysqlTutorial/mysqlupdate.php

[rickyj]

yup, you where exactly right Thanks

[dbo]

You also might need to use the addslashes function on var1 and 2.

 

And, if possible, it's wise to use the mysqli functions for forward compatability.

 

Some hosts don't use both mysql and mysqli functions and just the older mysql functions. I agree with what you're saying... but what I don't understand is why people don't "wrapper" their database functions inside of a class so that it doesn't really matter if you use mysql or mysqli... you start out using mysql and then when the standard changes you change the class to mysqli and all your code works again... rather than having to hunt through code and change 1000 instances of mysql.... doing it my way you can even potentially change the underlying database... mysql->postgres...sql server... oracle, whatever.

[mrjcfreak]

but what I don't understand is why people don't "wrapper" their database functions inside of a class so that it doesn't really matter if you use mysql or mysqli...

 

Because people are lazy. Me included.

[dbo]

By "being lazy" you're in essence creating more work for yourself!

[Barand]

And if I now write a wrapper class I have to go back and change 1000 instances of mysql...