Simple View Count Help

[itsureboy]

I have a simple counter that updates a row by 1 each time the page is loaded.

However, when its on zero and its first executed it adds one then every other time after that for some reason adds 4 and sometimes something different. I just want it to update by 1 each time its reloaded.

 

Here is the code:

<?php
include 'dbconnect.php';
$id = $id;
$query = "SELECT views FROM table WHERE id = '$id' LIMIT 1";
$result = mysql_query($query);

while($row = mysql_fetch_row($result))
{
$views = $row[0];

$newviews = 0;
}
mysql_query("UPDATE table SET views='$newviews' WHERE id = '$id'")
?>

Thanks.....

[Jessica]

<?php
include 'dbconnect.php';
$id = $id; //what? This is repeatedly redundant...
mysql_query("UPDATE table SET views=views+1 WHERE id = '$id'");
?>

[itsureboy]

lol....

Was just removing some code for the example and somehow that stayed there.

[Psycho]

What you said and the code you posted are at odds with each other. No where in your code do I see the count being increased by 1. All that I would expect to happen is that the views value should get reset to 0 every time that script is run.

 

Also, you havea LIMIT 1 on your query and then use a while loop to get the records. Why?

[itsureboy]

Wow sorry totally wrong code....

 

here it is:

<?php
include 'dbconnect.php';

mysql_query("SELECT views FROM table WHERE id = '$id'");

$newviews = $views + 1;

mysql_query("UPDATE table SET views='$newviews' WHERE id = '$id'")
?>

[Jessica]

Wow sorry totally wrong code....

 

here it is:

<?php
include 'dbconnect.php';

mysql_query("SELECT views FROM table WHERE id = '$id'");

$newviews = $views + 1;

mysql_query("UPDATE table SET views='$newviews' WHERE id = '$id'")
?>

 

In that code you never get $views from the query. You're setting it to 1 each time.

 

Use the code I posted, it will work. If it doesn't, we can go from there.

[itsureboy]

I tried the code you posted it did the same thing. From 0 added 1 then when reloaded added 4(5) then 4 again (9) and so forth i dont no why.

[Jessica]

Is that the ENTIRE code of the page? Create just a page with the connection to the DB and the code, and see it then.

There must be some other code, or the file is being called 4 times each time or something.

[vijayfreaks]

Hi..

        use the following code..

 
<?php
include 'dbconnect.php';

$res=mysql_query("SELECT views FROM table WHERE id = '$id'");
$views=mysql_result($res,0);
$newviews = $views + 1;
mysql_query("UPDATE table SET views='$newviews' WHERE id = '$id'");
$af_row=mysql_affected_rows() ;
if($af_row >= 1)
{
echo "$af_row rows affected";
}
?>

 

Regards,

Vijay

[Jessica]

There is no need to make a select and then an update - if you do this on every page, you are taxing your database more than you need to.

[itsureboy]

I think its adding more than 1 views because i have anothor query. Is this the reason? How can i avoid it adding more than 1 without having to remove other query?