marksie1988 Posted December 28, 2007 Share Posted December 28, 2007 well i have been working on this site for a while still not all working yet though, you can see what is still to be done in the dev section all constructive criticism welcomed http://www.blconline.co.uk EDIT: a test account with the username: demo123 and password: demo123 has been setup for you to test thanks Steve Quote Link to comment Share on other sites More sharing options...
chantown Posted December 28, 2007 Share Posted December 28, 2007 you coded all this? it's nice. but the dark with yellow lights design makes me feel unsecure Quote Link to comment Share on other sites More sharing options...
marksie1988 Posted December 28, 2007 Author Share Posted December 28, 2007 i coded most of it with help from here, this is the most i have ever done on a website was a very large learning curve but i wanted to understand php Quote Link to comment Share on other sites More sharing options...
jos. Posted December 28, 2007 Share Posted December 28, 2007 Failed validation, 116 Errors Its rather dark for a professional site. That is something that I too struggle with... What are your potential customers hoping to see in your web site? I think most non-IT people would be scared or intimidated by neon-green and black... Jos. Quote Link to comment Share on other sites More sharing options...
rajivgonsalves Posted December 28, 2007 Share Posted December 28, 2007 the background is tooooo dark and the foreground color too bright.. its was hurting too my eyes a bit on my monitor... maybe you can do some less of a contrast with the colors Quote Link to comment Share on other sites More sharing options...
deadimp Posted December 29, 2007 Share Posted December 29, 2007 Looks pretty good, just the color scheme is the main thing that jumps out, like the others have said. Also, it looks like you coded some of your JavaScript for IE. You're using document.all for you little ticker, and FF doesn't support that. Quote Link to comment Share on other sites More sharing options...
Daniel0 Posted December 29, 2007 Share Posted December 29, 2007 Your browser is not compatible with this website, you may see things on this website incorrectly unless you upgrade to firefox! Is a no-no. You need to make it work for all the major browsers. Besides, I'm already using Firefox: Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9b2) Gecko/2007121120 Firefox/3.0b2 IMO it's too dark. Also, when I see a menu like yours I expect to be able to click anywhere on the "button" seeing as there are stripes going to the right, yet I have to move to the text itself to click it. Quote Link to comment Share on other sites More sharing options...
marksie1988 Posted December 30, 2007 Author Share Posted December 30, 2007 Thanks for all the input i am now looking into selective themes so that the theme can be changed to what you prefer to stop anoyances and i will make sure that this works correctly when i have chance to code it Your browser is not compatible with this website, you may see things on this website incorrectly unless you upgrade to firefox! Is a no-no. You need to make it work for all the major browsers. Besides, I'm already using Firefox: Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9b2) Gecko/2007121120 Firefox/3.0b2 IMO it's too dark. Also, when I see a menu like yours I expect to be able to click anywhere on the "button" seeing as there are stripes going to the right, yet I have to move to the text itself to click it. and i agree that it should work with all browsers and it should do the only reason that it thinks yours isnt firefox is because its the new version which isnt yet in my script as its only a beta, also when using IE it says it isnt compatible but it is, i just havent got around to changing that yet as for the menu i will look at a way to make the whole button clickable instead of just the text Quote Link to comment Share on other sites More sharing options...
Daniel0 Posted December 30, 2007 Share Posted December 30, 2007 To check if it's Firefox you can just do if(stripos($_SERVER['HTTP_USER_AGENT'], 'firefox') === false) // it's important to use the identical operator { echo 'you are not using firefox'; } No need to match the entire user agent string. Quote Link to comment Share on other sites More sharing options...
marksie1988 Posted December 31, 2007 Author Share Posted December 31, 2007 To check if it's Firefox you can just do if(stripos($_SERVER['HTTP_USER_AGENT'], 'firefox') === false) // it's important to use the identical operator { echo 'you are not using firefox'; } No need to match the entire user agent string. oo thankyou i was going to see if i could do that instead Quote Link to comment Share on other sites More sharing options...
kathas Posted December 31, 2007 Share Posted December 31, 2007 There are security issues: XSS: http://www.blconline.co.uk/whois/index.blc?domain=%22%3E%3Cscript%3Ealert%286%29%3C%2Fscript%3E&lookup=%3E%3E i didn't search for more... submit a post in the beta test section if you want your site checked more thourouhly Quote Link to comment Share on other sites More sharing options...
marksie1988 Posted January 3, 2008 Author Share Posted January 3, 2008 ok i have done found quite a few things wrong but no one has been helping me to stop the xss issue dont suppose anyone knows? Quote Link to comment Share on other sites More sharing options...
Daniel0 Posted January 3, 2008 Share Posted January 3, 2008 ok i have done found quite a few things wrong but no one has been helping me to stop the xss issue dont suppose anyone knows? Run user submitted data through htmlentities() before outputting. Quote Link to comment Share on other sites More sharing options...
Lukela Posted January 4, 2008 Share Posted January 4, 2008 lolx, ok just my first thought when I went to the site. "Am I gonna get hacked?" lolx Quote Link to comment Share on other sites More sharing options...
marksie1988 Posted January 5, 2008 Author Share Posted January 5, 2008 lolx, ok just my first thought when I went to the site. "Am I gonna get hacked?" lolx why did you think this ? Quote Link to comment Share on other sites More sharing options...
tibberous Posted January 6, 2008 Share Posted January 6, 2008 lolx, ok just my first thought when I went to the site. "Am I gonna get hacked?" lolx why did you think this ? Does bare a striking resemblance to the old cracks.am... Quote Link to comment Share on other sites More sharing options...
Recommended Posts
Join the conversation
You can post now and register later. If you have an account, sign in now to post with your account.