[SOLVED] Simple Join Query - Issues

[iceblox]

Hi Guys,

 

I have this query

 

$query = "SELECT models.manname, models.modname, models.modid, code.modelid, code.modid, models.manid 
FROM models
INNER JOIN code
ON models.modid = code.modid WHERE code.modelid = $ModelID AND code.modelid IS NOT NULL GROUP BY models.modname";

 

My issue is that when $ModelID is not specified in the url how can i stop it from showing this error.. I have a num rows but im not sure how to solve it? Any help would be appreciated.

 

Warning: mysql_num_rows(): supplied argument is not a valid MySQL result resource in /usr/local/psa/home/vhosts

 

 

[hitman6003]

Your query fails when $ModelID is empty, so you need to format your query to take that into account:

 

$query = "SELECT models.manname, models.modname, models.modid, code.modelid, code.modid, models.manid "
   . "FROM models "
   . "    INNER JOIN code ON models.modid = code.modid "
   . "WHERE " . ($ModelID != "" ? 'code.modelid = ' . $ModelID . ' AND' : '') . " code.modelid IS NOT NULL "
   . "GROUP BY models.modname";

[iceblox]

Thanks for your input hitman, however i dont think i explained my self well enough. What id like to happen is that when there is no "$ModelID" then that query is not used at all..

 

Any ideas?

 

Cheers, Phil

[amites]

put it inside an if statement?