Jump to content

Recommended Posts

Is there anything wrong?

 

HTML 137 errors

http://validator.w3.org/check?verbose=1&uri=http%3A%2F%2Fwww.mdoneonone.com%2F

 

CSS 66 errors http://jigsaw.w3.org/css-validator/validator?profile=css21&warning=0&uri=http%3A%2F%2Fwww.mdoneonone.com%2F

 

The images shown in the tour need some proper compression - they're all much larger file sizes than need be.

 

The TNR font isn't too nice, either.

Link to comment
https://forums.phpfreaks.com/topic/88112-my-website-is-it-good/#findComment-450838
Share on other sites

Array:

http://www.mdoneonone.com/rrg/index.php?task=view&id[]

 

Array:

http://www.mdoneonone.com/rrg/index.php?task=profile&p=2&id[]

 

Cross Site Scripting:

http://www.mdoneonone.com/rrg/index.php?task=profile&p=2&id="><marquee><h1>vulnerable</marquee>

 

Cross Site Scripting:

There is Cross Site Scripting on http://www.mdoneonone.com/rrg/index.php?task=search if a search contains code.

 

Cross Site Scripting:

There is Cross Site Scripting if your username contains code.

 

Cross Site Scripting:

http://www.mdoneonone.com/rrg/index.php?task=view&id="><marquee><h1>vulnerable</marquee>

 

Full Path Disclosure:

http://www.mdoneonone.com/includes/

Fatal error: Call to undefined function: title() in /home/content/m/d/o/mdoneonOne/html/includes/index.php on line 6

 

Full Path Disclosure:

http://www.mdoneonone.com/rrg/index.php?task=view

Warning: mysql_fetch_array(): supplied argument is not a valid MySQL result resource in /home/content/m/d/o/mdoneonOne/html/rrg/content/media.php on line 24

 

Full Path Disclosure:

http://www.mdoneonone.com/rrg/index.php?cat_id=3&page

Warning: mysql_fetch_array(): supplied argument is not a valid MySQL result resource in /home/content/m/d/o/mdoneonOne/html/rrg/content/content.php on line 106

 

Full Path Disclosure:

http://www.mdoneonone.com/rrg/content/media.php

Warning: main(config.php): failed to open stream: No such file or directory in /home/content/m/d/o/mdoneonOne/html/rrg/content/media.php on line 11

 

Warning: main(config.php): failed to open stream: No such file or directory in /home/content/m/d/o/mdoneonOne/html/rrg/content/media.php on line 11

 

Warning: main(): Failed opening 'config.php' for inclusion (include_path='.:/usr/local/lib/php') in /home/content/m/d/o/mdoneonOne/html/rrg/content/media.php on line 11

 

Warning: mysql_connect(): Can't connect to local MySQL server through socket '/usr/local/mysql-5.0/data/mysql.sock' (2) in /home/content/m/d/o/mdoneonOne/html/rrg/content/media.php on line 12

Could not connect: Can't connect to local MySQL server through socket '/usr/local/mysql-5.0/data/mysql.sock' (2)

 

Insecure Cookie:

You shouldn't put the password in the cookie.

 

Insecure Cookie:

You shouldn't put the username in the cookie.

 

You can log in as any user by changing the ava_username cookie and the ava_code cookie to their username and password.

Link to comment
https://forums.phpfreaks.com/topic/88112-my-website-is-it-good/#findComment-450863
Share on other sites

You can prevent XSS, and other security holes if use mysql_real_escape_string for sql injection, or strip_tags for XSS. Those are 2 in a thousand ways of doing it, how you want to do it is your choice. There are tutorials, just search up PHP sql injection for prevention tips.

 

Nice website, and good luck.

Link to comment
https://forums.phpfreaks.com/topic/88112-my-website-is-it-good/#findComment-451021
Share on other sites

Looks good, but may I suggest:

 

(1) There is not enough contrast between background colors and some of the text on the home page.

 

(2) The images in the gallery should be consistently the same hight x width & without distortion.

 

(3) There is too much text information at the opening of the home page. It should be clear to a guest what the website is about within 2 seconds of the load. You may wish to emphasize a single headline or a headline with a subheadline.

 

(4) The text is too small in portions of the website.

 

...That is my humble non-tech opinion. Otherwise it looks great! Tom

Link to comment
https://forums.phpfreaks.com/topic/88112-my-website-is-it-good/#findComment-455561
Share on other sites

You can prevent XSS, and other security holes if use mysql_real_escape_string for sql injection, or strip_tags for XSS. Those are 2 in a thousand ways of doing it, how you want to do it is your choice. There are tutorials, just search up PHP sql injection for prevention tips.

 

Nice website, and good luck.

 

This is almost true.

 

mysql_real_escape_string can mitigate SQL Injection attempts. There are a lot of XSS Filters about that one can impliment in their own codebase - or make use of a framework with a built-in XSS filter (KohanaPHP)

Link to comment
https://forums.phpfreaks.com/topic/88112-my-website-is-it-good/#findComment-458170
Share on other sites

×
×
  • Create New...

Important Information

We have placed cookies on your device to help make this website better. You can adjust your cookie settings, otherwise we'll assume you're okay to continue.