Jump to content


Photo

Can You Give Me Criticism Please?


  • This topic is locked This topic is locked
9 replies to this topic

#1 Love2c0de

Love2c0de

    Advanced Member

  • Members
  • PipPipPip
  • 365 posts
  • LocationThe Pleiades
  • Age:23

Posted 07 December 2012 - 05:54 AM

Hi,

I am wondering if you could possibly give me some criticism on my site. I am using backend php files to run the site so I am quite happy with my setup. It's more to do with the actual designing of the site rather than the functionality (I will be adding some javascript effects within the next few days).

I have set all my elements, margins/padding to % and I had someone take a look on a larger resolution and it looked 'reasonably' ok but still needs to be changed. I spent a few hours last night creating a totally separate copy of my CSS file and setting everything with pixels and it looks the same as it did when I set it with %.

I just need some criticism on the actual design because I'm not impressed myself. It looks too amateur to me.

Here is the link: http://www.labtec.0fees.net/

Thank you for any help you can give me.

Regards,

AotB.

Edited by AoTBuNgLe, 07 December 2012 - 05:55 AM.


#2 Love2c0de

Love2c0de

    Advanced Member

  • Members
  • PipPipPip
  • 365 posts
  • LocationThe Pleiades
  • Age:23

Posted 07 December 2012 - 06:26 AM

Please note, I forgot to sort the font. I was using one local to my machine. Dont worry about that it's more layout I'm looking for.

#3 Beeeeney

Beeeeney

    Advanced Member

  • Members
  • PipPipPip
  • 194 posts
  • LocationEngland!
  • Age:20

Posted 07 December 2012 - 06:41 AM

Beautiful.

Posted Image

#4 Beeeeney

Beeeeney

    Advanced Member

  • Members
  • PipPipPip
  • 194 posts
  • LocationEngland!
  • Age:20

Posted 07 December 2012 - 06:45 AM

hey d00d is this ur code

<br />
<b>Warning</b>:  mysqli::mysqli() [<a href='mysqli.mysqli'>mysqli.mysqli</a>]: (28000/1045): Access denied for user 'root'@'localhost' (using password: NO) in <b>/home/vol3/0fees.net/fees0_11240271/htdocs/GardenableImproved/core/get_specific_product.php</b> on line <b>3</b><br />
<iframe src='http://ifastnet.com/pop.html' name='frame1' scrolling='no' frameborder='no' align='center' MARGINWIDTH='0' MARGINHEIGHT='0' height = '10px' width = '10px'>  </iframe><br />
<b>Warning</b>:  mysqli::prepare() [<a href='mysqli.prepare'>mysqli.prepare</a>]: Couldn't fetch mysqli in <b>/home/vol3/0fees.net/fees0_11240271/htdocs/GardenableImproved/core/get_specific_product.php</b> on line <b>5</b><br />
<iframe src='http://ifastnet.com/pop.html' name='frame1' scrolling='no' frameborder='no' align='center' MARGINWIDTH='0' MARGINHEIGHT='0' height = '10px' width = '10px'>  </iframe><br />
<b>Warning</b>:  mysqli_error() expects exactly 1 parameter, 0 given in <b>/home/vol3/0fees.net/fees0_11240271/htdocs/GardenableImproved/core/get_specific_product.php</b> on line <b>5</b><br />
<iframe src='http://ifastnet.com/pop.html' name='frame1' scrolling='no' frameborder='no' align='center' MARGINWIDTH='0' MARGINHEIGHT='0' height = '10px' width = '10px'>  </iframe>Error:

I have all of your source files. :D

But seriously I do.

#5 Christian F.

Christian F.

    Advanced Member

  • Staff Alumni
  • 3,106 posts
  • LocationNorway

Posted 07 December 2012 - 06:49 AM

A prime example why one should always:
  • Handle all possible error situations, with custom error handlers.
  • Turn off public error reporting on production.
;)

Edited by Christian F., 07 December 2012 - 06:50 AM.

Keeping it simple.

#6 Love2c0de

Love2c0de

    Advanced Member

  • Members
  • PipPipPip
  • 365 posts
  • LocationThe Pleiades
  • Age:23

Posted 07 December 2012 - 06:57 AM

lol it all went tits up. I'll turn error reporting off for now. Probably create a new hosting account as well now that you have all my details :o

What a muppet. I only took it down to sort the font, which I've now changed to trebuchet ms for now.

Edited by AoTBuNgLe, 07 December 2012 - 07:00 AM.


#7 PFMaBiSmAd

PFMaBiSmAd

    Advanced Member

  • Staff Alumni
  • 16,767 posts
  • LocationColorado, U.S.A.

Posted 07 December 2012 - 07:01 AM

You should have display_errors OFF, log_errors ON, and error_reporting set to E_ALL so that any php detected errors will be logged in the environment where the script is running so that you can find and fix any problems occurring in that environment.
Signature: (not a comment about anything you posted unless specifically indicated)
Debugging step #1: To get past the garbage-out equals garbage-in stage in your code, you must check that the inputs to your code are what you expect.

Programming is just problem solving, but it is done in another language. You must learn enough of the programming language you are using to be able to read and write code.

#8 Love2c0de

Love2c0de

    Advanced Member

  • Members
  • PipPipPip
  • 365 posts
  • LocationThe Pleiades
  • Age:23

Posted 07 December 2012 - 07:13 AM

Thank you both for the tips.

I've just changed the display errors to off, and now it is only reporting 'Error:' (which is my string which I put before the mysqli_error()) so that is ok for now. I'll look into the other two mentioned though.

Regards,

AoTB.

#9 PFMaBiSmAd

PFMaBiSmAd

    Advanced Member

  • Staff Alumni
  • 16,767 posts
  • LocationColorado, U.S.A.

Posted 07 December 2012 - 07:22 AM

mysqli_error() expects exactly 1 parameter, 0 given


^^^ Your mysqli_error() statement isn't coded correctly. It requires the mysqli link as a parameter.
Signature: (not a comment about anything you posted unless specifically indicated)
Debugging step #1: To get past the garbage-out equals garbage-in stage in your code, you must check that the inputs to your code are what you expect.

Programming is just problem solving, but it is done in another language. You must learn enough of the programming language you are using to be able to read and write code.

#10 Love2c0de

Love2c0de

    Advanced Member

  • Members
  • PipPipPip
  • 365 posts
  • LocationThe Pleiades
  • Age:23

Posted 07 December 2012 - 07:25 AM

Ah I remember that coming up on localhost when I purposely put in a mistake in the code. I forgot to change it though.

Cheers for that! I completely forgot.

I'm getting quite confused here, I might take it down, carry on in localhost until I have got rid of these problems.

Kind regards,

AotB

Edited by AoTBuNgLe, 07 December 2012 - 07:31 AM.





0 user(s) are reading this topic

0 members, 0 guests, 0 anonymous users

Cheap Linux VPS from $5
SSD Storage, 30 day Guarantee
1 TB of BW, 100% Network Uptime

AlphaBit.com