[SOLVED] newbie question

[jtown]

I'm a newbie and have a question.

why do I get the error "Warning: rename($old,$new) [function.rename]:"  It says there is no such directory

I can put variable into the rename function right?

$old and $new are variable using $_POST to get the info from a text field.

Hope this makes sense

 

Thanks

J

[Fadion]

The error says it all, there is no such directory. Make sure u have correct directory names for both $old and $new. For us to help u better, post more code.

[jtown]

here is my code

The directory name are coming from my form fields right?

Thanks

<?

$old = $_POST['oldname'];

$new = $_POST['newname'];

rename('$old', '$new');

$dir = opendir("images");

while ($file = readdir($dir))

{

echo "current filename:  $file\n";

?>

<form action="<? echo($PHP_SELF)?>" >

<input type="hidden" name="oldname" />

<input type="text" name="newname" size="30"/><br />

<input type="button" value="change file name"/><br /><br />

</form>

<?

}

 

closedir($dir);

 

?>

[DarkWater]

Don't use single quotes around variables, otherwise they will NOT be parsed.

 

[BlueSkyIS]

righto. this won't work:

 

rename('$old', '$new');

 

should be

 

rename($old, $new);

// OR

rename("$old", "$new");

 

 

[Fadion]

Echoing variables inside quotes seems a common practice for newbies. Anyways, u can add the following line inside your while loop:

 

if($file == '.' or $file == '..'){ continue; }

 

so that u dont show . or ..

[jtown]

WOW

That has nothing to do with my question

[Fadion]

WOW

That has nothing to do with my question

 

About my post? The code i posted will get rid of the . and .. when reading the folder content.

[jtown]

Thanks man, but why am I getting the following error

 

Warning: rename(,) [function.rename]: No such file or directory in /home/mmaaaco/public_html/jfanning/mm2232midterm/question_1.php on line 14

 

here is my code

I'm new at this shit and am having a hard time wrapping my head around it

 

 

$imgold = "images/GSP_02.Jjpg";

$dir = opendir("images");

$old = $_POST['oldname'];

$new = $_POST['newname'];

rename("$old", "$new");

 

while ($file = readdir($dir))

{

echo "current filename:  $file\n";

?>

<form action="<? echo($PHP_SELF)?>" method="post">

<input type="hidden" name="oldname" />

<input type="text" name="newname" size="30"/><br />

<input type="submit" value="change file name"/><br /><br />

</form>

<?

}

 

closedir($dir);

 

Thanks

[revraz]

Post all the code, and point out line 14.

 

Also echo $old and $new and see if the post value is making it over.

[jtown]

This is all the code it is just a midterm question for class

line 14 is the line where the rename function is.

$old and $new do not make it over

 

Thanks

[DarkWater]

Put:

print_r($_POST);

on the top of your page and show us the output after submitting the form.

[jtown]

same error but now it shows Array() at the top.

What the hell am I missing.  I know it is something simple

[DarkWater]

Is that the whole code?  And let me see the form code.

[jtown]

here is all the code

 

print_r($_POST);

$imgold = "images/GSP_02.Jjpg";

$dir = opendir("images");

$old = $_POST['oldname'];

$new = $_POST['newname'];

rename("$old", "$new");

 

while ($file = readdir($dir))

{

if($file == '.' or $file == '..'){ continue; }

echo "current filename:  $file\n";

?>

<form action="<? echo($PHP_SELF)?>" method="post">

<input type="hidden" name="oldname" />

<input type="text" name="newname" size="30"/><br />

<input type="submit" value="change file name"/><br /><br />

</form>

<?

}

 

closedir($dir);

 

Thanks man

[DarkWater]

So you're displaying a NEW form (HTML-wise) for every file?

[jtown]

even if I echo out $old there is no result

[DarkWater]

<?php
if (isset($_POST)) {

$dir = opendir("images");
$old = $_POST['oldname'];
$new = $_POST['newname'];
rename("$old", "$new");
echo "$old renamed to $new. <br />";
}

   while ($file = readdir($dir))
      {
      if($file == '.' or $file == '..'){ continue; }
      echo "current filename:  $file\n";
      ?>
      <form action="<? echo($PHP_SELF)?>" method="post">
      <input type="hidden" name="oldname" />
      <input type="text" name="newname" size="30"/>

      <input type="submit" value="change file name"/>


      </form>
      <?
      }

   closedir($dir);
?>

 

Try that.  Should work.

[jtown]

Why do I get the same error about the directory???

 

Warning: rename(,dgfdgf) [function.rename]: No such file or directory in /home/mmaaaco/public_html/jfanning/mm2232midterm/question_1.php on line 15

 

My images that I'm trying to rename are in my images folder.

line 15 has my rename function

[DarkWater]

Ah, I see the issue.  Here:

<?php
if (isset($_POST)) {

$dir = opendir("images");
$old = $_POST['oldname'];
$new = $_POST['newname'];
rename("$old", "$new");
echo "$old renamed to $new. <br />";
}

   while ($file = readdir($dir))
      {
      if($file == '.' or $file == '..'){ continue; }
      echo "current filename:  $file\n";
      ?>
      <form action="<? echo($PHP_SELF)?>" method="post">
      <input type="hidden" name="oldname" value="<?php echo $file ?>" />
      <input type="text" name="newname" size="30"/>

      <input type="submit" value="change file name"/>


      </form>
      <?
      }

   closedir($dir);
?>

[revraz]

If it's classwork, then maybe you should do most of the work with a little guidance, not having people actually do it for you.

 

This is all the code it is just a midterm question for class

Thanks

[DarkWater]

I didn't even see that line. @_@  But my code will work....(too late to take it back, lol).

[jtown]

Still getting the same error

 

Warning: rename(,) [function.rename]: No such file or directory in /home/mmaaaco/public_html/jfanning/mm2232midterm/question_1.php on line 15

 

What is going on with my rename function.  Why does it say there is no directory?

 

Thanks

[DarkWater]

You aren't setting $oldname to anything.