php and the dreaded checkbox

[runnerjp]

how would this be correct

<?php
if (isset($_POST["edit"])) {
$title = $_POST['title'];
if(isset($_POST['forumlock'])){
$forumlock=1;
}


$query = "UPDATE forumtutorial_posts SET forumlock = '$forumlock', title = '$title' WHERE postid='$id' ";

mysql_query($query) or die('Error, query failed');
echo "Your title is ". $title . "<br />";?> 

[obsidian]

We need a little more information to be able to help with that. First off, in the code you posted, there is no $id variable being set, so that may cause part of your problem. Can you describe your markup and what it is you are trying to do? You will probably be able to get a more thoughtful answer that way.

[blackcell]

Need a little bit of an explanation as to what you are trying to do. If your trying make something locked depending on whether the user has a checkbox checked or not, you need to test what you $_POST from that checkbox name. A good learning point would be create a checkbox (within a form) and on your php, simple echo $_POST['checkboxname'] within a submit test. Once you have established what you are testing for you have solved your problem.

 

With checkboxes, I believe your testing for "on" if it is checked and nothing if it is not.

 

[runnerjp]

ok this is my whole form

 

<?php

error_reporting(E_ALL);
require_once '../settings.php';
checkLogin ('1');
$id=$_GET['id']; 
$query = "SELECT * FROM forumtutorial_posts where postid='$id'"; 
if ($result = mysql_query($query)){
    if (mysql_num_rows($result)) {
        $array = mysql_fetch_assoc($result);
        $title = $array['title'];
      
?>


<?php
if (isset($_POST["edit"])) { 
$title = $_POST['title'];
if(isset($_POST['forumlock'])){
$forumlock=1;
}


$query = "UPDATE forumtutorial_posts SET forumlock = '$forumlock', title = '$title' WHERE postid='$id' ";

mysql_query($query) or die('Error, query failed');
echo "Your title is  ". $title . "<br />";

} else {
?>

<h4>test</h4>
<form action='<?php "$_SERVER[php_SELF]" ?>' method="post"> 

Title: 
  <input name="title" type="text" value="<?php echo $title;?>" /> 
  <input type="checkbox" name="forumlock"> Lock a Room
<input type="submit" name="edit" value="edit"/>
</form>
</body></html>
<?php }}}?>

 

basicly all i want to do is if checkbox is checked then add the value of 1 into locked in my db

[blackcell]

I don't think your form action was quite right. It should be <? echo $_SERVER['PHP_SELF'] ?> instead of <?php "$_SERVER

[php_SELF]" ?> Try placing an echo test inside of your isset $_POST[''] to make sure that code within the brackets is being executed.

<?php

error_reporting(E_ALL);
require_once '../settings.php';
checkLogin ('1');
$id=$_GET['id'];
$query = "SELECT * FROM forumtutorial_posts where postid='$id'";
if ($result = mysql_query($query)){
    if (mysql_num_rows($result)) {
        $array = mysql_fetch_assoc($result);
        $title = $array['title'];

?>


<?php
if (isset($_POST["edit"])) {
$title = $_POST['title'];
if(isset($_POST['forumlock'])){
$forumlock=1;
}


$query = "UPDATE forumtutorial_posts SET forumlock = '$forumlock', title = '$title' WHERE postid='$id' ";

mysql_query($query) or die('Error, query failed');
echo "Your title is  ". $title . "<br />";

} else {

?>
<h4>test</h4>
<form name="input" action='<? echo $_SERVER['PHP_SELF'] ?>' method="post">

Title:
  <input name="title" type="text" value="<?php echo $title;?>" />
  <input type="checkbox" name="forumlock"> Lock a Room
<input type="submit" name="edit" value="edit"/>
</form>
</body></html>
<?php }}}?>

[runnerjp]

i think this is not right

 

 

if (isset($_POST["edit"])) {

$title = $_POST['title'];

if(isset($_POST['forumlock'])){

$forumlock=1;

}

[blackcell]

<?php
//Besides your bracketing being done is a manner that is so hard to read, I would try this.
if (isset($_POST["edit"])) {

    $title = $_POST['title'];

    if($_POST['forumlock'] == "on")

        $forumlock = 1

    }else{

        $forumlock = 0;

    }

}
?>

[runnerjp]

for the code you provided i get unexpected }  here  }else{

 

[blackcell]

No offense but have you ever had to track down a loose bracket before? Here it is and cleaned up.

<?php
error_reporting(E_ALL);
require_once '../settings.php';
checkLogin ('1');
$id=$_GET['id'];
$query = "SELECT * FROM forumtutorial_posts where postid='$id'";
if ($result = mysql_query($query)){
    if (mysql_num_rows($result)) {
        $array = mysql_fetch_assoc($result);
        $title = $array['title'];

        if (isset($_POST["edit"])) {

            $title = $_POST['title'];

            if($_POST['forumlock'] == "on")

                $forumlock = 1

            }else{

                $forumlock = 0;

            }

        }

    $query = "UPDATE forumtutorial_posts SET forumlock = '$forumlock', title = '$title' WHERE postid='$id' ";

    mysql_query($query) or die('Error, query failed');
    echo "Your title is  ". $title . "<br />";

} else {


echo "
<h4>test</h4>
<form name='input' action='".$_SERVER['PHP_SELF']."' method='post'>

Title:
  <input name='title' type='text' value='$title' />
  <input type='checkbox' name='forumlock'> Lock a Room
<input type='submit' name='edit' value='edit'/>
</form>
    ";
}
?>
</body></html>

[sasa]

you don't set up variable id in your form action url

[blackcell]

I just did sasa. May I ask why not?

[runnerjp]

even with this nice and tidy script

 

i still get unexpected }  here   

 

$forumlock = 1

 

            }else{

 

                $forumlock = 0;

[blackcell]

Forgot a semicolon

<?php
error_reporting(E_ALL);
require_once '../settings.php';
checkLogin ('1');
$id=$_GET['id'];
$query = "SELECT * FROM forumtutorial_posts where postid='$id'";
if ($result = mysql_query($query)){
    if (mysql_num_rows($result)) {
        $array = mysql_fetch_assoc($result);
        $title = $array['title'];

        if (isset($_POST["edit"])) {

            $title = $_POST['title'];

            if($_POST['forumlock'] == "on");

                $forumlock = 1;

            }else{

                $forumlock = 0;

            }

        }

    $query = "UPDATE forumtutorial_posts SET forumlock = '$forumlock', title = '$title' WHERE postid='$id' ";

    mysql_query($query) or die('Error, query failed');
    echo "Your title is  ". $title . "<br />";

} else {


echo "
<h4>test</h4>
<form name='input' action='".$_SERVER['PHP_SELF']."' method='post'>

Title:
  <input name='title' type='text' value='$title' />
  <input type='checkbox' name='forumlock'> Lock a Room
<input type='submit' name='edit' value='edit'/>
</form>
    ";
}

</body></html>
?>

[runnerjp]

nah that didnt work either as my query failed... but it should not fail as it shouldjust show

 

echo "
<h4>test</h4>
<form name='input' action='".$_SERVER['PHP_SELF']."' method='post'>

Title:
  <input name='title' type='text' value='$title' />
  <input type='checkbox' name='forumlock'> Lock a Room
<input type='submit' name='edit' value='edit'/>
</form>
    ";
}

as i didnt even submit any form

[BlueSkyIS]

you don't require that the form is submitted. all you require is:

 

if ($result = mysql_query($query)){

[runnerjp]

doesnt    if (isset($_POST["edit"])) { mean if form is submited do this

[blackcell]

Like we said at the beginning of this topic, what are you trying to do?

[runnerjp]

ok i will talk you through it

 

<?php
error_reporting(E_ALL);
require_once '../settings.php';
checkLogin ('1');
$id=$_GET['id'];
$query = "SELECT * FROM forumtutorial_posts where postid='$id'";
if ($result = mysql_query($query)){
    if (mysql_num_rows($result)) {
        $array = mysql_fetch_assoc($result);
        $title = $array['title'];

        if (isset($_POST["edit"])) {

            $title = $_POST['title'];

            if($_POST['forumlock'] == "on");

                $forumlock = 1;

            }else{

                $forumlock = 0;

            }

        }

    $query = "UPDATE forumtutorial_posts SET forumlock = '$forumlock', title = '$title' WHERE postid='$id' ";

    mysql_query($query) or die('Error, query failed');
    echo "Your title is  ". $title . "<br />";

} else {


echo "
<h4>test</h4>
<form name='input' action='".$_SERVER['PHP_SELF']."' method='post'>

Title:
  <input name='title' type='text' value='$title' />
  <input type='checkbox' name='forumlock'> Lock a Room
<input type='submit' name='edit' value='edit'/>
</form>
    ";
}
?>
</body></html>

 

so the code above should make it so i can edit a thread in a forum... so at the moment i have this

 

Title:

  <input name='title' type='text' value='$title' />  <-- gets the current name of the forum thread via

 

$id=$_GET['id'];
$query = "SELECT * FROM forumtutorial_posts where postid='$id'";
if ($result = mysql_query($query)){
    if (mysql_num_rows($result)) {
        $array = mysql_fetch_assoc($result);
        $title = $array['title'];

 

so then i can chnage the name of the thread

 

and also my check box

  <input type='checkbox' name='forumlock'> Lock a Room

 

 

so if i tick this check box it will chance forumlock in my database from 0 to 1 so then the thread is locked

 

just like on here!

 

so once its filled in i want to post it all into my db via

 

$query = "UPDATE forumtutorial_posts SET forumlock = '$forumlock', title = '$title' WHERE postid='$id' ";

 

with id being the thread id

 

 

[runnerjp]

ok im missing a } sum where but i can seem to find it

 

PHP Code:

<?php
error_reporting(E_ALL);
require_once '../settings.php';
    checkLogin ('1');
$id=$_GET['id'];
$query = "SELECT * FROM forumtutorial_posts where postid='$id'";
if ($result = mysql_query($query)){
    if (mysql_num_rows($result)) {
        $array = mysql_fetch_assoc($result);
        $title = $array['title'];

   $forumlock=0;// default value if it's not set

if (isset($_POST['edit'])) {
$title = $_POST['title'];
}
if(isset($_POST['forumlock'])){
$forumlock=1;
}

$query = "UPDATE forumtutorial_posts SET forumlock = '$forumlock', title = '$title' WHERE postid='$id' ";

mysql_query($query) or die('Error, query failed');
echo "Your title is ". $title . "<br />"; 

} else {


echo "
<h4>test</h4>
<form name='input' action='".$_SERVER['PHP_SELF']."' method='post'>

Title:
  <input name='title' type='text' value='$title' />
  <input type='checkbox' name='forumlock'> Lock a Room
<input type='submit' name='edit' value='edit'/>
</form>
    ";
}
?>

i thin its if ($result = mysql_query($query)){ but im not shore where to put it

runnerjp is online now Add to runnerjp's Reputation Report Post  Thanks Edit/Delete Message

[sasa]

you don't set up variable id in your form action url

I just did sasa. May I ask why not?

you have $i = $_GET['id']; in your script

it's mean thet your URL looks like some_file.ph?id= blah

but in your form tag you have <form name='input' action='".$_SERVER['PHP_SELF']."' method='post'>

it's mean that url is sone_file.php miss ?id=blah part