[SOLVED] Whats wrong with this? (php mysql syntax)

[monkeytooth]

$query = " SELECT * FROM memb_pers " .
         " LIMIT $offset, $rowsPerPage " .
	 " WHERE c0unty = '$clocd' ";

 

the error is:

You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'WHERE c0unty = 'Litchfield'' at line 1

 

 

I have no idea where I went wrong with this, it works without the WHERE clause, but then I added the WHERE and I think I did it right.. but im wrong so help?

[akitchin]

WHERE goes before the LIMIT clause.  have a look at the MySQL manual on the SELECT syntax - it will show you the order in which clauses must appear if they are to be used.

[Maq]

Also shouldn't

 " WHERE c0unty = '$clocd' ";

 

be

 

 " WHERE c0unty = '.$clocd.' ";

?

[revraz]

No

 

Also shouldn't

 " WHERE c0unty = '$clocd' ";

 

be

 

 " WHERE c0unty = '.$clocd.' ";

?

[cooldude832]

If you are going to connotation methods (which I recommend) you need to show it right

<?php
$query = " SELECT * FROM `memb_pers`  Where C0unty = '".$cloucd."' LIMIT  ".$offset.", ".$clocd;
?>

[monkeytooth]

Thank you all.. yet again you have help me..

[akitchin]

If you are going to connotation methods (which I recommend) you need to show it right

 

i believe what you mean are concatenation methods (in case anyone ever goes to google it).

[Prismatic]

You can also use brackets to concate

 

$name = "Bob";
echo "Hello my name is {$name}";

 

versus

 

$name = "Bob";
echo "Hello my name is ". $name;

 

[akitchin]

no need for braces when using double quotes unless you're using arrays:

 

$name = 'Bob';
$names = array('first' => 'Bob');

echo "Hello, my name is $name<br />";
echo "Hello, my name is {$names['first']}<br />";

echo 'Hello, my name is '.$name;

 

for the record, you should always be using single quotes for strings that contain no variables - that way PHP doesn't have to waste resources scouring the string for variable references before echoing it.  read up on variable interpolation for more info.

[Daniel0]

Regarding the single/double quote thing. http://phpbench.com indicates that there is no difference.

[akitchin]

Regarding the single/double quote thing. http://phpbench.com indicates that there is no difference.

 

i stand corrected!  thanks Daniel, always good to know something new.  i read an article quite some time ago which urged the use of single quotes for literals, i should have looked into it more.

[Daniel0]

Well it would make sense that it would be like that. I guess they made some sort of optimizations to deal with that.

[cooldude832]

your still talking minimal amounts and most of the time you are phrasing a string with variables (other wise php doesn't provide you a lot of usefulness) so I personally use double quotes and then ". to escape any variable.

<?php
$var = "yes";
echo "Do you like php?<br />".$var;
?>

 

If you use brackets or escape it php knows that variable name and won't waste a ton of resources trying to find a variable that doesn't exist thus it result in echoing it out or fatal error.

[akitchin]

your still talking minimal amounts and most of the time you are phrasing a string with variables (other wise php doesn't provide you a lot of usefulness) so I personally use double quotes and then ". to escape any variable.

<?php
$var = "yes";
echo "Do you like php?<br />".$var;
?>

 

If you use brackets or escape it php knows that variable name and won't waste a ton of resources trying to find a variable that doesn't exist thus it result in echoing it out or fatal error.

 

a fatal error from PHP not finding a variable that matches what's in double quotes?  more like a blank space appearing there.  if you concatenate the variable, what's the point of even using double quotes?  you yourself said that's what it's useful for.

 

<?php
$var = "yes";
echo "Do you like php?<br />$var";
?>

[cooldude832]

its more of the pretty print pick up in the notepad editor because I can tell where a var is and where a string is very easily