How much per line?

[tibberous]

How much stuff do you stick on one line?

 

I generally do something like this:

 

if(!$id = intval($_REQUEST['id']))
return "No id was sent.";

 

But won't do something like:

 

mysql_query("select * from users where name='".mysql_real_escape_string(trim($_REQUEST['name']))."'");

 

I hate when people use too many, or not enough, lol.

[ober]

It depends.  I know a lot of people that break queries out like this:

 

$query = "SELECT a,b,c
              FROM tablexyz
              WHERE x = y
              ORDER BY w ASC";

 

I put all that on one line unless the query is extremely complicated.  But good coding standards dictate that you typically break logical portions of code into separate lines for readability.

[unsider]

I usually keep it all on one line unless I'm collabing with someone. Then I tend to break it into, ober said, "logical portions of code [with] separate lines for readability".

 

 

I'll post some examples later if I have time.

[corbin]

I love one liners.

 

 

 

When I write them.

 

 

 

lol

 

 

If there is only one thing going on (like assigning a variable, or echo content or what ever), I don't care what sub stuff happens, I keep it on one line.  (Dunno if that made sense.)

 

 

For example:

 

$a = "Hi my name is " . GetName(GetUser(SomeOtherFunctionCall(ThisIsGetttingRetarded())));
//or
$q = mysql_query("<super long query here>", $db);