can this email addres finder function be improved ?

[2levelsabove]

any feedback is appreciated.

 

function extract_emails_from($string){
  preg_match_all("/[\._a-zA-Z0-9-]+@[\._a-zA-Z0-9-]+/i", $string, $matches);
  return $matches;
}

[Maq]

I'm not a regex expert, but try this regular expression:

 

$pattern = "/\b[^@\s]+@\S+?\.[a-z]+\.?[a-z]+\b/i";

 

It will match emails even if they have () or around them.

[corbin]

His would still find the email address in () or <>.

[Maq]

His would still find the email address in () or .

 

Yeah sorry, I was just trying to throw something out there to help him out.  Like I said, I'm not a regex expert.

[2levelsabove]

Thanks a lot guys!

 

you guys are awesome!

[effigy]

It depends on how flexible or strict you want to be. For example, according to the RFC here, you could miss some addresses.