Would love some help

sastiger · September 19, 2008

I keep getting this

Parse error: syntax error, unexpected T_VARIABLE in C:\xampp\htdocs\home\post.php on line 8

Here is my actual code for the post.php page

<?php

$loginname = $_POST['loginname'];

$password = $_POST['password'];

mysql_connect ("localhost", "root", "majick") or die (

mysql_select_db ("animal1")

$result = mysql_query("INSERT INTO login ($username, $password)

VALUES ('$username', $password')");

mysql_query($query) or die (’Error updating database’);

echo “database was updated with: ” ".$username.” “.$password.”;

?>

Please help me any help would be greatly appreciated!

Mchl · September 19, 2008

You're missing a ; after mysql_select_db().

Also, you're having a missing ' in your mysql query around $password

And this:

echo “database was updated with: ” ".$username.” “.$password.”;

should be

echo "database was updated with: $username $password";

sastiger · September 20, 2008

Still am getting the same error here is my page which is posting to the php file

<html>

<head>

<title>Pet creation page</title>

</head>

<body>

<br>

<br>

<td>Price:</td>

<br>

</form>

</body>

</html>

and here is my php post page

<?php

$petname = $_POST['name'];

$pettype = $_POST['type'];

$petprice = $_POST['250'];

$host="localhost";

$user="root";

$pass="majick";

mysql_connect ("$host", "$user", "$pass") or die (

mysql_select_db(pet)

$result = mysql_query("INSERT INTO animal (name, type, price)

VALUES ('$petname', '$pettype', '$petprice');

mysql_query or die (’Error updating database’);

?>

PLEASE HELP

AndyB · September 20, 2008

$petname = $_POST['name'];
$pettype = $_POST['type'];
$petprice = $_POST['petprice'];

$host="localhost";
$user="root";
$pass="majick";

mysql_connect ($host, $user, $pass) or die ('some error message');
mysql_select_db("pet");

$result = mysql_query("INSERT INTO animal (name, type, price)
VALUES ('$petname', '$pettype', '$petprice')");

mysql_query or die ('Error updating database');

sastiger · September 20, 2008

Thanks for that andy but on the database it just shows up as blank input ???

chronister · September 20, 2008

$query = "INSERT INTO animal (name, type, price) VALUES ('$petname', '$pettype', '$petprice')";

$result = mysql_query($query) or die (mysql_error);

Replace the last 2 lines in the example AndyB posted and see if you get any errors. When troubleshooting query errors, the best thing to do is echo the query as it is set in the script and look for errors there. If that don't work, copy/paste into phpmyadmin and see what you get there. I have saved hours of headache by doing this. A lot of times phpmyadmin will tell you what is wrong and you can modify and tweak the query there until it is right. Then you can port it back to your script.

I found a database class script that I use exclusively for all my DB work. I have modified it so I can place it in the root of the server, and call it from several sites and connect to multiple databases with it. Makes this type of stuff MUCH simpler.

I will share it if you would like.

Nate

Mchl · September 20, 2008

Should be:

$query = "INSERT INTO animal (name, type, price) VALUES ('$petname', '$pettype', '$petprice')";
$result = mysql_query($query) or die mysql_error();

chronister · September 20, 2008

Should be:

$query = "INSERT INTO animal (name, type, price) VALUES ('$petname', '$pettype', '$petprice')";
$result = mysql_query($query) or die mysql_error();

die is a built in function. So it is correct as die(). I believe that die without the parentheses is correct as well, but the php manual shows it in use as die()

But, you did bring an error to my attention. It should be die(mysql_error()).

I had an extra space in there and forgot the parentheses for the mysql_error function.

Nate

Mchl · September 20, 2008

To be exactly exact die() is a language construct and not a function. That's why it can be called both ways.

mysql_error() is a function and it needs its parentheses.

chronister · September 20, 2008

ahhh whatever... it appears in the php manual under Misc Functions.. and is referenced as function in many places including w3schools.com so in my book it is a function.

On php.net it says

This language construct is equivalent to exit().

in the description under Misc Functions.

So either way is right. Function, Language construct whatever.

Nate

Mchl · September 20, 2008

I agree. For everyday use there's no difference.

Edit:

Except for this note

Note: Because this is a language construct and not a function, it cannot be called using variable functions

But I think it's not in the scope of 'everyday use' for most people.

chronister · September 20, 2008

we're getting a bit off topic here... but I don't know what the hell a variable function is. I can venture a guess as to how it works .... but never needed to use it.

sastiger · September 20, 2008

If you would like to shair that with me chronister then please do also how do I read date from it?

Like lets say the petname ?

Thanks Everyone for your help :>

sastiger · September 20, 2008

If you would like to shair that with me chronister then please do also how do I read data from the mysql?

Like lets say the petname ?

Thanks Everyone for your help :>

AndyB · September 20, 2008

maybe it's time to do some light reading - http://www.tizag.com/mysqlTutorial/

chronister · September 20, 2008

Read up on mysql and how to use it.... but here is the database class.

<?php
class cDatabase {

  //class variables defined in constructor
  var $host;
  var $user;
  var $password;
  var $database;
  var $type;
  
  //constructor - needed for connection string
  function cDatabase($type)
  {
  	if($type == 'db1')
  	{  
  		 $hostName='HOST1';
	 $userName='USER1';
	 $passwordName='PASSWORD1';
	 $databaseName='DB NAME1';
}
elseif($type == 'db2')
{ 
	$hostName='HOST2';
	$userName='USER2';
	$passwordName='PASSWORD2';
	$databaseName='DB NAME 2';
}
else
{
	$error = 'Valid DB could not be selected';
}

  
    $this->host = $hostName;
    $this->user = $userName;
    $this->password = $passwordName;
    $this->database = $databaseName;

}

  //loop through paired arrays buildng an sql INSERT statement
  function sqlInsert($dataNames, $dataValues, $tableName){
  $sqlNames = "INSERT INTO " . $tableName . "(";
  for($x = 0; $x < count($dataNames); $x++) 
  {
	  if($x != (count($dataNames) - 1)) 
	  {
		 $sqlNames = $sqlNames . $dataNames[$x] . ", ";
		 @$sqlValues = $sqlValues . "'" . addslashes($dataValues[$x]) . "', ";
	  }
	  else 
	  {
		  $sqlNames = $sqlNames . $dataNames[$x] . ") VALUES(";
		  $sqlValues = $sqlValues . "'" . $dataValues[$x] . "')";
	  }
  }
  
  	$result = $this->ExecuteNonQuery($sqlNames . $sqlValues);
   	$results['inserted'] = 0;
	$results['skipped'] = 0;
	$results['last_id'] = mysql_insert_id();

   if($result == 1)
   {
   		$results['inserted'] = 1;
   }
   else
   {
   		$results['skipped'] = 1;
   }
   
   return $results;
  
  
  }

  //loop through paired arrays buildng an sql UPDATE statement
  function sqlUpdate($dataNames, $dataValues, $tableName, $condition){
  $sql = "UPDATE " . $tableName . " SET ";
  for($x = 0; $x < count($dataNames); $x++) 
  {
	  if($x != (count($dataNames) - 1)) 
	  {
		  $sql = $sql . $dataNames[$x] . "= '" . $dataValues[$x] . "', ";
	  }
	  else 
	  {
		  $sql = $sql . $dataNames[$x] . "= '" . $dataValues[$x] . "' ";
	  }
  }
  $sql = $sql . $condition;

    $result = $this->ExecuteNonQuery($sql);
	$results['inserted'] = 0;
	$results['skipped'] = 0;
	$results['last_id'] = mysql_insert_id();
  
   if($result == 1)
   {
   		$results['inserted'] = 1;
   }
   else
   {
   		$results['skipped'] = 1;
   }
   
   return $results;
  }

    //execute a query
  function ExecuteNonQuery($sql)
  {
	$conn = mysql_connect($this->host, $this->user, $this->password);
	$sql = mysql_real_escape_string($sql);
	mysql_select_db ($this->database) ;
	$result = mysql_query($sql,$conn) ;
	$changed = mysql_affected_rows();
  
return $changed;

  }
  
  //execute a query and return a recordset
  function ExecuteReader($query)
  {
    $conn = mysql_connect($this->host, $this->user, $this->password);
$query = mysql_real_escape_string($query);
    mysql_select_db ($this->database);
$result = mysql_query($query,$conn);
return $result;

  } 

}
?>

To use it, you instantiate the class like this.

<?php
$db = new cDatabase('db1'); // this will connect to the database defined in db1 
?>

Then to use it's functions you do it like so..

Select Query:

<?php
$result = $db->ExecuteReader("SELECT * FROM tableName WHERE this='$that'");
echo mysql_num_rows($result);
?>

Insert Query:

<?php
$names = array('field1','field2','field3','field4');
$values = array($val1, $val2, $val3, $val4);
$result = $db->sqlInsert($names, $values, 'tableName');
echo $result['inserted']; // will return 1 or 0
?>

Update is the same as insert but you use this instead.

<?php
$result = $db->sqlUpdate($names, $values, 'tableName', $whereClause);
?>

Delete Query:

<?php
$result = $db->ExecuteNonQuery("DELETE FROM tablename WHERE this='$that'");
?>

You can set this up to connect to multiple databases by adding additional $type sections.

<?php
        if($type == 'db1')
  	{  
  		 $hostName='HOST1';
	 $userName='USER1';
	 $passwordName='PASSWORD1';
	 $databaseName='DB NAME1';
}
?>

It may even be better to make this a switch instead of a bunch of elseif. This is by no means perfect as a db class, but it works. I have tried to optimize it and sanitize all db input in it.

Nate

DarkWater · September 20, 2008

Why do you start a new connection each query? That's absolutely horrible. Also, with the constructor, you should just have all of the details passed in as an array so you can store it in like $this->conn_info, then use a private _connect() method to get the proper connection. If they enter the wrong db details, sucks for them. You'd throw an Exception, not make a $error.

chronister · September 20, 2008

DarkWater,

I did not write this. I started to write my own db class, but found this one and just have not taken too much time in making it better.

I am also not real versed on oop and classes. This was a quick and simple method of a universal db class that I found. I will take your advice under consideration and do some research at some point and try to make it better.

Thanks for the tips.

Sign In

Would love some help

Recommended Posts

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Join the conversation

Important Information