return false and error?

[ohdang888]

after a function does its job, i want to to return true if succesful... which i'ev done..

 

but if it fails, i want it to return false AND return $error, so that i have the error message.

 

How can this be achieved?

 

 

Thanks.

[DarkWater]

You can't, but show us the function anyway so maybe we can show an alternative solution.

[jonsjava]

simple solution:

<?php
function test($data){
if ($data == 1){
	$data_array[0] = true;
}
else{
	$data_array[0] = false;
	$data_array[1] = "error found";
}
return $data_array;
}
$test = test(2);
if ($test[0] == false){
print $test[1];
}

[Prismatic]

You can.

 

<?php

function Boo($var)
{
if($var == "test")
{
	return true;
}
else
{
	return "This is false";
}
}

if(Boo() !== true)
{
echo Boo();
}
else
{
echo "True";
}
?>

 

 

if(boo() !== true) returns "This is false"

 

if(boo("test") !== true) echos "True"

 

[ohdang888]

<?php

function log_in($email, $password){

if(empty($email) and empty($password)){
$error = "Empty username or password";
}

$email = clean($email);
$password = md5(md5(clean($password)));
db("discuss");
$res = sql("SELECT * FROM `users` WHERE upper(email)=upper('$email') and `password`='$password' ");
if(mysql_num_rows($res) == 1){
$row = mysql_fetch_array($res);
$_SESSION['logged_in'] = true;
$_SESSION['user_id'] = $row['user_id'];
$_SESSION['username'] = $row['username'];
$_SESSION['key'] = $row['key'];

//grab friends and put it in session
if($row['user_id'] == 1){//if user id is 1
$_SESSION['admin'] = true;
}

$time =  date("Y-m-d H:i:s");
$id = $row['user_id'];
sql("DELETE FROM `online_now` WHERE `user_id`='$id' LIMIT 1");
sql("INSERT INTO `online_now` (`user_id`, `time`)VALUES('$id', '$time')");


}else{//end if one row is found
$res = sql("SELECT `user_id` FROM `users` WHERE `email`='$email' ");
if(mysql_num_rows($res) == 0){
$error = "Email does not exist";
}else{
$error = "Wrong Password";
}
}//end else
if(isset($error)){
return false;
return $error;
}else{
return true;
}
}//end log in
?>

[trq]

If I where you I would take a look at exceptions. I would also consider breaking that function down into smaller functions, it does far more than simply log in a user, hence your need for more detailed error messages. Functions should be short, concise and to the point.

[Prismatic]

<?php

function log_in($email, $password){

if(empty($email) and empty($password)){
$error = "Empty username or password";
}

$email = clean($email);
$password = md5(md5(clean($password)));
db("discuss");
$res = sql("SELECT * FROM `users` WHERE upper(email)=upper('$email') and `password`='$password' ");
if(mysql_num_rows($res) == 1){
$row = mysql_fetch_array($res);
$_SESSION['logged_in'] = true;
$_SESSION['user_id'] = $row['user_id'];
$_SESSION['username'] = $row['username'];
$_SESSION['key'] = $row['key'];

//grab friends and put it in session
if($row['user_id'] == 1){//if user id is 1
$_SESSION['admin'] = true;
}

$time =  date("Y-m-d H:i:s");
$id = $row['user_id'];
sql("DELETE FROM `online_now` WHERE `user_id`='$id' LIMIT 1");
sql("INSERT INTO `online_now` (`user_id`, `time`)VALUES('$id', '$time')");


}else{//end if one row is found
$res = sql("SELECT `user_id` FROM `users` WHERE `email`='$email' ");
if(mysql_num_rows($res) == 0){
$error = "Email does not exist";
}else{
$error = "Wrong Password";
}
}//end else
if(isset($error)){
return false;
return $error;
}else{
return true;
}
}//end log in
?>

 

Ok do this

 

<?php

function log_in($email, $password){
    if(empty($email) and empty($password))
    {
        $error = "Empty username or password";
    }

    $email = clean($email);
    $password = md5(md5(clean($password)));
    db("discuss");
    $res = sql("SELECT * FROM `users` WHERE upper(email)=upper('$email') and `password`='$password' ");
    if(mysql_num_rows($res) == 1)
    {
        $row = mysql_fetch_array($res);
        $_SESSION['logged_in'] = true;
        $_SESSION['user_id'] = $row['user_id'];
        $_SESSION['username'] = $row['username'];
        $_SESSION['key'] = $row['key'];

        //grab friends and put it in session
        if($row['user_id'] == 1)
        {//if user id is 1
            $_SESSION['admin'] = true;
        }

        $time =  date("Y-m-d H:i:s");
        $id = $row['user_id'];
        sql("DELETE FROM `online_now` WHERE `user_id`='$id' LIMIT 1");
        sql("INSERT INTO `online_now` (`user_id`, `time`)VALUES('$id', '$time')");
    }
    else
    {//end if one row is found
        $res = sql("SELECT `user_id` FROM `users` WHERE `email`='$email' ");
        if(mysql_num_rows($res) == 0){
            $error = "Email does not exist";
        }
        else
        {
            $error = "Wrong Password";
        }
    }//end else
    
    if(isset($error)){
        return $error;
    }
    else
    {
        return true;
    }
}//end log in
?>

 

Then check your function

 

<?php
if(log_in(blah, blah) !== true)
{
    /** Function is not true, so it contains our error message */
    echo log_in(blah, blah);
}
else
{
    /** Function returned true */
    echo "Success!";
}
?>

 

if it's

[DarkWater]

Prismatic, that requires calling the function twice...which is not efficient.

[Prismatic]

Prismatic, that requires calling the function twice...which is not efficient.

 

Doesn't require it.

 

$blah = myfunct();

if($blah !== true)

[ohdang888]

so is this the best way?

 

$blah = myfunct();

if($blah !== true)

[trq]

No, the best way IMO would be to use exceptions.

[thewooleymammoth]

im not exactly sure but wouldn't this work?

 

if (scandir('images/'))
{
   echo "function successful";
}
else 
{
  echo "you suck";
}

[thewooleymammoth]

oh uh duh

 

function() or die "error";
echo "function successful";

[Zane]

that would work

 

Although you can only use it once and for only one function per script.

 

If you die...so to speak.  The script terminates

 

on the contrary though you can do this

 

function someFunction() {
   return false;
}
someFunction() or print("This function has failed by god");