[SOLVED] multi-file upload script

woodsonoversoul · December 5, 2008

I'm working on a multi-file upload script and have two current problems.

1. The correct amount of upload boxes are not shown, there should be as many upload boxes as there are elements in the array $setOne

2. The files aren't uploading. Uploading worked fine when I was doing single uploads, what gives?

My code:

<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN"
"http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">

<html xmlns="http://www.w3.org/1999/xhtml"
xml:lang="en" lang="en">

<head>
<meta http-equiv="content-type" content="text/html; charset=iso-8859-1" />

<title>File Uploader</title>
<style type="text/css" title ="text/css" media="all">
.error {
	font-weight: bold;
	color: #C00
}
</style>
</head>
<body>
<?php #File uploading script
//start a loop to move through all the files
for($i = 0; $i < count($setOne); $i++){

//check to see if file has been submitted
if(isset($_POST['submitted'])){
	//if it has, check the type

	//debug - show all pertinate file info
	/*echo "<pre>";
        //print_r($_FILES);
        //echo "</pre>";
        */  
        
	//create an array of allowed types (NOTE: need MIME type for Flac)
	$allowed = array('audio/mpeg');
	//now evaluate current file
	//check to see if current file's type is in the array of allowed types
	if(in_array($_FILES['upload']['type'][$i], $allowed)){
		//If True, move the file to new location
		if(move_uploaded_file($_FILES['upload']['tmp_name'][$i], "/home/dan/MusicDataBase/{$_FILES['upload']['name'][$i]}")){
			echo '<p><em>The file has been uploaded!</em></p>';
		}//end of move_uploaded_file
	} else {//invaild type
		echo '<p class="error">Error: Wrong filetype. Must be mp3</p>';
	}//end else
}//end isset($_FILES['upload']

//now check for additional errors

if($FILES_['upload']['error'][$i] > 0){
	echo '<p class="error">The file could not be uploaded because: <strong>';
	//print message based on error
	switch($_FILES['upload']['error'][$i]){
		case 1:
			print 'The file exceeds the upload_max_filesize settiing in php.ini';
			break;
		case 2:
			print 'The file exceeds the MAX_FILE_SIZE setting in the html form';
			break;
		case 3:
			print 'The file was only partially uploaded';
			break;
		case 4:
			print 'No file was uploaded';
			break;
		case 6:
			print 'No temporary folder was available';
			break;
		case 7:
			print 'Unable to write to the disk';
			break;
		case  8:
			print 'File upload was stopped';
			break;
		default:
			print 'A system error occured';
			break;
		}//end of switch

		print '</strong></p>';

	}//end of error if

	//Delete file if if still exist
	if(file_exists($_FILES['upload']['tmp_name'][$i]) && is_files($_FILES['upload']['tmp_name'][$i])){
		unlink($_FILES['upload']['tmp_name'][$i]);
	}
}//end for loop

//////////////////////////////////////////////////////////////////
//the following are my functions which may or may not work
//their main function is to bring data from archiver.html
//and run various splitting and tagging functions on it
//aside  from the functions included here, everything
//works perfectly
//////////////////////////////////////////////////////////////////
//Initailize and assign values to starter variables.
    $show_id = "";
    $band = $_POST['band'];
    $date = $_POST['date'];
    $setOne = $_POST['setOne'];
    $set_oneNumOfSongs = count($setOne);
    
    ////////////////functions////////////////////
function create_song_array($set, $unique_show_id, $set_num) {
    /*function takes in show.set object, splits that object into
      an array, and then makes it multidiminsional. It then creates and
       assigns song ids to the first row of the array and song titles
        to the third row */
    
    //split the object into a dummy array based on ',' and '>', using perl-type regex
    $dummy_array = preg_split("/(,|>)/", $set);
    
    //use the trim() function to remove leading/trailing white spaces
    for($i=0;$i<count($dummy_array);$i++){
    	$dummy_array[$i] = trim($dummy_array[$i]);
}
    
    //then create the real array as a copy of dummy array
    $song_array = array(count($dummy_array));
    
    
    //make the real array multidiminsional and create eight
    //rows to hold the song's various properties
    for($i = 0; $i < count($dummy_array); $i++){
      $song_array[$i] = array(;
    }
    
    //assign song title, set_one_songs[2] = dummy_array[1]
    for($m = 0; $m < count($dummy_array); $m++){
      $song_array[$m][2] = $dummy_array[$m];
    }
    
    //assign unique song ids
    for($n = 0; $n < count($dummy_array); $n++) {
      $song_array[$n][0] = $unique_show_id . "s" . $set_num . "s" . ($n+1);
    }
    
    //return newly created array
    return $song_array;
  }//create_song_array
  
function showIdCreator($band, $date) {
    /*this function takes in the user inputed band name and show date.
     It then produces an abbreviation from the band name.
     It then returns this abbreviation combined with the show date
     to create the show id*/
    
    //variable declarations
    $abb;//store the abbreviated band name
    //convert the band name to lower case for easier comparison
    $band = strtolower($band);
    
    //set abbreviation based on band name
    switch($band) {
      case "widespread panic" :
        $abb = "wsp";
        break;
      case "grateful dead" :
        $abb = "gd";
        break;
      case "phish" :
        $abb =  "ph";
        break;
      case "ryan adams" :
        $abb =  "ra";
        break;
      default:
        $abb = "unknown";
    }
    
    //return a combination of the band name abbreviation and the show date
    return $abb . $date;
  }//end showIdCreator()  
    
    ////////////////end of functions//////////////////// 
    
    //create a unique show id
    $unique_show_id = showIdCreator($band, $date);

//create an array of songs based on set on and save it to an array of the same name
$set_one = create_song_array($setOne, $unique_show_id, "1");

//display show information
echo "The band is: " . $band . "<br>";
echo "The show date is: " . $date . "<br>";
echo "Unique show id: " . $unique_show_id . "<br><br>";
    				
?>

<form  enctype="multipart/form-data" action="upload_script.php" method="post">
<?php
//use a for loop to produce multiple upload boxes
for($i = 0; $i < count($setOne); $i++){
?>	
<input type ="hidden" name = "MAX_FILE_SIZE" value = "209715200" />

<fieldset><legend>Select a mp3 to upload:</legend>

<p><b>file:</b><input type="file" name ="upload[]" /></p>
</fieldset>

<?php
//end for loop
}
?>

<div align="center"><input type="submit" name="submit" value="Submit" /></div>
<input type="hidden" name="submitted" value="TRUE" />
</form>
</body>
</html>

Any other comments on my code are greatly appreciated

Thanks,

Dan

woodsonoversoul · December 5, 2008

bump for people viewing today

mrMarcus · December 5, 2008

try this...

<?php
error_reporting(E_ALL); //always have error reporting on;

if(isset($_POST["uploaded"])){ //check for form submission;
      while(list($key,$value) = each($_FILES['upload']['name'])){
            if(!empty($value)){ //as long as $value is present, everything below this line is executed;
                  /*
                        assign your variables;
                  */
                  $tmpFileName = $_FILES['upload']['tmp_name'][$key]; //tmp filename;
                  $fileName = $_FILES['upload']['name'][$key]; //actual filename;
                  $uploadDir = "/home/dan/MusicDataBase"; //directory where file(s) will be uploaded;
                  
                  /*
                        get file extension;
                  */
                  $getExt = explode('.', $fileName);
                  $fileExt = $getExt[count($getExt)-1]; //got file extension;
                  $allowedExt = array("mp3","MP3"); //these are allowed extensions;
                  
                  if(in_array($fileExt, $allowedExt)){
                        if(is_uploaded_file($tmpFileName)){
                              $i = "ok"; //file extension is ok; file has been uploaded;
                        }else{
                              $errors[] = "Problem uploading file.";
                              $i = "invalid"; //extension is ok; file wasn't uploaded;
                        }
                  }else{
                        $errors[] = "Incorrect file extension.";
                        $i = "invalid"; //bad file extension;
                  }
                  switch($){
                        case ok:
                              //optional random filename generator .. uncomment below to use;
                              //$fileName = md5(time())."_".rand(0,999999999).".".$fileExt;
                              
                              @move_uploaded_file($tmpFileName,$uploadDir.'/'.$fileName); //move tmp file;                              
                        break;
                        
                        case invalid:
                              //display errors here;
                              if(is_array($errors)){
                                    $count = count($errors);
                                    foreach($errors as $k => $v){
                                          echo $v; //display errors;
                                          if($count>1){ echo '<br />'; } //add line break if multiple errors;
                                    }
                              }
                        break;
                  }
            }else{
                  //no file was uploaded;
            }
      }
}else{
      //form was not submitted;
}
?>

it's not tested, so try at own risk .. hope it helps!

mrMarcus · December 5, 2008

in case you use this, the switch statement is missing an "i".

replace:

switch($)

- with -

switch($i)

woodsonoversoul · December 8, 2008

Thanks so much mrMarcus! I didn't totally replace my script with yours because I didn't understand all of the coding. However I did include your first line

error_reporting(E_ALL); //always have error reporting on;

and after fixing a few variable inconsistencies I'm left with these two error messages:

Notice: Undefined index: upload in /opt/lampp/htdocs/MSNTesting/upload_script.php on line 52

Notice: Undefined index: upload in /opt/lampp/htdocs/MSNTesting/upload_script.php on line 87

any ideas on why I get these messages here and not on line 40?

All help is greatly appreciated.

I haven't changed much but, for reference, here's my newly revised code:

<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN"
"http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">

<html xmlns="http://www.w3.org/1999/xhtml"
xml:lang="en" lang="en">

<head>
<meta http-equiv="content-type" content="text/html; charset=iso-8859-1" />

<title>File Uploader</title>
<style type="text/css" title ="text/css" media="all">
.error {
	font-weight: bold;
	color: #C00
}
</style>
</head>
<body>
<?php #File uploading script

//turn on error reporting
error_reporting(E_ALL);
//start a loop to move through all the files
for($i = 0; $i < count($setOne); $i++){

//check to see if file has been submitted
if(isset($_POST['submitted'])){
	//if it has, check the type

	//debug - show all pertinate file info
	/*echo "<pre>";
        print_r($_FILES);
        echo "</pre>";
        */
        
	//create an array of allowed types (NOTE: need MIME type for Flac)
	$allowed = array('audio/mpeg');
	//now evaluate current file
	//check to see if current file's type is in the array of allowed types
	if(in_array($_FILES['upload']['type'][$i], $allowed)){
		//If True, move the file to new location
		if(move_uploaded_file($_FILES['upload']['tmp_name'][$i], "/home/dan/MusicDataBase/{$_FILES['upload']['name'][$i]}")){
			echo '<p><em>The file has been uploaded!</em></p>';
		}//end of move_uploaded_file
	} else {//invaild type
		echo '<p class="error">Error: Wrong filetype. Must be mp3</p>';
	}//end else
}//end isset($_FILES['upload']

//now check for additional errors

if($_FILES['upload']['error'][$i] > 0){
	echo '<p class="error">The file could not be uploaded because: <strong>';
	//print message based on error
	switch($_FILES['upload']['error'][$i]){
		case 1:
			print 'The file exceeds the upload_max_filesize settiing in php.ini';
			break;
		case 2:
			print 'The file exceeds the MAX_FILE_SIZE setting in the html form';
			break;
		case 3:
			print 'The file was only partially uploaded';
			break;
		case 4:
			print 'No file was uploaded';
			break;
		case 6:
			print 'No temporary folder was available';
			break;
		case 7:
			print 'Unable to write to the disk';
			break;
		case  8:
			print 'File upload was stopped';
			break;
		default:
			print 'A system error occured';
			break;
		}//end of switch

		print '</strong></p>';

	}//end of error if

	//Delete file if if still exist
	if(file_exists($_FILES['upload']['tmp_name'][$i]) && is_files($_FILES['upload']['tmp_name'][$i])){
		unlink($_FILES['upload']['tmp_name'][$i]);
	}
}//end for loop

//////////////////////////////////////////////////////////////////
//the following are my functions which may or may not work
//their main function is to bring data from archiver.html
//and run various splitting and tagging functions on it
//aside  from the functions included here, everything
//works perfectly
//////////////////////////////////////////////////////////////////
//Initailize and assign values to starter variables.
    $show_id = "";
    $band = $_POST['band'];
    $date = $_POST['date'];
    $setOne = $_POST['setOne'];
    $set_oneNumOfSongs = count($setOne);
    
    ////////////////functions////////////////////
function create_song_array($set, $unique_show_id, $set_num) {
    /*function takes in show.set object, splits that object into
      an array, and then makes it multidiminsional. It then creates and
       assigns song ids to the first row of the array and song titles
        to the third row */
    
    //split the object into a dummy array based on ',' and '>', using perl-type regex
    $dummy_array = preg_split("/(,|>)/", $set);
    
    //use the trim() function to remove leading/trailing white spaces
    for($i=0;$i<count($dummy_array);$i++){
    	$dummy_array[$i] = trim($dummy_array[$i]);
}
    
    //then create the real array as a copy of dummy array
    $song_array = array(count($dummy_array));
    
    
    //make the real array multidiminsional and create eight
    //rows to hold the song's various properties
    for($i = 0; $i < count($dummy_array); $i++){
      $song_array[$i] = array(;
    }
    
    //assign song title, set_one_songs[2] = dummy_array[1]
    for($m = 0; $m < count($dummy_array); $m++){
      $song_array[$m][2] = $dummy_array[$m];
    }
    
    //assign unique song ids
    for($n = 0; $n < count($dummy_array); $n++) {
      $song_array[$n][0] = $unique_show_id . "s" . $set_num . "s" . ($n+1);
    }
    
    //return newly created array
    return $song_array;
  }//create_song_array
  
function showIdCreator($band, $date) {
    /*this function takes in the user inputed band name and show date.
     It then produces an abbreviation from the band name.
     It then returns this abbreviation combined with the show date
     to create the show id*/
    
    //variable declarations
    $abb;//store the abbreviated band name
    //convert the band name to lower case for easier comparison
    $band = strtolower($band);
    
    //set abbreviation based on band name
    switch($band) {
      case "widespread panic" :
        $abb = "wsp";
        break;
      case "grateful dead" :
        $abb = "gd";
        break;
      case "phish" :
        $abb =  "ph";
        break;
      case "ryan adams" :
        $abb =  "ra";
        break;
      default:
        $abb = "unknown";
    }
    
    //return a combination of the band name abbreviation and the show date
    return $abb . $date;
  }//end showIdCreator()  
    
    ////////////////end of functions//////////////////// 
    
    //create a unique show id
    $unique_show_id = showIdCreator($band, $date);

//create an array of songs based on set on and save it to an array of the same name
$set_one = create_song_array($setOne, $unique_show_id, "1");

//display show information
echo "The band is: " . $band . "<br>";
echo "The show date is: " . $date . "<br>";
echo "Unique show id: " . $unique_show_id . "<br><br>";
    				
?>

<form  enctype="multipart/form-data" action="upload_script.php" method="post">
<?php
//use a for loop to produce multiple upload boxes
for($i = 0; $i < count($setOne); $i++){
?>	
<input type ="hidden" name = "MAX_FILE_SIZE" value = "209715200" />

<fieldset><legend>Select a mp3 to upload:</legend>

<p><b>file:</b><input type="file" name ="upload[]" /></p>
</fieldset>

<?php
//end for loop
}
?>

<div align="center"><input type="submit" name="submit" value="Submit" /></div>
<input type="hidden" name="submitted" value="TRUE" />
</form>
</body>
</html>

Thanks, Dan

woodsonoversoul · December 8, 2008

bump for the day crew

gevans · December 8, 2008

for($i = 0; $i < count($setOne); $i++){

This line won't work properly

var $setOne Hasn't been set??

woodsonoversoul · December 8, 2008

Alright gevans! That helped the script execute the correct number of times, but now I just get multiple instances of the same error, . I'm still getting

Undefined index: upload

on the lines that read

if($_FILES['upload']['error'][$i] > 0){

and

if(file_exists($_FILES['upload']['tmp_name'][$i]) && is_files($_FILES['upload']['tmp_name'][$i])){

I feel like I must be initializing the array incorrectly in the html or something...

Here's my updated code. I've reorganized it a little...

<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN"
"http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">

<html xmlns="http://www.w3.org/1999/xhtml"
xml:lang="en" lang="en">

<head>
<meta http-equiv="content-type" content="text/html; charset=iso-8859-1" />

<title>File Uploader</title>
<style type="text/css" title ="text/css" media="all">
.error {
	font-weight: bold;
	color: #C00
}
</style>
</head>
<body>
<?php #File uploading script

//turn on error reporting
error_reporting(E_ALL);

//Initailize and assign values to starter variables.
    $show_id = "";
    $band = $_POST['band'];
    $date = $_POST['date'];
    $setOne = $_POST['setOne'];
    $set_oneNumOfSongs = count($setOne);
    
    //create a unique show id
    $unique_show_id = showIdCreator($band, $date);

//create an array of songs based on set on and save it to an array of the same name
$set_one = create_song_array($setOne, $unique_show_id, "1");
    
//start a loop to move through all the files
for($i = 0; $i < count($set_one); $i++){

//check to see if file has been submitted
if(isset($_POST['submitted'])){
	//if it has, check the type

	//debug - show all pertinate file info
	/*echo "<pre>";
        print_r($_FILES);
        echo "</pre>";
        */
        
	//create an array of allowed types (NOTE: need MIME type for Flac)
	$allowed = array('audio/mpeg');
	//now evaluate current file
	//check to see if current file's type is in the array of allowed types
	if(in_array($_FILES['upload']['type'][$i], $allowed)){
		//If True, move the file to new location
		if(move_uploaded_file($_FILES['upload']['tmp_name'][$i], "/home/dan/MusicDataBase/{$_FILES['upload']['name'][$i]}")){
			echo '<p><em>The file has been uploaded!</em></p>';
		}//end of move_uploaded_file
	} else {//invaild type
		echo '<p class="error">Error: Wrong filetype. Must be mp3</p>';
	}//end else
}//end isset($_FILES['upload']

//now check for additional errors

if($_FILES['upload']['error'][$i] > 0){
	echo '<p class="error">The file could not be uploaded because: <strong>';
	//print message based on error
	switch($_FILES['upload']['error'][$i]){
		case 1:
			print 'The file exceeds the upload_max_filesize settiing in php.ini';
			break;
		case 2:
			print 'The file exceeds the MAX_FILE_SIZE setting in the html form';
			break;
		case 3:
			print 'The file was only partially uploaded';
			break;
		case 4:
			print 'No file was uploaded';
			break;
		case 6:
			print 'No temporary folder was available';
			break;
		case 7:
			print 'Unable to write to the disk';
			break;
		case  8:
			print 'File upload was stopped';
			break;
		default:
			print 'A system error occured';
			break;
		}//end of switch

		print '</strong></p>';

	}//end of error if

	//Delete file if if still exist
	if(file_exists($_FILES['upload']['tmp_name'][$i]) && is_files($_FILES['upload']['tmp_name'][$i])){
		unlink($_FILES['upload']['tmp_name'][$i]);
	}
}//end for loop

//////////////////////////////////////////////////////////////////
//the following are my functions which may or may not work
//their main function is to bring data from archiver.html
//and run various splitting and tagging functions on it
//aside  from the functions included here, everything
//works perfectly
//////////////////////////////////////////////////////////////////

    ////////////////functions////////////////////
function create_song_array($set, $unique_show_id, $set_num) {
    /*function takes in show.set object, splits that object into
      an array, and then makes it multidiminsional. It then creates and
       assigns song ids to the first row of the array and song titles
        to the third row */
    
    //split the object into a dummy array based on ',' and '>', using perl-type regex
    $dummy_array = preg_split("/(,|>)/", $set);
    
    //use the trim() function to remove leading/trailing white spaces
    for($i=0;$i<count($dummy_array);$i++){
    	$dummy_array[$i] = trim($dummy_array[$i]);
}
    
    //then create the real array as a copy of dummy array
    $song_array = array(count($dummy_array));
    
    
    //make the real array multidiminsional and create eight
    //rows to hold the song's various properties
    for($i = 0; $i < count($dummy_array); $i++){
      $song_array[$i] = array(;
    }
    
    //assign song title, set_one_songs[2] = dummy_array[1]
    for($m = 0; $m < count($dummy_array); $m++){
      $song_array[$m][2] = $dummy_array[$m];
    }
    
    //assign unique song ids
    for($n = 0; $n < count($dummy_array); $n++) {
      $song_array[$n][0] = $unique_show_id . "s" . $set_num . "s" . ($n+1);
    }
    
    //return newly created array
    return $song_array;
  }//create_song_array
  
function showIdCreator($band, $date) {
    /*this function takes in the user inputed band name and show date.
     It then produces an abbreviation from the band name.
     It then returns this abbreviation combined with the show date
     to create the show id*/
    
    //variable declarations
    $abb;//store the abbreviated band name
    //convert the band name to lower case for easier comparison
    $band = strtolower($band);
    
    //set abbreviation based on band name
    switch($band) {
      case "widespread panic" :
        $abb = "wsp";
        break;
      case "grateful dead" :
        $abb = "gd";
        break;
      case "phish" :
        $abb =  "ph";
        break;
      case "ryan adams" :
        $abb =  "ra";
        break;
      default:
        $abb = "unknown";
    }
    
    //return a combination of the band name abbreviation and the show date
    return $abb . $date;
  }//end showIdCreator()  
    
    ////////////////end of functions//////////////////// 
    
    

//display show information
echo "The band is: " . $band . "<br>";
echo "The show date is: " . $date . "<br>";
echo "Unique show id: " . $unique_show_id . "<br><br>";
    				
?>

<form  enctype="multipart/form-data" action="upload_script.php" method="post">
<?php
//use a for loop to produce multiple upload boxes
for($i = 0; $i < count($set_one); $i++){
?>	
<input type ="hidden" name = "MAX_FILE_SIZE" value = "209715200" />

<fieldset><legend>Select a mp3 to upload:</legend>

<p><b>file:</b><input type="file" name ="upload[]" /></p>
</fieldset>

<?php
//end for loop
}
?>

<div align="center"><input type="submit" name="submit" value="Submit" /></div>
<input type="hidden" name="submitted" value="TRUE" />
</form>
</body>
</html>

Thanks,

Dan

woodsonoversoul · December 8, 2008

Thanks for all the help/ideas guys! Keep'em coming!

gevans · December 8, 2008

Is that your whole script??

where are functions like showIdCreator($band, $date);

and

create_song_array($setOne, $unique_show_id, "1");

??

woodsonoversoul · December 8, 2008

They're in there. I wish I could post code w/ line numbers. They start six clicks of the scroll bar down (on my screen)...

gevans · December 8, 2008

I can see where you're calling them, thus having those lines of code, but where are the functions set?

woodsonoversoul · December 8, 2008

Do you see this in the code I have listed?

 //////////////////////////////////////////////////////////////////
   //the following are my functions which may or may not work
   //their main function is to bring data from archiver.html
   //and run various splitting and tagging functions on it
   //aside  from the functions included here, everything
   //works perfectly
   //////////////////////////////////////////////////////////////////
   
    ////////////////functions////////////////////
function create_song_array($set, $unique_show_id, $set_num) {
    /*function takes in show.set object, splits that object into
      an array, and then makes it multidiminsional. It then creates and
       assigns song ids to the first row of the array and song titles
        to the third row */
    
    //split the object into a dummy array based on ',' and '>', using perl-type regex
    $dummy_array = preg_split("/(,|>)/", $set);
    
    //use the trim() function to remove leading/trailing white spaces
    for($i=0;$i<count($dummy_array);$i++){
       $dummy_array[$i] = trim($dummy_array[$i]);
   }
    
    //then create the real array as a copy of dummy array
    $song_array = array(count($dummy_array));
    
    
    //make the real array multidiminsional and create eight
    //rows to hold the song's various properties
    for($i = 0; $i < count($dummy_array); $i++){
      $song_array[$i] = array(;
    }
    
    //assign song title, set_one_songs[2] = dummy_array[1]
    for($m = 0; $m < count($dummy_array); $m++){
      $song_array[$m][2] = $dummy_array[$m];
    }
    
    //assign unique song ids
    for($n = 0; $n < count($dummy_array); $n++) {
      $song_array[$n][0] = $unique_show_id . "s" . $set_num . "s" . ($n+1);
    }
    
    //return newly created array
    return $song_array;
  }//create_song_array
  
function showIdCreator($band, $date) {
    /*this function takes in the user inputed band name and show date.
     It then produces an abbreviation from the band name.
     It then returns this abbreviation combined with the show date
     to create the show id*/
    
    //variable declarations
    $abb;//store the abbreviated band name
    //convert the band name to lower case for easier comparison
    $band = strtolower($band);
    
    //set abbreviation based on band name
    switch($band) {
      case "widespread panic" :
        $abb = "wsp";
        break;
      case "grateful dead" :
        $abb = "gd";
        break;
      case "phish" :
        $abb =  "ph";
        break;
      case "ryan adams" :
        $abb =  "ra";
        break;
      default:
        $abb = "unknown";
    }
    
    //return a combination of the band name abbreviation and the show date
    return $abb . $date;
  }//end showIdCreator()  
    
    ////////////////end of functions//////////////////// 
    
    

   ?>

gevans · December 8, 2008

Can you post the whole page script in one go?? I can string things together coz I don't know how you have it

premiso · December 8, 2008

Alright gevans! That helped the script execute the correct number of times, but now I just get multiple instances of the same error, . I'm still getting

Undefined index: upload

on the lines that read

if($_FILES['upload']['error'][$i] > 0){

and

if(file_exists($_FILES['upload']['tmp_name'][$i]) && is_files($_FILES['upload']['tmp_name'][$i])){

I feel like I must be initializing the array incorrectly in the html or something...

Here's my updated code. I've reorganized it a little...

<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN"
"http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">

<html xmlns="http://www.w3.org/1999/xhtml"
xml:lang="en" lang="en">

<head>
<meta http-equiv="content-type" content="text/html; charset=iso-8859-1" />

<title>File Uploader</title>
<style type="text/css" title ="text/css" media="all">
.error {
	font-weight: bold;
	color: #C00
}
</style>
</head>
<body>
<?php #File uploading script

//turn on error reporting
error_reporting(E_ALL);

//Initailize and assign values to starter variables.
    $show_id = "";
    $band = $_POST['band'];
    $date = $_POST['date'];
    $setOne = $_POST['setOne'];
    $set_oneNumOfSongs = count($setOne);
    
    //create a unique show id
    $unique_show_id = showIdCreator($band, $date);

//create an array of songs based on set on and save it to an array of the same name
$set_one = create_song_array($setOne, $unique_show_id, "1");
    
//start a loop to move through all the files
for($i = 0; $i < count($set_one); $i++){

//check to see if file has been submitted
if(isset($_POST['submitted'])){
	//if it has, check the type

	//debug - show all pertinate file info
	/*echo "<pre>";
        print_r($_FILES);
        echo "</pre>";
        */
        
	//create an array of allowed types (NOTE: need MIME type for Flac)
	$allowed = array('audio/mpeg');
	//now evaluate current file
	//check to see if current file's type is in the array of allowed types
	if(in_array($_FILES['upload']['type'][$i], $allowed)){
		//If True, move the file to new location
		if(move_uploaded_file($_FILES['upload']['tmp_name'][$i], "/home/dan/MusicDataBase/{$_FILES['upload']['name'][$i]}")){
			echo '<p><em>The file has been uploaded!</em></p>';
		}//end of move_uploaded_file
	} else {//invaild type
		echo '<p class="error">Error: Wrong filetype. Must be mp3</p>';
	}//end else
}//end isset($_FILES['upload']

//now check for additional errors

if($_FILES['upload']['error'][$i] > 0){
	echo '<p class="error">The file could not be uploaded because: <strong>';
	//print message based on error
	switch($_FILES['upload']['error'][$i]){
		case 1:
			print 'The file exceeds the upload_max_filesize settiing in php.ini';
			break;
		case 2:
			print 'The file exceeds the MAX_FILE_SIZE setting in the html form';
			break;
		case 3:
			print 'The file was only partially uploaded';
			break;
		case 4:
			print 'No file was uploaded';
			break;
		case 6:
			print 'No temporary folder was available';
			break;
		case 7:
			print 'Unable to write to the disk';
			break;
		case  8:
			print 'File upload was stopped';
			break;
		default:
			print 'A system error occured';
			break;
		}//end of switch

		print '</strong></p>';

	}//end of error if

	//Delete file if if still exist
	if(file_exists($_FILES['upload']['tmp_name'][$i]) && is_files($_FILES['upload']['tmp_name'][$i])){
		unlink($_FILES['upload']['tmp_name'][$i]);
	}
}//end for loop

//////////////////////////////////////////////////////////////////
//the following are my functions which may or may not work
//their main function is to bring data from archiver.html
//and run various splitting and tagging functions on it
//aside  from the functions included here, everything
//works perfectly
//////////////////////////////////////////////////////////////////

    ////////////////functions////////////////////
function create_song_array($set, $unique_show_id, $set_num) {
    /*function takes in show.set object, splits that object into
      an array, and then makes it multidiminsional. It then creates and
       assigns song ids to the first row of the array and song titles
        to the third row */
    
    //split the object into a dummy array based on ',' and '>', using perl-type regex
    $dummy_array = preg_split("/(,|>)/", $set);
    
    //use the trim() function to remove leading/trailing white spaces
    for($i=0;$i<count($dummy_array);$i++){
    	$dummy_array[$i] = trim($dummy_array[$i]);
}
    
    //then create the real array as a copy of dummy array
    $song_array = array(count($dummy_array));
    
    
    //make the real array multidiminsional and create eight
    //rows to hold the song's various properties
    for($i = 0; $i < count($dummy_array); $i++){
      $song_array[$i] = array(;
    }
    
    //assign song title, set_one_songs[2] = dummy_array[1]
    for($m = 0; $m < count($dummy_array); $m++){
      $song_array[$m][2] = $dummy_array[$m];
    }
    
    //assign unique song ids
    for($n = 0; $n < count($dummy_array); $n++) {
      $song_array[$n][0] = $unique_show_id . "s" . $set_num . "s" . ($n+1);
    }
    
    //return newly created array
    return $song_array;
  }//create_song_array
  
function showIdCreator($band, $date) {
    /*this function takes in the user inputed band name and show date.
     It then produces an abbreviation from the band name.
     It then returns this abbreviation combined with the show date
     to create the show id*/
    
    //variable declarations
    $abb;//store the abbreviated band name
    //convert the band name to lower case for easier comparison
    $band = strtolower($band);
    
    //set abbreviation based on band name
    switch($band) {
      case "widespread panic" :
        $abb = "wsp";
        break;
      case "grateful dead" :
        $abb = "gd";
        break;
      case "phish" :
        $abb =  "ph";
        break;
      case "ryan adams" :
        $abb =  "ra";
        break;
      default:
        $abb = "unknown";
    }
    
    //return a combination of the band name abbreviation and the show date
    return $abb . $date;
  }//end showIdCreator()  
    
    ////////////////end of functions//////////////////// 
    
    

//display show information
echo "The band is: " . $band . "<br>";
echo "The show date is: " . $date . "<br>";
echo "Unique show id: " . $unique_show_id . "<br><br>";
    				
?>

<form  enctype="multipart/form-data" action="upload_script.php" method="post">
<?php
//use a for loop to produce multiple upload boxes
for($i = 0; $i < count($set_one); $i++){
?>	
<input type ="hidden" name = "MAX_FILE_SIZE" value = "209715200" />

<fieldset><legend>Select a mp3 to upload:</legend>

<p><b>file:</b><input type="file" name ="upload[]" /></p>
</fieldset>

<?php
//end for loop
}
?>

<div align="center"><input type="submit" name="submit" value="Submit" /></div>
<input type="hidden" name="submitted" value="TRUE" />
</form>
</body>
</html>

Thanks,

Dan

Gevans, the entire code is there.

woodsonoversoul · December 8, 2008

The entire page is:

<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN"
"http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">

<html xmlns="http://www.w3.org/1999/xhtml"
xml:lang="en" lang="en">

<head>
<meta http-equiv="content-type" content="text/html; charset=iso-8859-1" />

<title>File Uploader</title>
<style type="text/css" title ="text/css" media="all">
.error {
	font-weight: bold;
	color: #C00
}
</style>
</head>
<body>
<?php #File uploading script

//turn on error reporting
error_reporting(E_ALL);

//Initailize and assign values to starter variables.
    $show_id = "";
    $band = $_POST['band'];
    $date = $_POST['date'];
    $setOne = $_POST['setOne'];
    
    
    //create a unique show id
    $unique_show_id = showIdCreator($band, $date);

//create an array of songs based on set on and save it to an array of the same name
$set_one = create_song_array($setOne, $unique_show_id, "1");
    
//start a loop to move through all the files
for($i = 0; $i < count($set_one); $i++){

//check to see if file has been submitted
if(isset($_POST['submitted'])){
	//if it has, check the type

	//debug - show all pertinate file info
	echo "<pre>";
        print_r($_FILES);
        echo "</pre>";
        
        
	//create an array of allowed types (NOTE: need MIME type for Flac)
	$allowed = array('audio/mpeg');
	//now evaluate current file
	//check to see if current file's type is in the array of allowed types
	if(in_array($_FILES['upload']['type'][$i], $allowed)){
		//If True, move the file to new location
		if(move_uploaded_file($_FILES['upload']['tmp_name'][$i], "/home/dan/MusicDataBase/{$_FILES['upload']['name'][$i]}")){
			echo '<p><em>The file has been uploaded!</em></p>';
		}//end of move_uploaded_file
	} else {//invaild type
		echo '<p class="error">Error: Wrong filetype. Must be mp3</p>';
	}//end else
}//end isset($_FILES['upload']

//now check for additional errors

if($_FILES['upload']['error'][$i] > 0){
	echo '<p class="error">The file could not be uploaded because: <strong>';
	//print message based on error
	switch($_FILES['upload']['error'][$i]){
		case 1:
			print 'The file exceeds the upload_max_filesize settiing in php.ini';
			break;
		case 2:
			print 'The file exceeds the MAX_FILE_SIZE setting in the html form';
			break;
		case 3:
			print 'The file was only partially uploaded';
			break;
		case 4:
			print 'No file was uploaded';
			break;
		case 6:
			print 'No temporary folder was available';
			break;
		case 7:
			print 'Unable to write to the disk';
			break;
		case  8:
			print 'File upload was stopped';
			break;
		default:
			print 'A system error occured';
			break;
		}//end of switch

		print '</strong></p>';

	}//end of error if

	//Delete file if if still exist
	if(file_exists($_FILES['upload']['tmp_name'][$i]) && is_files($_FILES['upload']['tmp_name'][$i])){
		unlink($_FILES['upload']['tmp_name'][$i]);
	}
}//end for loop

//////////////////////////////////////////////////////////////////
//the following are my functions which may or may not work
//their main function is to bring data from archiver.html
//and run various splitting and tagging functions on it
//aside  from the functions included here, everything
//works perfectly
//////////////////////////////////////////////////////////////////

    ////////////////functions////////////////////
function create_song_array($set, $unique_show_id, $set_num) {
    /*function takes in show.set object, splits that object into
      an array, and then makes it multidiminsional. It then creates and
       assigns song ids to the first row of the array and song titles
        to the third row */
    
    //split the object into a dummy array based on ',' and '>', using perl-type regex
    $dummy_array = preg_split("/(,|>)/", $set);
    
    //use the trim() function to remove leading/trailing white spaces
    for($i=0;$i<count($dummy_array);$i++){
    	$dummy_array[$i] = trim($dummy_array[$i]);
}
    
    //then create the real array as a copy of dummy array
    $song_array = array(count($dummy_array));
    
    
    //make the real array multidiminsional and create eight
    //rows to hold the song's various properties
    for($i = 0; $i < count($dummy_array); $i++){
      $song_array[$i] = array(;
    }
    
    //assign song title, set_one_songs[2] = dummy_array[1]
    for($m = 0; $m < count($dummy_array); $m++){
      $song_array[$m][2] = $dummy_array[$m];
    }
    
    //assign unique song ids
    for($n = 0; $n < count($dummy_array); $n++) {
      $song_array[$n][0] = $unique_show_id . "s" . $set_num . "s" . ($n+1);
    }
    
    //return newly created array
    return $song_array;
  }//create_song_array
  
function showIdCreator($band, $date) {
    /*this function takes in the user inputed band name and show date.
     It then produces an abbreviation from the band name.
     It then returns this abbreviation combined with the show date
     to create the show id*/
    
    //variable declarations
    $abb;//store the abbreviated band name
    //convert the band name to lower case for easier comparison
    $band = strtolower($band);
    
    //set abbreviation based on band name
    switch($band) {
      case "widespread panic" :
        $abb = "wsp";
        break;
      case "grateful dead" :
        $abb = "gd";
        break;
      case "phish" :
        $abb =  "ph";
        break;
      case "ryan adams" :
        $abb =  "ra";
        break;
      default:
        $abb = "unknown";
    }
    
    //return a combination of the band name abbreviation and the show date
    return $abb . $date;
  }//end showIdCreator()  
    
    ////////////////end of functions//////////////////// 
    
    

//display show information
echo "The band is: " . $band . "<br>";
echo "The show date is: " . $date . "<br>";
echo "Unique show id: " . $unique_show_id . "<br><br>";
    				
?>

<form  enctype="multipart/form-data" action="upload_script.php" method="post">
<?php
//use a for loop to produce multiple upload boxes
for($i = 0; $i < count($set_one); $i++){
?>	
<input type ="hidden" name = "MAX_FILE_SIZE" value = "209715200" />

<fieldset><legend>Select a mp3 to upload:</legend>

<p><b>file:</b><input type="file" name ="upload[]" /></p>
</fieldset>

<?php
//end for loop
}
?>

<div align="center"><input type="submit" name="submit" value="Submit" /></div>
<input type="hidden" name="submitted" value="TRUE" />
</form>
</body>
</html>

gevans · December 8, 2008

Ok I've had a very big fiddle,

keep a copy of your old code coz I can't test this right now;

<?php #File uploading script

//////////////////////////////////////////////////////////////////
//the following are my functions which may or may not work
//their main function is to bring data from archiver.html
//and run various splitting and tagging functions on it
//aside  from the functions included here, everything
//works perfectly
//////////////////////////////////////////////////////////////////

////////////////functions////////////////////
function create_song_array($set, $unique_show_id, $set_num) {
    /*function takes in show.set object, splits that object into
    an array, and then makes it multidiminsional. It then creates and
    assigns song ids to the first row of the array and song titles
    to the third row */

    //split the object into a dummy array based on ',' and '>', using perl-type regex
    $dummy_array = preg_split("/(,|>)/", $set);

    //use the trim() function to remove leading/trailing white spaces
    for($i=0;$i<count($dummy_array);$i++){
        $dummy_array[$i] = trim($dummy_array[$i]);
    }

    //then create the real array as a copy of dummy array
    $song_array = array(count($dummy_array));


    //make the real array multidiminsional and create eight
    //rows to hold the song's various properties
    for($i = 0; $i < count($dummy_array); $i++){
        $song_array[$i] = array(;
    }

    //assign song title, set_one_songs[2] = dummy_array[1]
    for($m = 0; $m < count($dummy_array); $m++){
        $song_array[$m][2] = $dummy_array[$m];
    }

    //assign unique song ids
    for($n = 0; $n < count($dummy_array); $n++) {
        $song_array[$n][0] = $unique_show_id . "s" . $set_num . "s" . ($n+1);
    }

    //return newly created array
    return $song_array;
}//create_song_array

function showIdCreator($band, $date) {
    /*this function takes in the user inputed band name and show date.
    It then produces an abbreviation from the band name.
    It then returns this abbreviation combined with the show date
    to create the show id*/

    //variable declarations
    $abb;//store the abbreviated band name
    //convert the band name to lower case for easier comparison
    $band = strtolower($band);

    //set abbreviation based on band name
    switch($band) {
        case "widespread panic" :
            $abb = "wsp";
            break;
        case "grateful dead" :
            $abb = "gd";
            break;
        case "phish" :
            $abb =  "ph";
            break;
        case "ryan adams" :
            $abb =  "ra";
            break;
        default:
        $abb = "unknown";
    }

    //return a combination of the band name abbreviation and the show date
    return $abb . $date;
}//end showIdCreator()  

////////////////end of functions//////////////////// 

function printHead(){
    echo '<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN"
       "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
       
            <html xmlns="http://www.w3.org/1999/xhtml"
            xml:lang="en" lang="en">

            <head>
       <meta http-equiv="content-type" content="text/html; charset=iso-8859-1" />
       
       <title>File Uploader</title>
       <style type="text/css" title ="text/css" media="all">
       .error {
          font-weight: bold;
          color: #C00
       }
       </style>
       </head>
       <body>';
}
   
//turn on error reporting
ini_set('display_errors', 'On');
error_reporting(E_ALL | E_STRICT);

printHead(); #print html head

//Initailize and assign values to starter variables.
$show_id = "";
$band = $_POST['band'];
$date = $_POST['date'];
$setOne = $_POST['setOne'];

//create a unique show id
$unique_show_id = showIdCreator($band, $date);

//create an array of songs based on set on and save it to an array of the same name
$set_one = create_song_array($setOne, $unique_show_id, "1");

//check to see if file has been submitted
if(isset($_POST['submitted'])){
    //start a loop to move through all the files
    for($i = 0; $i < count($set_one); $i++){
        //if it has, check the type

        //debug - show all pertinate file info
        /*echo "<pre>";
        print_r($_FILES);
        echo "</pre>";*/

        //create an array of allowed types (NOTE: need MIME type for Flac)
        $allowed = array('audio/mpeg');
        
        //now evaluate current file
        //check to see if current file's type is in the array of allowed types
        if(in_array($_FILES['upload']['type'][$i], $allowed)){
            //If True, move the file to new location
            if(move_uploaded_file($_FILES['upload']['tmp_name'][$i], "/home/dan/MusicDataBase/{$_FILES['upload']['name'][$i]}")){
                echo '<p><em>The file has been uploaded!</em></p>';
                //Delete file if if still exist
                if(file_exists($_FILES['upload']['tmp_name'][$i]) && is_files($_FILES['upload']['tmp_name'][$i])){
                    unlink($_FILES['upload']['tmp_name'][$i]);
                }
            } else {
                if($_FILES['upload']['error'][$i] > 0){
                    echo '<p class="error">The file could not be uploaded because: <strong>';
                    //print message based on error
                    switch($_FILES['upload']['error'][$i]){
                        case 1:
                            print 'The file exceeds the upload_max_filesize settiing in php.ini';
                            break;
                        case 2:
                            print 'The file exceeds the MAX_FILE_SIZE setting in the html form';
                            break;
                        case 3:
                            print 'The file was only partially uploaded';
                            break;
                        case 4:
                            print 'No file was uploaded';
                            break;
                        case 6:
                            print 'No temporary folder was available';
                            break;
                        case 7:
                            print 'Unable to write to the disk';
                            break;
                        case  8:
                            print 'File upload was stopped';
                            break;
                        default:
                            print 'A system error occured';
                            break;
                    }//end of switch
                    print '</strong></p>';
                }//end of error if
            }
        } else {//invaild type
            echo '<p class="error">Error: Wrong filetype. Must be mp3</p>';
        }//end else
    }
}//end for loop


//display show information
echo "The band is: " . $band . "<br>";
echo "The show date is: " . $date . "<br>";
echo "Unique show id: " . $unique_show_id . "<br><br>";

?>

<form  enctype="multipart/form-data" action="upload_script.php" method="post">
<?php
//use a for loop to produce multiple upload boxes
for($i = 0; $i < count($set_one); $i++){
   ?>   
<input type ="hidden" name = "MAX_FILE_SIZE" value = "209715200" />

<fieldset><legend>Select a mp3 to upload:</legend>

<p><b>file:</b><input type="file" name ="upload[]" /></p>
</fieldset>

<?php
//end for loop
}
?>

<div align="center"><input type="submit" name="submit" value="Submit" /></div>
<input type="hidden" name="submitted" value="TRUE" />
</form>
</body>
</html>

woodsonoversoul · December 8, 2008

Wow. Thanks gevans. I can't test this right now either, but look for the results later tonight.

Here's a simple question; what is the difference between print and echo?

gevans · December 8, 2008

nothing, they do the same thing!!

woodsonoversoul · December 8, 2008

That's what I thought. I notice some code switches back and forth between the two and was wondering why. I suppose it's just preference...

gevans · December 8, 2008

Exactly, I tend to use echo!

Whoever else has helped you may have used print

You may want to look up some others though printf() is different!

premiso · December 8, 2008

That's what I thought. I notice some code switches back and forth between the two and was wondering why. I suppose it's just preference...

Yea, just preference, whoever echo is proven to be faster than print. Since I bench tested that and found that out I only use echo and tend to use ' over " for a similiar reason. Although it does not speed it up noticeably I figure anything helps =)

gevans · December 9, 2008

You could also take a look at this...

differences

woodsonoversoul · December 9, 2008

Thanks for the link gevans. Could you tell me what you meant to change with the new code you posted? Without doing a line-by-line comparison, it looks pretty similar to the code I was already working with (save the header being in it's own function). Also, is there a functional reason why the header is in it's own function, or is that just a matter of style/tidyness?

gevans · December 9, 2008

I just re-structured it so that it was easier to read, and took full advantage of the if, for and while loops you're using. Things seemed to be in the wrong order. function for the header was just to tidy it.

Did it make any difference?

Sign In

[SOLVED] multi-file upload script

Recommended Posts

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Join the conversation

Important Information