semicolon

[justinh]

Is there anything special you have to do to echo a semicolon?

 

I have this code

 

 

     echo "<div id=\"category\" onclick=\"location.href=default.php?catid".$cats['cat_id'].";\">;

 

And for some reason it isn't linking to anything. It does work in plain html. But, once i bring it into PHP it doesn't seem to work.

 

You can see what I'm talking about here:

 

http://www.wmptest.com/clintormscart/default.php this should take you to that category's page

[rhodesa]

should be:

     echo "<div id=\"category\" onclick=\"window.location.href='default.php?catid=".$cats['cat_id']."';\">;

[wildteen88]

EDIT: Nevermind beaten to it

Its a JavaScript error. It should be:

     echo "<div id=\"category\" onclick=\"location.href='default.php?catid".$cats['cat_id']."';\">;

 

Alternatively your should  remove the onClick even entirely and wrap the contents of the div within an anchor tag, eg

     echo "<div id=\"category\"><a href=\"default.php?catid".$cats['cat_id'].|"\">DIV CONTENT HERE</a></div>";

[justinh]

hmmm that didnt work either..

 

heres the result:

http://www.wmptest.com/clintormscart/default.php

[gevans]

You need to 'escape it'

 

A backslash can be used in php to escape characters you want to use that are used within php itself;

 

     echo "<div id=\"category\" onclick=\"location.href='default.php?catid".$cats['cat_id']."'\;\">";

 

You also missed the last double quote to close the variable string

[wildteen88]

The links are working fine for me. However it loads the same content no mater what category you choose.

[justinh]

okay everything works great.. ty guys.. =)

[premiso]

hmmm that didnt work either..

 

heres the result:

http://www.wmptest.com/clintormscart/default.php

 

Honestly, for only 1 javascript statement, you do not need the semicolon, but as pointed out above, it was not the semicolon causing issues. It was the whole echo and not properly escaping certain elements:

 

   echo "<div id=\"category\" onclick=\"location.href='default.php?catid".$cats['cat_id']."'\">Content Here</div>";

 

Should work. But as stated, the semicolon was not causing the issue, just a non-escaped echo statement.