Sort by column name

[jeff5656]

I want to sort by column name when the user clicks that column.  However it does not work (no errors, but the display order is unchanged):

displayactive.php:

<?php

$column_name=$_GET['column_name'];
if(isset($column_name) and strlen($column_name)>0){
$query = $query . " order by $column_name ";
} 

$query = "SELECT * FROM `icu` WHERE `signoff_status` = 'a' AND `pod` = '". $pod ."' ";

$results = mysql_query ($query) or die (mysql_error());

<table >

<th ><a href='displayactive.php?column_name=rm_loc'>Rm</a> </th>
<th ><a href='displayactive.php?column_name=patient'> Patient </th>
<th > ICU Admit Dx </th>

[Maq]

Cause you don't close your PHP tag before table "?>"

[gevans]

swap it all round!!!

 

$column_name=$_GET['column_name'];
if(isset($column_name) and strlen($column_name)>0){
$query = $query . " order by $column_name ";
} 

$query = "SELECT * FROM `icu` WHERE `signoff_status` = 'a' AND `pod` = '". $pod ."' ";

$results = mysql_query ($query) or die (mysql_error());

 

should be

 

$query = "SELECT * FROM `icu` WHERE `signoff_status` = 'a' AND `pod` = '". $pod ."'";

if(isset($column_name) and strlen($column_name)>0){
$query = $query . " order by $column_name ";
} 

$results = mysql_query ($query) or die (mysql_error());

[gevans]

also there is an error in you sql syntax (which I've fixed) so you would have been having errors if you had them set as on