Jump to content

[SOLVED] Text not displaying


bravo14

Recommended Posts

Hii guys

 

the section in the code below that says

echo($row['content']);

does not display the data from the database

 

<?php include('includes/connect.php'); ?>
<?php 
$sql=('SELECT * FROM `tbl_content` WHERE `page_id` = \'' . $_GET['page_id'] . '\' LIMIT 1');
$result=mysql_query($sql);
while($row = mysql_fetch_array($result))
{
echo('

<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<title>Project Renovations | '.$row['title'].'</title>');
}
?>
<link rel="stylesheet" href="css/template_css.css" type="text/css" />
<link rel="shortcut icon" href="images/favicon.ico" />
</head>
<body>
<div align="center">
<table align="center" width="600px" bordercolor="#000066" border="2px single" >
<tr><td><table>
<tr><td valign="top">
<div id="header">
<div id="nav">
<?php
include_once('includes/nav_menu.php');
?>
</div>
</div>
</td>
</tr>
<tr><td align="right">


</td>
<tr>
  <td><div id="content">
  <div>
  <div id="maintext">
<?php
echo($row['content']);
?>
  </div>
  <div id="randomgallery">
  
  <?php include "randomimage.php"; ?>
  </div>
  </div>
  </div></td>
</tr>
</table>
</tr></tr></table>
</div>
</body>
</html>

 

Where have I gone wrong?

Link to post
Share on other sites

 

$result=mysql_query($sql);

while($row = mysql_fetch_array($result))

{

echo('

 

<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">

<html xmlns="http://www.w3.org/1999/xhtml">

<head>

<title>Project Renovations | '.$row['title'].'</title>');

}

?>

...

<?php

echo($row['content']);

?>

 

Where have I gone wrong?

 

Forgive me if I am seeing this incorrectly, but wouldn't that red } mean that $row[] is no longer the mysql result?

Link to post
Share on other sites

Forgive me if I am seeing this incorrectly, but wouldn't that red } mean that $row[] is no longer the mysql result?

It would show as the last row

 

---

 

Try:

 

echo "$row[content]";

It's good practice and correct syntax to have the quotes around the key, otherwise PHP will look for a constant with the name "content" first, then assume you meant with the key name "content"

 

---

 

@OP: whew, I don't know where to start on this one.

 

A few things I see right off the bat.

 

- No need for the loop if you're just going to limit the query to 1 result.

- No need to echo out the entire header of the page, just for the title

- There is no attribute for a table with "bordercolor" (use style="...")

 

With that being said, here is the updated code:

<?php include('includes/connect.php'); 

$sql=("SELECT * FROM `tbl_content` WHERE `page_id` = '" . $_GET['page_id'] . "' LIMIT 1");
$result=mysql_query($sql);
if(mysql_num_rows($result)==0) {
die("Database problems!");
}
$row = mysql_fetch_array($result);
?>

<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<title>Project Renovations | <?php echo $row['title'];?> </title>

<link rel="stylesheet" href="css/template_css.css" type="text/css" />
<link rel="shortcut icon" href="images/favicon.ico" />
</head>
<body>
<div align="center">
<table align="center" width="600px" style="border: 2px solid #000066;" >
<tr><td><table>
<tr><td valign="top">
<div id="header">
<div id="nav">
<?php
include_once('includes/nav_menu.php');
?>
</div>
</div>
</td>
</tr>
<tr><td align="right">


</td>
<tr>
  <td><div id="content">
  <div>
  <div id="maintext">
<?php
echo($row['content']);
?>
  </div>
  <div id="randomgallery">
  
  <?php include "randomimage.php"; ?>
  </div>
  </div>
  </div></td>
</tr>
</table>
</tr></tr></table>
</div>
</body>
</html>

 

Now, if you still aren't getting content, replace

echo($row['content']);

with:

echo '<pre>'; print_r($row); echo '</pre>';

and copy/paste the results here.

Link to post
Share on other sites

I have changed it a couple of times, trying a couple of things

 

<?php include('includes/connect.php'); ?>
<?php 
$sql=('SELECT * FROM `tbl_content` WHERE `page_id` = \'' . $_GET['page_id'] . '\' LIMIT 1');
$result=mysql_query($sql);
$row = mysql_fetch_array($result);
echo('

<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<title>Project Renovations | '.$row['title'].'</title>');
?>
<link rel="stylesheet" href="css/template_css.css" type="text/css" />
<link rel="shortcut icon" href="images/favicon.ico" />
</head>
<body>
<div align="center">
<table align="center" width="600px" bordercolor="#000066" border="2px single" >
<tr><td><table>
<tr><td valign="top">
<div id="header">
<div id="nav">
<?php
include_once('includes/nav_menu.php');
?>
</div>
</div>
</td>
</tr>
<tr><td align="right">


</td>
<tr>
  <td><div id="content">
  <div>
  <div id="maintext">
<?php
echo $row["content"];
?>
  </div>
  <div id="randomgallery">
  
  <?php include "randomimage.php"; ?>
  </div>
  </div>
  </div></td>
</tr>
</table>
</tr></tr></table>
</div>
</body>
</html>

 

the text is still not displaying

Link to post
Share on other sites

echo "

<!DOCTYPE html PUBLIC '-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd'>
<html xmlns='http://www.w3.org/1999/xhtml'>
<head>
<title>Project Renovations | ".$row['title']."</title>";

 

try that

Link to post
Share on other sites

<?php include('includes/connect.php'); 

$sql=("SELECT * FROM `tbl_content` WHERE `page_id` = '" . $_GET['page_id'] . "' LIMIT 1");
$result=mysql_query($sql);
if(mysql_num_rows($result)==0) {
die("Database problems!");
}
$row = mysql_fetch_array($result);
?>

<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<title>Project Renovations | <?php echo $row['title'];?> </title>

<link rel="stylesheet" href="css/template_css.css" type="text/css" />
<link rel="shortcut icon" href="images/favicon.ico" />
</head>
<body>
<div align="center">
<table align="center" width="600px" style="border: 2px solid #000066;" >
<tr><td><table>
<tr><td valign="top">
<div id="header">
<div id="nav">
<?php
include_once('includes/nav_menu.php');
?>
</div>
</div>
</td>
</tr>
<tr><td align="right">


</td>
<tr>
  <td><div id="content">
  <div>
  <div id="maintext">
<?php
echo($row['content']);
?>
  </div>
  <div id="randomgallery">
  
  <?php include "randomimage.php"; ?>
  </div>
  </div>
  </div></td>
</tr>
</table>
</tr></tr></table>
</div>
</body>
</html>

 

Now, if you still aren't getting content, replace

echo($row['content']);

with:

echo '<pre>'; print_r($row); echo '</pre>';

and copy/paste the results here.

Link to post
Share on other sites

This iw aht is in the code

 

<?php include('includes/connect.php'); 

$sql=("SELECT * FROM `tbl_content` WHERE `page_id` = '" . $_GET['page_id'] . "' LIMIT 1");
$result=mysql_query($sql);
if(mysql_num_rows($result)==0) {
die("Database problems!");
}
$row = mysql_fetch_array($result);
?>

<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<title>Project Renovations | <?php echo $row['title'];?> </title>

<link rel="stylesheet" href="css/template_css.css" type="text/css" />
<link rel="shortcut icon" href="images/favicon.ico" />
</head>
<body>
<div align="center">
<table align="center" width="600px" style="border: 2px solid #000066;" >
<tr><td><table>
<tr><td valign="top">
<div id="header">
<div id="nav">
<?php
include_once('includes/nav_menu.php');
?>
</div>
</div>
</td>
</tr>
<tr><td align="right">


</td>
<tr>
  <td><div id="content">
  <div>
  <div id="maintext">
<?php
echo '<pre>'; 
print_r($row); 
echo '</pre>';
?>
  </div>
  <div id="randomgallery">
  
  <?php include "randomimage.php"; ?>
  </div>
  </div>
  </div></td>
</tr>
</table>
</tr></tr></table>
</div>
</body>
</html>

 

And I am still getting a blank result

Link to post
Share on other sites

$result=mysql_query($sql)or die(mysql_error());

 

also echo the query out to make sure it correct.

 

and

 

 

while($row = mysql_fetch_assoc($result)){ //<<<start loop

 

 

}// end loop

Link to post
Share on other sites

$result=mysql_query($sql)or die(mysql_error());

 

also echo the query out to make sure it correct.

 

and

 

 

while($row = mysql_fetch_assoc($result)){ //<<<start loop

 

 

}// end loop

 

Yeah, add the or die on the query.

 

The while loop is unneeded, as stated before, since you're just limiting to 1 row

Link to post
Share on other sites

whoah,

$sql=("SELECT * FROM `tbl_content` WHERE `page_id` = '" . $_GET['page_id'] . "' LIMIT 1");

 

can I ask what happens when someone views the page

 

page.php?page_id=1; DROP TABLE `tbl_content`; SELECT * FROM `tbl_content` WHERE `page_id` = '1'

 

you would be running these queries

SELECT * FROM `tbl_content` WHERE `page_id` = '1';

DROP TABLE `tbl_content`;

SELECT * FROM `tbl_content` WHERE `page_id` = '1' LIMIT 1

 

called sql injection

 

$sql=("SELECT * FROM `tbl_content` WHERE `page_id` = '" . mysql_real_escape_string(intval($_GET['page_id'])) . "' LIMIT 1");

 

if $_GET['page_id'] is not an integer, remove the intval bit.

Link to post
Share on other sites

@OP add the following lines

error_reporting(E_ALL);
ini_set('display_errors', 1);

 

before this line:

include('includes/connect.php');

 

Your code should output something, even if nothing was returned from the query. If you're getting a blank page then it seems there is an error somewhere, and thus nothing is displayed. Adding the lines I suggested above should force PHP to spit errors out if there is a problem.

Link to post
Share on other sites

The site is at www.projectrenovations.co.uk and click on Services or Who Are We, and you will see thre result

 

The menu at the top is pulled using the same query and the title is populqated using the same query.

Link to post
Share on other sites

protect the database look at this example please.


<?php


$num_or_letter=('1234');

echo "<a href='{$_SERVER['PHP_SELF']}?cmd=$num_or_letter'>link</a>";

if($_GET['cmd']){

if(is_numeric($_GET['cmd'])){

// if using a database then use mysql_real_ecsape_string()

$id=(md5($_GET['cmd']));

echo " <br> my id is:\n <br> $id";

}else{

echo "<br> What that going in my database!";

exit;

}
}

?>
?>

Link to post
Share on other sites

little bit more advance if not a programmer.

<?php


$num_or_letter=base64_encode('abc');

echo "<a href='{$_SERVER['PHP_SELF']}?cmd=$num_or_letter'>link</a>";

if($_GET['cmd']){

if(is_numeric(base64_decode($_GET['cmd']))){

// if using a database then use mysql_real_escape_string()

$id=(md5($_GET['cmd']));

echo " <br> my id is:\n <br> $id";

}else{

echo "<br> What that going in my database!";

exit;

}
}

?>

Link to post
Share on other sites

Archived

This topic is now archived and is closed to further replies.

×
×
  • Create New...

Important Information

We have placed cookies on your device to help make this website better. You can adjust your cookie settings, otherwise we'll assume you're okay to continue.