[SOLVED] foreach();

[denoteone]

I think I have an issue with my array but and not sure. can anyone see what I am doing wrong?

 

$symbol_list = array("MCD", "^DJI");

$feed = GetQuote($symbol_list);

$sym_list = split(", ", $symbol);
foreach ($sym_list as $value)
{
echo $value;
}

Am I using this is the correct way?

[Ayon]

when you use the array() the comman creates an array starting at 0

array("MCD", "^DJI"); returns

array(
[0] MCD
[1] ^DJI
);

 

so you don't need the explode();

 

just remove the explode() line and do this:

foreach ($symbol_list as $value)
   {
echo $value;
}

[Maq]

What is in $symbol and where does it come from?

 

note: if you're not using a regex for the split, use explode(), it's faster.  If you do use a regex use preg_split()

 

   $sym_list = explode(", ", $symbol);

 

[denoteone]

here is the code in full. the symbol  is the symbol is the symbol_list array.

 

$symbol_list = array("MCD", "^DJI");
$feed = GetQuote($symbol_list);

echo $feed;

$fp = fopen("drop.xml", "a");
fwrite($fp, $feed);

function GetQuote($symbol)  
{

// Build xml result as we go
$xml_result = "<StockQuotes>";

// create symbol list
$sym_list = split(", ", $symbol);
foreach ($sym_list as $value)
{
               echo $value;        
}

[Maq]

Try:

 

$symbol_list = array("MCD", "^DJI");
$feed = GetQuote($symbol_list);

echo $feed;

$fp = fopen("drop.xml", "a");
fwrite($fp, $feed);
fclose($fp);

function GetQuote($symbol) 
{

   // Build xml result as we go
   $xml_result = "\n";
   
   // Grab each stock symbol and concatenate it to $xml_result 
   foreach ($symbol as $value)
   {
      $xml_result .= $value . "\n";
   }
   
   $xml_result .= "";
   return $xml_result;
}
?>

[Mark Baker]

Why are you executing split() against $symbol_list when it's already an array

 

either

$symbol_list = "MCD,^DJI";

 

or

 

comment out

// $sym_list = split(", ", $symbol);

and change

foreach ($sym_list as $value)

to

foreach ($symbol as $value)

 

[denoteone]

on fopen what mode will open the file for writing and overwrite all data in the file with the new data?

[Maq]

w

[denoteone]

thanks everyone for your help I am learning more and more everyday!