[SOLVED] MySQL Problem

[pudge1]

 

You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near ')' I keep getting that error whenever I try and run my script. Here is my script:

 

$my = mysql_connect("localhost","nintendo_pudge","*****");

if(!$my)

{

echo "Failed to Connect to MySQL Database<br />";

echo mysql_error();

exit;

}

else{}

 

 

$con2 = mysql_select_db("nintendo_urlblurusers", $my);

 

if(!$con2)

{

echo mysql_error();

exit;

}

else

{

}

 

$var = "CREATE TABLE Users

(

userID int NOT NULL AUTO_INCREMENT,

PRIMARY KEY(userID),

Username varchar(15),

Password varchar(15),

Email varchar(35),

AccountType varchar(10),

PayPalEmail varchar(35),

)";

 

$con3 = mysql_query($var,$my);

if(!$con3)

{

echo mysql_error();

exit;

}

else

{

}

 

$con4 = mysql_query("INSERT INTO urlblur_users (Username,Password,Email,AccountType,PPEmail)

VALUES ($username,$password,$email,$atype,$ppemail)");

 

if(!$con4)

{

echo myql_error();

exit;

}

else

{

}

 

mysql_close($my);

 

Anyway I am really new to MySQL this is my first MySQL form I have started. I am really good with PHP though.

[FaT3oYCG]

$var = "CREATE TABLE Users
(
userID int NOT NULL AUTO_INCREMENT,
PRIMARY KEY(userID),
Username varchar(15),
Password varchar(15),
Email varchar(35),
AccountType varchar(10),
PayPalEmail varchar(35),
)";

 

change to

 

$var = "CREATE TABLE Users
(
userID int NOT NULL AUTO_INCREMENT,
PRIMARY KEY(userID),
Username varchar(15),
Password varchar(15),
Email varchar(35),
AccountType varchar(10),
PayPalEmail varchar(35))";

[pudge1]

Fixed that problem thank you for that. But now I get this error:

You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '@yahoo.com,free,)' at line 2

[FaT3oYCG]

what is line 2?

[pudge1]

I don't know. MySQL's line system is a lot different than PHPs. However it must be where the $email variable is because I see @yahoo.com which is from the e-mail

[Infinitive]

Your strings should be in quotes:

'$email'

 

Also be careful about data validation, if you haven't guarded against injection (or accidental problems) yet.  I use something like:

 

$SafeVariable = addslashes(htmlspecialchars($RawVariable));

[pudge1]

Thank you for that both of those things.

[pudge1]

Hmm now I am getting a query is empty error.

[Infinitive]

Might want to repaste your code now, if there have been a few changes.

[pudge1]

$my = mysql_connect("localhost","nintendo_pudge","*********");

if(!$my)

{

echo "Failed to Connect to MySQL Database<br />";

echo mysql_error();

exit;

}

else{}

 

 

$con2 = mysql_select_db("nintendo_urlblurusers", $my);

 

if(!$con2)

{

echo mysql_error();

exit;

}

else

{

}

 

$con3 = mysql_query($var,$my);

if(!$con3)

{

echo mysql_error();

exit;

}

else

{

}

 

$con4 = mysql_query("INSERT INTO URLBlurUsers (Username,Password,Email,AccountType,PPEmail)

VALUES ('$username','$password','$email','$atype','$ppemail')");

 

if(!$con4)

{

echo mysql_error();

exit;

}

else

{

}

 

mysql_close($my);

echo '<div id="output"><br />You Have Registered Successfully<br /><br /></div>';

[corbin]

$SafeVariable = addslashes(htmlspecialchars($RawVariable));

 

mysql_real_escape_string() is preferred over addslashes() now.

 

Also, generally HTML is escaped when outputting to the web browser, not when inserting.

 

 

 

 

pudge1, $var isn't defined anywhere.

[pudge1]

lol Guess there is a lot of problems with my script. I forgot to take out that thing after I removed something. Anyway thank you. But now I have another problem ughhhh Unknown Column PPEmail in Field List

 

Updated Code:

 

$my = mysql_connect("localhost","nintendo_pudge","Franz5211-");
if(!$my)
{
echo "Failed to Connect to MySQL Database<br />";
echo mysql_error();
exit;
}
else{}


$con2 = mysql_select_db("nintendo_urlblurusers", $my);

if(!$con2)
{
echo mysql_error();
exit;
}
else
{
}


$con4 = mysql_query("INSERT INTO URLBlurUsers (Username,Password,Email,AccountType,PPEmail)
VALUES ('$username','$password','$email','$atype','$ppemail')");

if(!$con4)
{
echo mysql_error();
exit;
}
else
{
}

mysql_close($my);
echo '<div id="output"><br />You Have Registered Successfully<br /><br /></div>';
?>

[pudge1]

Nevermind fixed it. Works perfectly now. Thanks to all who helped or attempted to help.

[fenway]

Nevermind fixed it. Works perfectly now. Thanks to all who helped or attempted to help.

How?

[pudge1]

The column on the Table wasn't called something a little different.