Help with If else statement

[lzylzlz]

I'm pretty new to this. I'm trying to get it to display conversions of Celsius to Fahrenheit when the users types in "Celsius" and Fahrenheit to Celsius when the user types in "Fahrenheit" but so far no matter which i type, it displays both instead of just the ONE its suppose to. Any suggestions on what im doing wrong would be great. Heres what I have so far:

<?php
if ($input == null) {echo "<p>You failed to enter Fahrenheit or Celsius </p>"; }
   
else {
   if ($input == "farhenheit" or "Farhenheit") echo "<p>Coversion of 0 to 25 degrees Fahrenheit to Celsius: </p>";
      for ($i=0, $k =0; $k <=25; $i++, $k++)
      {$a= round(($i - 32)*5.0/9.0, 2); 
        echo $k . " degrees Farhenheit is equal to " . $a . " degrees Celsius <br>";
        }  
  
   if($input == "celsius" or "Celsius") echo "<p>Conversion of 0 to 25 degrees Celsius to Fahrenheit: </p>";
      for ($i=0, $k=0; $k <=25; $i++, $k++)
      {$b= round($i*9.0/5.0+32, 2);
       echo $k . " degrees Celsius is equal to " . $b . " degrees Farhenheit <br>";
       }
   }
    
?>

 

Edited for CODE tags.....

[Philip]

Proper syntax for the or is:

if($var = 'value' OR $var = 'AnotherVal')
// or
if($var = 'value' || $var = 'AnotherVal')

 

For your case I'd do:

if(strtolower($input) == 'fahrenheit') {

 

Also,

 if ($input == "farhenheit" or "Farhenheit") echo "<p>Coversion of 0 to 25 degrees Fahrenheit to Celsius: </p>";
      for ($i=0, $k =0; $k <=25; $i++, $k++)

That will only echo for the case, but will always run the for loop... you need to add curly brackets around the if contents

[lzylzlz]

i added my brackets so now ijust get a blank screen or an error saying unexpected end. Here's a sample of what I did:

 

if (strtolower($input) == 'Fahrenheit') { echo "<p>Coversion of 0 to 25 degrees fahrenheit to Celsius: </p>";

      for ($i=0, $k =0; $k <=25; $i++, $k++)

      {$a= round(($i - 32)*5.0/9.0, 2);

        echo $k . " degrees fahrenheit is equal to " . $a . " degrees Celsius <br>";

        } }

[Amtran]

End is usually caused by incorrect syntax with {} (curly braces). Check your code and make sure NONE of it is missing any of {} these guys.

 

On a side note, it would be MUCH easier to just make a radio button dealy instead of making them type in the type of conversion.

[Philip]

<?php
if(is_null($input)) {
echo "<p>You failed to enter Fahrenheit or Celsius </p>"; 
} else {
// using a switch, with all lowercase input
switch(strtolower($input)) {
	case 'farhenheit':
		echo "<p>Coversion of 0 to 25 degrees Fahrenheit to Celsius: </p>";
		for ($i=0, $k =0; $k <=25; $i++, $k++) {
			$a= round(($i - 32)*5.0/9.0, 2); 
			echo $k . " degrees Farhenheit is equal to " . $a . " degrees Celsius <br>";
		} 
	break;
	case 'celsius':
	// also the default case....
	default:
		echo "<p>Conversion of 0 to 25 degrees Celsius to Fahrenheit: </p>";
		for ($i=0, $k=0; $k <=25; $i++, $k++) {
			$b= round($i*9.0/5.0+32, 2);
			echo $k . " degrees Celsius is equal to " . $b . " degrees Farhenheit <br>";
		}
	break;
}
}
?>

Take a look at that.

On a side note, it would be MUCH easier to just make a radio button dealy instead of making them type in the type of conversion.

True - but you should still check their values to make sure its nothing that could endanger your script.

 

[Amtran]

Yup, it's very important to sanitize EVERYTHNG, especially during flu season.

 

You're right though, make sure you check it before it goes in your DB.

[grissom]

Be consistent about your spelling of the word fahrenheit.  It's not farhenheit.

[lzylzlz]

so far nothing has worked. I have to use an if elseif statement in my code. It still just runs the first block of code no matter what I put in the input field on my form. This is what I have:

 

if ($input = 'Fahrenheit' || 'fahrenheit') 

  { echo "<p>Conversion of 0 to 25 degrees Fahrenheit to Celsius: </p>";

      for ($i=0, $k =0; $k <=25; $i++, $k++)

    {  $a= round(($i - 32)*5.0/9.0, 2);

 

        echo $k . " degrees Fahrenheit is equal to " . $a . " degrees Celsius <br>";

        } }

 

  elseif($input = 'Celsius' || 'celsius') 

  {echo "<p>Conversion of 0 to 25 degrees Celsius to Fahrenheit: </p>";

      for ($i=0, $k=0; $k <=25; $i++, $k++)

      {$b= round($i*9.0/5.0+32, 2);

      echo $k . " degrees Celsius is equal to " . $b . " degrees Fahrenheit <br>";

      }}

 

else {echo "<p>You failed to enter Fahrenheit or Celsius </p>"; }

?>

[Philip]

Proper syntax for the or is:

if($var = 'value' OR $var = 'AnotherVal')
// or
if($var = 'value' || $var = 'AnotherVal')

[lzylzlz]

I fixed that but it doesn't solve my problem =(

[Philip]

So.... what's your current code?

[lzylzlz]

I actually JUST figured it out!! i put in == instead of just one = in my if statements. Works perfectly now

[Philip]

Oops, my bad typo sorry