functions with multiple paramters...

[blueman378]

Hi guys,

 

Im wondering i have a function which draws some stuff, anyway it takes 5 paramaters but the only one that changes when i call it in one place (over 20 times) is the text.

 

So im wondering is there any way to say

 

params = "param value 2, param value 3, param value 4, param value 5";

text = "text1";

function_name(text, params);

 

instead of repeating all the info over and over, the function itself cannot be edited.

 

i tried doing basically what i said above except it treats it as a single paramter, is there any way to make it treat it as all the params?

[mikesta707]

without being able to change the function, i'm afraid you can't alter how many, or how the parameters are passed

[blueman378]

ah cheers,

 

im suprised there isnt anything to take a string and treat it asif it was literally in that spot, oh well.

[mikesta707]

you can use eval. something like

params = "param value 2, param value 3, param value 4, param value 5";
text = "text1"; 
eval("function_name(".$text.", ".$params.")");

didnt test this though.

 

and eval is not the best way to go. It will be a kind of shortcut for what you want to do, but eval is much slower than just normally parsing php, and since you are more or less being lazy there really isn't any substantial reason to use eval in this case. why can't you alter the function?

[blueman378]

I cant alter it because the function is i a class i dont have control over (other coders are working on that class), and im not really being lazy, jsut trying to find ways to make the code tidier,

[mikesta707]

the cons of using eval far out weight any pros you get from using eval. If you would be using eval alot, you will see a hige decrease in preformance. It may be ok if you are going to be doing a couple of times, but any more than 5 and I would stay away from it. also, if any user input ever goes into eval, you have to make sure you sanitze it as well as you can

[Mark Baker]

$baseParams = array("param value 2", "param value 3", "param value 4", "param value 5");
$text = "text1"; 
call_user_func_array("function_name", array_merge(array($text), $baseParams);

 

[JAY6390]

You could of course use the func_get_args() to get all the arguments of the function. That way you don't actually need to specify them at all, and just let your function handle them

Take a look at a function I created here that combines mysql_real_escape_string and the sprintf function

http://www.jaygilford.com/php/sprintf-and-mysql_real_escape_string-all-in-one-function/

[trq]

You could of course use the func_get_args() to get all the arguments of the function. That way you don't actually need to specify them at all, and just let your function handle them

Take a look at a function I created here that combines mysql_real_escape_string and the sprintf function

http://www.jaygilford.com/php/sprintf-and-mysql_real_escape_string-all-in-one-function/

 

the OP doesn't have access to the function definition.

[JAY6390]

Oh, oops! My bad lol. Didn't realise that

 

I would highly recommend against using eval for it also, as you don't want to be messing with stuff like that

 

Surely you could use call_user_func in it's place

[trq]

Oh, oops! My bad lol. Didn't realise that

 

I would highly recommend against using eval for it also, as you don't want to be messing with stuff like that

 

Surely you could use call_user_func in it's place

 

Yeah, call_user_func_array has already been suggested.

[JAY6390]

oh dear, I think I need to go back to sleep