Email Verified

[Kristoff1875]

Don't shoot me please!!!

 

I've tried about 50 different ways of doing this but still can't get the sender to check whether the email is of the right format ie (name@email.com), I don't even care if the email is real as long as it's in email format.

 

Here is my code:

 

<?php
$myemail = "****";
$name = $_POST['name'] ;
$email = $_POST['email'] ;
$phone = $_POST['phone'] ;
$dobday = $_POST['dobday'] ;
$dobmonth = $_POST['dobmonth'] ;
$dobyear = $_POST['dobyear'] ;
$town = $_POST['town'] ;

if (empty($name) || empty($email) || empty($phone) || empty($dobday) || empty($dobmonth) || empty($dobyear) || empty($town)){
header("Location: error.php");
}
else
{
$message = "Someone has filled out Mailing List Form:\n
\n
Name: $name\n
Email: $email\n
Phone: $phone\n
D.O.B: $dobday $dobmonth $dobyear\n
Town: $town\n";

mail ($myemail, "Mailing List Form", $message, "From: $email");

header("Location: formsubmitted.php");
}
?> 

 

Any help appreciated!

[Maq]

You should be using regex, specifically the preg_match method.  There should be examples in the PHP Regex child section.  BTW, the only attempt I see is checking that it's not empty.

[Kristoff1875]

I know, that is the only attempt on there at the moment as everything else i've tried just brings up an error?

 

EDIT:

 

Just tried this again:

 

<?php
$myemail = "";
$name = $_POST['name'] ;
$email = $_POST['email'] ;
$phone = $_POST['phone'] ;
$dobday = $_POST['dobday'] ;
$dobmonth = $_POST['dobmonth'] ;
$dobyear = $_POST['dobyear'] ;
$town = $_POST['town'] ;

function valid_email($email) {
  // check an email address is possibly valid
  if (ereg("^[a-zA-Z0-9_\.\-]+@[a-zA-Z0-9\-]+\.[a-zA-Z0-9\-\.]+$", $email)) {
    return true;
  } else {
    return false;
  }
}

if (empty($name) || empty($email) || empty($phone) || empty($dobday) || empty($dobmonth) || empty($dobyear) || empty($town)){
header("Location: error.php");
}
else
{
$message = "Someone has filled out Mailing List Form:\n
\n
Name: $name\n
Email: $email\n
Phone: $phone\n
D.O.B: $dob\n
Town: $town\n";

mail ($myemail, "Mailing List Form", $message, "From: $email");

header("Location: formsubmitted.php");
}
?> 

 

And it works, but it allowed "test" as the email 

[Maq]

Try something like this:

 

if(preg_match("~[A-Z0-9._%+-]+@[A-Z0-9.-]+\.[A-Z]{2,4}~i", $email))
{
  return TRUE;
}
else
{
  echo FALSE;
}

 

EDIT: Moving to the more appropriate PHP Regex child board.

[Kristoff1875]

Thanks but same result, it just goes through successful.

[iarp]

This is the code i used when i made a registration page, it checked length first which can easily be removed. Mod to your needs. escape_data() was a function i made that made sure it was clean to be inserted into myself database..

 

	if (strlen($_POST['email']) <= 40) {
	if (eregi ('^[[:alnum:]][a-z0-9_\.\-]*@[a-z0-9\.\-]+\.[a-z]{2,4}$', stripslashes(trim($_POST['email'])))) {
		$e = escape_data($_POST['email']);
	} else {
		$e = FALSE;
		echo '<p><font color="red" size="+1">Please enter a valid email address!</font></p>';
	}
} else {
	$e = FALSE;
	echo '<p>The email address you provided exceeds maximum length of 40 letters</p>';
} 

[Maq]

Thanks but same result, it just goes through successful.

 

No it doesn't, I just tested it.  If the $email is equal to "test" it will return false.  Can I see how you're calling this?

[cags]

I'm confident the OP isn't calling it, I'm guessing that post a few back is their full code.

[Kristoff1875]

Hi, thanks for the assistance!

 

This is my full code from the php sender:

 

<?php
$myemail = "info@******.com";
$name = $_POST['name'] ;
$email = $_POST['email'] ;
$phone = $_POST['phone'] ;
$dobday = $_POST['dobday'] ;
$dobmonth = $_POST['dobmonth'] ;
$dobyear = $_POST['dobyear'] ;
$town = $_POST['town'] ;

if(preg_match("~[A-Z0-9._%+-]+@[A-Z0-9.-]+\.[A-Z]{2,4}~i", $email))
{
  return TRUE;
}
else
{
  echo FALSE;
}

if (empty($name) || empty($email) || empty($phone) || empty($dobday) || empty($dobmonth) || empty($dobyear) || empty($town)){
header("Location: error.php");
}
else
{
$message = "Someone has filled out The Honey Club Mailing List Form:\n
\n
Name: $name\n
Email: $email\n
Phone: $phone\n
D.O.B: $dob\n
Town: $town\n";

mail ($myemail, "Mailing List Form", $message, "From: $email");

header("Location: formsubmitted.php");
}
?> 

 

It goes to formsubmitted.php and the email is sent, but even if the email is just "test" it still sends fine 

 

Thanks again!

[Kristoff1875]

Anyone any ideas?

 

Cheers

[salathe]

It goes to formsubmitted.php and the email is sent, but even if the email is just "test" it still sends fine 

 

Lets run through your code with the email set to "test".

 

if(preg_match("~[A-Z0-9._%+-]+@[A-Z0-9.-]+\.[A-Z]{2,4}~i", $email))
{
  return TRUE;
}
else
{
  echo FALSE;
}

 

If the email "test" matches that pattern, the page execution is stopped (due to return) with a value of TRUE. In all likelihood, that is not what you want to be happening. If the email address matches the pattern (ie, is what you want to be considered a valid email address) then we want to allow execution to continue processing! 

 

Since our email "test" does not match the pattern, we are moved to the else block which echoes FALSE (an empty string, nothing). There is nothing here stopping the execution of the page so we go down to the next if block.

 

if (empty($name) || empty($email) || empty($phone) || empty($dobday) || empty($dobmonth) || empty($dobyear) || empty($town)){
header("Location: error.php");
}
else
{
$message = "Someone has filled out The Honey Club Mailing List Form:\n
\n
Name: $name\n
Email: $email\n
Phone: $phone\n
D.O.B: $dob\n
Town: $town\n";

mail ($myemail, "Mailing List Form", $message, "From: $email");

header("Location: formsubmitted.php");
}

 

Lets assume all of the other values have been provided and don't constitute being "empty", we know that email isn't empty (remember, it is "test").  Because none of them are "empty" again we are moved to the else block.  This one sends the email.

 

In conclusion, if a valid email is provided (according to your regular expression) then execution of the page is stopped. If an invalid email is provided and one or more of the other values is "empty" then the page is redirected to error.php. If an invalid email is provided and all of the other values are not "empty" then, and only then, the email is sent.

 

Can you see the problem?

 

 

[Kristoff1875]

I think I see that because even if it's false, it's still submitting the form as long as the others are all filled in, however, I did try making the false part go to the error page, which still didnt work.

 

The only thing I can think is that there should be a check as well as the checks to make sure the fields are filled in, that checks whether preg_match is true or false?

 

No idea how I should do that so any advice is greatly appreciated!

 

Thanks for the help!!

[Kristoff1875]

Still no closer to this if anyone has any welcome ideas?

 

Thanks