can u help me with deleting from database

[mattm1712]

hi this script deosnt work i cantunderstand y?

 

these are the 3 coloums in my database

 

id

comments

submittedby

 

this is the code

<?php

 

$dbusername="web123-matt";

$dbpassword="matt";

$dbdatabase="web123-matt";

mysql_connect(localhost,$dbusername,$dbpassword);

mysql_select_db("comments");

 

if(!isset($_GET['cmd']))

{

    $result = mysql_query("select id, comments, submittedby FROM comments ORDER BY id");

 

    while($r = mysql_fetch_assoc($result))

    {

        $id = $r['id'];

        $comments = $r['comments'];

        $submittedby = $r['submittedby'];

     

        echo "<a href='delete.php?cmd=delete&id=$id'>$submittedby - Delete</a>";

      echo "<br>";

    }

}

elseif(isset($_GET['cmd']))

{

  if($_GET["cmd"]=="delete" && (isset($_GET['id']) && is_numeric($_GET['id'])))

    {

        include 'connect.inc';

        $sql = "DELETE FROM comments WHERE id=$id";

        $result = mysql_query($sql);

        echo "Row deleted!";

    }

 

}

 

?>

[premiso]

A. You are including connect.inc, when you have a connect function at the top of the script. What is the purpose of that?

B. You are not setting $id = $_GET['id'] so $id is essentially empty.