Small Syntax Issue

[bobicles2]

The code below after Inserting into my table echos either "error:" or "Thank you.." where have i gone wrong here? the intention was to echo an error if there was one...otherwise if it works fine and adds to the table echo "Thanks etc"

 

$sql="INSERT INTO Events (Event, Genre, Date, Price, Venue, Tickets, Postcode)
      VALUES ('$event','$genre','$date','$price','$venue','$tickets','$postcode')";
$result = mysql_query($sql, $con);

if ($result)
{
    echo "Error :" . mysql_error();
}
else
{
    echo "Thank You, Your Event has now been added to our Records";
}

mysql_close($con);

[andrewgauger]

First, I know this is handy for debugging, but don't echo errors to the end users, they don't need to know your table's structure.  Second, testing if ($result) is not the correct way to do this:

 

try:

$sql="INSERT INTO Events (Event, Genre, Date, Price, Venue, Tickets, Postcode)
      VALUES ('$event','$genre','$date','$price','$venue','$tickets','$postcode')";
if (!mysql_query($sql, $con))
{
echo "error!";
}
else
{
echo "Thank you";
}

 

Really the only thing you had wrong is they were backwards.

 

[Mchl]

  Quote

Second, testing if ($result) is not the correct way to do this:

 

Why not?

[andrewgauger]

When I typed that I was thinking it was a select query, I forgot to remove that from the post. 

 

EDIT:  this is a valid way to test for INSERT queries.

[bobicles2]

  Quote

When I typed that I was thinking it was a select query, I forgot to remove that from the post. 

 

EDIT:  this is a valid way to test for INSERT queries.

 

slightly confused, so your revised version should work fine?

 

 

[cags]

To clarify andrewgaugers code will work. Your original code was back to front. You were outputting an error message if $result was true, whereas as result of true means the insert was successful.

[andrewgauger]

Yeah, the code was fine, but the statement "Second, testing if ($result) is not the correct way to do this:" should have been removed.