query failed

[zhshero]

Can someone help me with my problem

i'm trying to make and thing to update my database

so i can update first name last name and login

but i get a "query failed"

 

update-exec.php

<?php
//Start session
session_start();

//Include database connection details
require_once('config.php');

//Array to store validation errors
$errmsg_arr = array();

//Validation error flag
$errflag = false;

//Connect to mysql server
$link = mysql_connect(DB_HOST, DB_USER, DB_PASSWORD);
if(!$link) {
	die('Failed to connect to server: ' . mysql_error());
}

//Select database
$db = mysql_select_db(DB_DATABASE);
if(!$db) {
	die("Unable to select database");
}

//Function to sanitize values received from the form. Prevents SQL injection
function clean($str) {
	$str = @trim($str);
	if(get_magic_quotes_gpc()) {
		$str = stripslashes($str);
	}
	return mysql_real_escape_string($str);
}

//Sanitize the POST values
$fname = clean($_POST['fname']);
$lname = clean($_POST['lname']);
$login = clean($_POST['login']);

//Input Validations
if($fname == '') {
	$errmsg_arr[] = 'First name missing';
	$errflag = true;
}
if($lname == '') {
	$errmsg_arr[] = 'Last name missing';
	$errflag = true;
}
if($login == '') {
	$errmsg_arr[] = 'login missing';
	$errflag = true;
}




//Create INSERT query
$qry = "INSERT INTO members(firstname, lastname, login,) VALUES('$fname','$lname','$login')";
$result = @mysql_query($qry);

//Check whether the query was successful or not
if($result) {
	header("location: member-index.php");
	exit();
}else {
	die("Query failed");
}
?>

 

<form id="loginForm" name="loginForm" method="post" action="update-exec.php">
First Name<input name="fname" type="text" value="<?php echo $_SESSION['SESS_FIRST_NAME'];?>" class="textfield" id="fname" />
Last Name<input name="lname" type="text" value="<?php echo $_SESSION['SESS_LAST_NAME'];?>" class="textfield" id="lname" />
Login<input name="login" type="text" value="<?php echo $_SESSION['SESS_USERNAME'];?>" class="textfield" id="login" />
<input type="submit" name="Submit" value="Update" />
</form>

 

 

 

[Maq]

Echo $qry after this line:

 

$qry = "INSERT INTO members(firstname, lastname, login,) VALUES('$fname','$lname','$login')";

[zhshero]

Echo $qry after this line:

 

$qry = "INSERT INTO members(firstname, lastname, login,) VALUES('$fname','$lname','$login')";

 

i got this :S

INSERT INTO members(firstname, lastname, login,) VALUES('zachary','harrison','zhshero')Query failed

 

 

[AbraCadaver]

To start with, change:

 

die("Query failed");

To:

 

die(mysql_error());

[harristweed]

$qry = "INSERT INTO members(firstname, lastname, login,) VALUES('$fname','$lname','$login')";

remove comma after login

$qry = "INSERT INTO members(firstname, lastname, login) VALUES('$fname','$lname','$login')";

[zhshero]

$qry = "INSERT INTO members(firstname, lastname, login,) VALUES('$fname','$lname','$login')";

remove comma after login

$qry = "INSERT INTO members(firstname, lastname, login) VALUES('$fname','$lname','$login')";

 

 

that salved the query failed part, i guess instead of using INSERT i should use UPDATE?

but it isn't doing anything to my datebase