header redirect not working - no error

[dflow]

 

this code works

 

if i use the header() in the else section it doesnt but it will echo the commented part  :confused:

 

 

<?
/**
* User has already logged in, so display relevant links, including
* a link to the admin center if the user is an administrator.
*/
if($session->logged_in){
   echo "<li>Logged In ";
   echo "<b>$session->username</b></li>";
   if($session->isAdmin()){
      echo "<li><a href=\"LoginSystem/admin/admin.php\">Admin Center</a></li>";
   }
   
   echo "<li><a href=\"../LoginSystem/process.php\">Logout</a</li>";
}

else{header("Location: ../LoginSystem/main.php");
//echo "<li><a href=\"../LoginSystem/process.php\">Login</a></li>";

}
?>

[BlueSkyIS]

where is $session defined?

 

use <?php instead of <?

 

use exit after header()

[fortnox007]

aren't the headers already sent after you echo out?

[dflow]

 

$session is defined before with :

include("include/session.php");

 

 

the exit() as you suggested is executed

it just doesnt redirect

 

 

[dflow]

aren't the headers already sent after you echo out?

 

in case the user is not logged in then no

[the182guy]

Try without using the relative path in the header.

[Pikachu2000]

Do you have error reporting at maximum, and display_errors on?

[dflow]

Try without using the relative path in the header.

doesnt help

[dflow]

Do you have error reporting at maximum, and display_errors on?

display_errors STDOUT

error_reporting 6135

[jake2891]

just remove the line above your opening php tag and place the php tag right at the top with no space and it should be fine.

[dflow]

just remove the line above your opening php tag and place the php tag right at the top with no space and it should be fine.

 

nada

removed the line and still not redirecting

[Pikachu2000]

Is there anything at all on the page when the redirect fails? Perhaps a logout link?

[dflow]

Is there anything at all on the page when the redirect fails? Perhaps a logout link?

no

but if i try echo :

echo "<li><a href=\"../LoginSystem/process.php\">Login</a></li>";

 

it is shown

[johnny86]

header('Location: ') needs absolute url to work if we are specific. So use:

header('Location: http://mysite.com/loginsystem/main.php');

[Pikachu2000]

Comment out the current code, and put this in its place.

<?php
/**
* User has already logged in, so display relevant links, including
* a link to the admin center if the user is an administrator.
*/
if($session->logged_in){
echo "<li>Logged In ";
echo "<b>$session->username</b></li>";
if($session->isAdmin()){
	echo "<li><a href=\"LoginSystem/admin/admin.php\">Admin Center</a></li>";
}
echo "<li><a href=\"../LoginSystem/process.php\">Logout</a</li>";
} else {
//header("Location: ../LoginSystem/main.php");
//echo "<li><a href=\"../LoginSystem/process.php\">Login</a></li>";
if( headers_sent() ) {
	echo 'Headers already sent.';
} else {
	echo 'Headers not yet sent.';
}
}
?>

[jcbones]

Headers will not re-direct in Chrome, unless you send a Status: 200 with it.

[dflow]

Comment out the current code, and put this in its place.

<?php
/**
* User has already logged in, so display relevant links, including
* a link to the admin center if the user is an administrator.
*/
if($session->logged_in){
echo "<li>Logged In ";
echo "<b>$session->username</b></li>";
if($session->isAdmin()){
	echo "<li><a href=\"LoginSystem/admin/admin.php\">Admin Center</a></li>";
}
echo "<li><a href=\"../LoginSystem/process.php\">Logout</a</li>";
} else {
//header("Location: ../LoginSystem/main.php");
//echo "<li><a href=\"../LoginSystem/process.php\">Login</a></li>";
if( headers_sent() ) {
	echo 'Headers already sent.';
} else {
	echo 'Headers not yet sent.';
}
}
?>

 

i get Headers already sent.

[dflow]

Headers will not re-direct in Chrome, unless you send a Status: 200 with it.

 

ok thanks

[johnny86]

Then you cannot send anymore headers. You have to check your code so that you don't echo anything to the page. You may not have any static html before the redirect either.

[Pikachu2000]

Nothing at all, not even white space can be sent to the browser before a header() redirect. You'll have to figure where the output is coming from and kill it before the redirect will work. Is there anything in a View -> Page Source?

[dflow]

ok thanks, it redirects now

 

but this means i need to divide up an include file and set on top of each page in the system this header

 

any work arounds?

[johnny86]

Use output buffering and dump everything at the end of your script.

 

ob_start() - http://php.net/ob_start

ob_end_flush() - http://php.net/ob_start